linux.git/drivers/gpu/drm/xe/xe_module.c, branch v6.9

drm/xe/pmu: Remove PMU from Xe till uapi is finalized

2023-12-21T16:46:59+00:00

PMU uapi is likely to change in the future. Till the uapi is finalized,
remove PMU from Xe. PMU can be re-added after uapi is finalized.

v2: Include xe_drm.h in xe/tests/xe_dma_buf.c (Francois)

Signed-off-by: Ashutosh Dixit 
Acked-by: Aravind Iddamsetty 
Acked-by: Lucas De Marchi 
Reviewed-by: Umesh Nerlige Ramappa 
Acked-by: José Roberto de Souza 
Acked-by: Mateusz Naklicki 
Signed-off-by: Rodrigo Vivi

drm/xe/gsc: Define GSC FW for MTL

2023-12-21T16:45:06+00:00

We track GSC FW based on its compatibility version, which is what
determines the interface it supports.
Also add a modparam override like the ones for GuC and HuC.

v2: fix module param description (John)

Signed-off-by: Daniele Ceraolo Spurio 
Cc: Alan Previn 
Cc: John Harrison 
Reviewed-by: John Harrison 
Signed-off-by: Rodrigo Vivi

drm/xe: Encapsulate all the module parameters

2023-12-21T16:45:05+00:00

Encapsulate all the module parameters in one single global struct
variable. This also removes the extra xe_module.h from includes.

v2: naming consistency as suggested by Jani and Lucas
v3: fix checkpatch errors/warnings
v4: adding blank line after struct declaration

Cc: Jani Nikula 
Cc: Lucas De Marchi 
Signed-off-by: Bommithi Sakeena 
Reviewed-by: Lucas De Marchi 
Signed-off-by: Rodrigo Vivi

drm/xe/display: Implement display support

2023-12-21T16:43:39+00:00

As for display, the intent is to share the display code with the i915
driver so that there is maximum reuse there.

We do this by recompiling i915/display code twice.
Now that i915 has been adapted to support the Xe build, we can add
the xe/display support.

This initial work is a collaboration of many people and unfortunately
this squashed patch won't fully honor the proper credits.
But let's try to add a few from the squashed patches:

Co-developed-by: Matthew Brost 
Co-developed-by: Jani Nikula 
Co-developed-by: Lucas De Marchi 
Co-developed-by: Matt Roper 
Co-developed-by: Mauro Carvalho Chehab 
Co-developed-by: Rodrigo Vivi 
Co-developed-by: Dave Airlie 
Signed-off-by: Maarten Lankhorst 
Signed-off-by: Rodrigo Vivi 
Signed-off-by: Lucas De Marchi

drm/xe/uc: Add GuC/HuC firmware path overrides

2023-12-21T16:41:14+00:00

When testing a new binary and/or debugging binary-related issues, it is
useful to have the option to change which binary is loaded without
having to update and re-compile the kernel. To support this option, this
patch adds 2 new modparams to override the FW path for GuC and HuC. The
HuC modparam can also be set to an empty string to disable HuC loading.

Note that those modparams only take effect on platforms where we already
have a default FW, so we're sure there is support for FW loading and the
kernel isn't going to explode in an undefined path.

v2: simplify comment (John),
    rebase on s/guc_submission_enabled/uc_enabled

Signed-off-by: Daniele Ceraolo Spurio 
Cc: John Harrison 
Cc: Matthew Brost 
Reviewed-by: John Harrison 
Signed-off-by: Rodrigo Vivi

drm/xe/pmu: Enable PMU interface

2023-12-21T16:41:13+00:00

There are a set of engine group busyness counters provided by HW which are
perfect fit to be exposed via PMU perf events.

BSPEC: 46559, 46560, 46722, 46729, 52071, 71028

events can be listed using:
perf list
  xe_0000_03_00.0/any-engine-group-busy-gt0/         [Kernel PMU event]
  xe_0000_03_00.0/copy-group-busy-gt0/               [Kernel PMU event]
  xe_0000_03_00.0/interrupts/                        [Kernel PMU event]
  xe_0000_03_00.0/media-group-busy-gt0/              [Kernel PMU event]
  xe_0000_03_00.0/render-group-busy-gt0/             [Kernel PMU event]

and can be read using:

perf stat -e "xe_0000_8c_00.0/render-group-busy-gt0/" -I 1000
           time             counts unit events
     1.001139062                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     2.003294678                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     3.005199582                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     4.007076497                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     5.008553068                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     6.010531563              43520 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     7.012468029              44800 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     8.013463515                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     9.015300183                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
    10.017233010                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
    10.971934120                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/

The pmu base implementation is taken from i915.

v2:
Store last known value when device is awake return that while the GT is
suspended and then update the driver copy when read during awake.

v3:
1. drop init_samples, as storing counters before going to suspend should
be sufficient.
2. ported the "drm/i915/pmu: Make PMU sample array two-dimensional" and
dropped helpers to store and read samples.
3. use xe_device_mem_access_get_if_ongoing to check if device is active
before reading the OA registers.
4. dropped format attr as no longer needed
5. introduce xe_pmu_suspend to call engine_group_busyness_store
6. few other nits.

v4: minor nits.

v5: take forcewake when accessing the OAG registers

v6:
1. drop engine_busyness_sample_type
2. update UAPI documentation

v7:
1. update UAPI documentation
2. drop MEDIA_GT specific change for media busyness counter.

Co-developed-by: Tvrtko Ursulin 
Co-developed-by: Bommu Krishnaiah 
Signed-off-by: Aravind Iddamsetty 
Reviewed-by: Ashutosh Dixit 
Signed-off-by: Rodrigo Vivi

drm/xe: Invert guc vs execlists parameters and info.

2023-12-21T16:37:54+00:00

The module parameter should reflect the name of the optional,
experimental and unsafe option, rather than the default one.

Signed-off-by: Rodrigo Vivi 
Reviewed-by: José Roberto de Souza

drm/xe: Call exit functions when xe_register_pci_driver() fails

2023-12-19T23:33:51+00:00

Move xe_register_pci_driver() and xe_unregister_pci_driver() to
init_funcs to make sure that exit functions are also called when
xe_register_pci_driver() fails.

Note that this also allows adding init functions to be run after
xe_register_pci_driver().

v2:
 - Move functions to init_funcs instead of having a special case for
   xe_register_pci_driver(). (Jani)

Cc: Jani Nikula 
Reviewed-by: Matt Atwood 
Signed-off-by: Gustavo Sousa 
Signed-off-by: Rodrigo Vivi

drm/xe: Get rid of MAKE_INIT_EXIT_FUNCS

2023-12-19T23:33:51+00:00

There is not much of a benefit from using that macro as of now and it
hurts grepability or other ways of cross-referencing.

Cc: Jani Nikula 
Reviewed-by: Matt Atwood 
Signed-off-by: Gustavo Sousa 
Signed-off-by: Rodrigo Vivi

drm/xe: s/lmem/vram/

2023-12-19T23:29:45+00:00

This seems to be the preferred nomenclature in xe. Currently we are
intermixing vram and lmem, which is confusing.

v2 (Gwan-gyeong Mun & Lucas):
  - Rather apply to the entire driver

Signed-off-by: Matthew Auld 
Cc: Maarten Lankhorst 
Cc: Gwan-gyeong Mun 
Cc: Lucas De Marchi 
Acked-by: Lucas De Marchi 
Reviewed-by: Rodrigo Vivi 
Signed-off-by: Rodrigo Vivi