linux.git/drivers/gpu/drm/omapdrm/omap_fbdev.c, branch v4.18

drm/omap: Init fbdev emulation only when we have displays

2018-03-01T07:18:18+00:00

Do not try to init the fbdev if either num_crtcs or num_connectors is 0.
In this case we do not have display so the fbdev init would fail anyways.

Signed-off-by: Peter Ujfalusi 
Signed-off-by: Tomi Valkeinen 
Reviewed-by: Laurent Pinchart

drm/omap: cleanup fbdev init/free

2018-03-01T07:18:18+00:00

omap_fbdev_init() and omap_fbdev_free() use priv->fbdev directly.
However, omap_fbdev_init() returns the fbdev, and omap_drv.c also
assigns the return value to priv->fbdev. This is slightly confusing.

Clean this up by removing the omap_fbdev_init() return value, as we
don't care whether fbdev init succeeded or not. Also change omap_drv.c
to call omap_fbdev_free() always, and omap_fbdev_free() does the check
if fbdev was initialized.

While at it, rename omap_fbdev_free() to omap_fbdev_fini() to better
match the "init" counterpart.

Signed-off-by: Tomi Valkeinen 
Reviewed-by: Laurent Pinchart

drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called

2018-03-01T07:18:18+00:00

If we have no crtcs/connectors, fbdev init goes fine, but
omap_fbdev_create() is never called. This means that omap_fbdev->bo is
NULL and omap_fbdev_free() crashes.

Add a check to omap_fbdev_free() to handle the NULL case.

Signed-off-by: Tomi Valkeinen 
Reviewed-by: Laurent Pinchart

drm/omap: fbdev: avoid double initializer entry

2018-03-01T07:18:18+00:00

Fix sparse warning:

drivers/gpu/drm/omapdrm/omap_fbdev.c:83:9: warning: Initializer entry defined twice
drivers/gpu/drm/omapdrm/omap_fbdev.c:91:10:   also defined here

Signed-off-by: Tomi Valkeinen

drm/omap: fbdev: use 'screen_buffer' field

2018-03-01T07:18:18+00:00

Fix sparse warning:

drivers/gpu/drm/omapdrm/omap_fbdev.c:191:26: warning: incorrect type in assignment (different address spaces)
drivers/gpu/drm/omapdrm/omap_fbdev.c:191:26:    expected char [noderef] *screen_base
drivers/gpu/drm/omapdrm/omap_fbdev.c:191:26:    got void *

Signed-off-by: Tomi Valkeinen

drm: omapdrm: Remove filename from header and fix copyright tag

2017-12-19T09:21:32+00:00

Having the filename in the header serves little purpose and is
often wrong after renames as it is here in several places, just
drop it from all omapdrm files.

While we are here unify the copyright tags to the TI recommended style.

Signed-off-by: Andrew F. Davis

drm/omap: drop incorrect comment

2017-12-19T08:32:00+00:00

The wrappers have been removed in commit 5a35876e2830
(drm: omapdrm: Remove manual update display support)
and will not be reintroduced, since the normal sys
functions properly call the dirty callback.

Signed-off-by: Sebastian Reichel 
Acked-by: Pavel Machek 
Signed-off-by: Tomi Valkeinen

drm/: Drop fbdev info flags

2017-07-26T11:22:40+00:00

- FBINFO_CAN_FORCE_OUTPUT has been a lie ever since we nerfed&removed
  the entire panic handling code in our fbdev emulation. We might
  restore kms panic output, but not through the bazillion of legacy
  code layers called fbdev/fbcon, there's just no way to make that
  work safely.

- With the module check change FBINFO_DEFAULT is always 0, so can be
  removed too.

That removes another change to cargo-cult stuff in kms drivers, yay!

Reviewed-by: Sean Paul 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20170706125735.28299-5-daniel.vetter@ffwll.ch
Signed-off-by: Daniel Vetter

drm: omapdrm: Rename omap_gem_(get|put)_paddr() to omap_gem_(un)pin()

2017-06-02T07:57:05+00:00

The reflects the purpose of the function better.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Tomi Valkeinen

drm: omapdrm: Rename occurrences of paddr to dma_addr

2017-06-02T07:57:05+00:00

The fields, variables and functions deal with DMA addresses, name them
accordingly. The omap_gem_get_paddr() and omap_gem_put_paddr() will be
addressed differently separately.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Tomi Valkeinen