linux.git/drivers/gpu/drm/etnaviv, branch v4.18

drm/etnaviv: bring back progress check in job timeout handler

2018-07-05T12:16:20+00:00

When the hangcheck handler was replaced by the DRM scheduler timeout
handling we dropped the forward progress check, as this might allow
clients to hog the GPU for a long time with a big job.

It turns out that even reasonably well behaved clients like the
Armada Xorg driver occasionally trip over the 500ms timeout. Bring
back the forward progress check to get rid of the userspace regression.

We would still like to fix userspace to submit smaller batches
if possible, but that is for another day.

Cc: 
Fixes: 6d7a20c07760 (drm/etnaviv: replace hangcheck with scheduler timeout)
Reported-by: Russell King 
Signed-off-by: Lucas Stach 
Reviewed-by: Eric Anholt

drm/etnaviv: Fix driver unregistering

2018-06-27T13:26:52+00:00

Russell King reported:

"When removing and reloading the etnaviv module, the following splat
occurs:

sysfs: cannot create duplicate filename '/devices/platform/etnaviv'
CPU: 0 PID: 1471 Comm: modprobe Not tainted 4.17.0+ #1608
Hardware name: Marvell Dove (Cubox)
Backtrace:
[] (dump_backtrace) from [] (show_stack+0x18/0x1c)
 r6:ef033e38 r5:ee07b340 r4:edb9d000 r3:00000000
[] (show_stack) from [] (dump_stack+0x20/0x28)
[] (dump_stack) from [] (sysfs_warn_dup+0x5c/0x70)
[] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x90/0x98)
..."

Commit 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem
DT node") introduced DRM registration via
platform_device_register_simple(), but missed to call
platform_device_unregister() inside etnaviv_exit().

Fix the problem by calling platform_device_unregister() inside
etnaviv_exit(). While at it, also rearrange the function calls
in the exit path to make them happen in the opposite order of
registration.

Tested on a imx6-sabresd board.

Cc: 
Fixes: 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node")
Reported-by: Russell King 
Signed-off-by: Fabio Estevam 
Reviewed-by: Philipp Zabel 
Signed-off-by: Lucas Stach

drm/etnaviv: Check for platform_device_register_simple() failure

2018-06-27T13:26:39+00:00

platform_device_register_simple() may fail, so we should better
check its return value and propagate it in the case of error.

Cc: 
Fixes: 246774d17fc0 ("drm/etnaviv: remove the need for a gpu-subsystem DT node")
Signed-off-by: Fabio Estevam 
Reviewed-by: Philipp Zabel 
Signed-off-by: Lucas Stach

Merge branch 'etnaviv/next' of https://git.pengutronix.de/git/lst/linux into drm-next

2018-05-22T00:43:27+00:00

So what we have for this cycle is a bit of spring cleaning with removal
of unused register logging code and getting rid of the license text in
favor of SPDX, a few smaller MMU handling improvements and a timeout
calculation change, fixing premature fence wait timeouts after 50 days
of uptime.

Signed-off-by: Dave Airlie 
Link: https://patchwork.freedesktop.org/patch/msgid/1526652437.28565.2.camel@pengutronix.de

drm/etnaviv: replace license text with SPDX tags

2018-05-18T13:27:56+00:00

This replaces the repetitive GPL-2.0 license text in code and header files
with the SPDX tags. Generated hardware headers aren't changed, as any changes
there need to be done in the upstream rnndb repository.

Signed-off-by: Lucas Stach 
Reviewed-by: Christian Gmeiner

drm/etnaviv: mmuv2: support 40 bit phys address

2018-05-18T13:27:56+00:00

MMUv2 supports up to 40 bits of physical address by folding the upper
8 bits into bits [4:11] of the PTE.

Signed-off-by: Lucas Stach

drm/etnaviv: mmuv2: allocate 2nd level page tables on demand

2018-05-18T13:27:56+00:00

With etnaviv not being tied into the IOMMU framework anymore, the MMU
functions will only be called under sleeping locks. Thus we are able
to allocate the memory for the 2nd level page tables on demand without
having to deal with memory allocation in atomic context.

This speeds up driver intitialization on MMUv2 GPU cores, as we don't
need to preallocate all the page table memory and also reduces memory
consumption for most workloads, as most of them won't use the full
GPU virtual address space.

Signed-off-by: Lucas Stach 
Reviewed-by: Philipp Zabel

drm/etnaviv: switch MMU page tables to writecombine memory

2018-05-18T13:27:56+00:00

We are likely to write multiple page entries at once and already ensure
proper write buffer flushing before GPU submit, so this improves CPU
time usage in the submit path without any downsides.

Signed-off-by: Lucas Stach 
Reviewed-by: Philipp Zabel

drm/etnaviv: remove register logging

2018-05-18T13:27:56+00:00

I'm not aware of any case where tracing GPU register manipulation at the
kernel level would have been useful. It only adds more indirections and
adds to the code size.

Signed-off-by: Lucas Stach 
Reviewed-by: Christian Gmeiner

drm/etnaviv: remove cycling through MMU address space

2018-05-18T13:27:56+00:00

This was useful on MMUv1 GPUs, which don't generate proper faults,
when the GPU write caches weren't fully understood and not properly
handled by the kernel driver. As this has been fixed for quite some
time, the cycling though the MMU address space needlessly spreads
out the MMU mappings.

Signed-off-by: Lucas Stach