linux.git/drivers/gpu/drm/amd, branch v4.9-rc7

drm/amdgpu: fix power state when port pm is unavailable

2016-11-23T18:57:14+00:00

When PCIe port PM is not enabled (system BIOS is pre-2015 or the
pcie_port_pm=off parameter is set), legacy ATPX PM should still be
marked as supported. Otherwise the GPU can fail to power on after
runtime suspend. This affected a Dell Inspiron 5548.

Ideally the BIOS date in the PCI core is lowered to 2013 (the first year
where hybrid graphics platforms using power resources was introduced),
but that seems more risky at this point and would not solve the
pcie_port_pm=off issue.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98505
Reported-and-tested-by: Nayan Deshmukh 
Signed-off-by: Peter Wu 
Signed-off-by: Alex Deucher 
Cc:  # 4.8+
Acked-by: Christian König 
Reviewed-by: Alex Deucher

drm/amd/powerplay: avoid out of bounds access on array ps.

2016-11-16T19:26:17+00:00

check array index first and then visit the array.

Signed-off-by: Rex Zhu 
Reviewed-by: Christian König 
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher

drm/amdgpu:fix vpost_needed routine

2016-11-15T19:06:07+00:00

1,cleanup description/comments
2,for FIJI & passthrough, force post when smc fw version below 22.15
3,for other cases, follow regular rules

Signed-off-by: Monk Liu 
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher

drm/amdgpu/powerplay: drop a redundant NULL check

2016-11-15T19:05:52+00:00

Left over from an earlier rev of the patch.

Acked-by: Colin Ian King 
Cc: Dan Carpenter 
Cc: Colin King 
Signed-off-by: Alex Deucher

drm/amdgpu: Attach exclusive fence to prime exported bo's. (v5)

2016-11-11T15:20:04+00:00

External clients which import our bo's wait only
for exclusive dmabuf-fences, not on shared ones,
ditto for bo's which we import from external
providers and write to.

Therefore attach exclusive fences on prime shared buffers
if our exported buffer gets imported by an external
client, or if we import a buffer from an external
exporter.

See discussion in thread:
https://lists.freedesktop.org/archives/dri-devel/2016-October/122370.html

Prime export tested on Intel iGPU + AMD Tonga dGPU as
DRI3/Present Prime render offload, and with the Tonga
standalone as primary gpu.

v2: Add a wait for all shared fences before prime export,
    as suggested by Christian Koenig.

v3: - Mark buffer prime_exported in amdgpu_gem_prime_pin,
    so we only use the exclusive fence when exporting a
    bo to external clients like a separate iGPU, but not
    when exporting/importing from/to ourselves as part of
    regular DRI3 fd passing.

    - Propagate failure of reservation_object_wait_rcu back
    to caller.

v4: - Switch to a prime_shared_count counter instead of a
      flag, which gets in/decremented on prime_pin/unpin, so
      we can switch back to shared fences if all clients
      detach from our exported bo.

    - Also switch to exclusive fence for prime imported bo's.

v5: - Drop lret, instead use int ret -> long ret, as proposed
      by Christian.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472
Tested-by: Mike Lothian  (v1)
Signed-off-by: Mario Kleiner 
Reviewed-by: Christian König .
Cc: Christian König 
Cc: Michel Dänzer 
Signed-off-by: Alex Deucher 
Cc: stable@vger.kernel.org

drm/amd/powerplay: implement get_clock_by_type for iceland.

2016-11-10T19:04:27+00:00

iceland use pptable v0.

bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=185681
https://bugs.freedesktop.org/show_bug.cgi?id=98357

Reviewed-by: Alex Deucher 
Signed-off-by: Rex Zhu 
Signed-off-by: Alex Deucher

drm/amd/powerplay/smu7: fix checks in smu7_get_evv_voltages (v2)

2016-11-10T16:11:40+00:00

Only check if the tables exist in relevant configs.  This
fixes a failure on V0 tables.

v2: fix version check as suggested by Rex

bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=185681
https://bugs.freedesktop.org/show_bug.cgi?id=98357

Reviewed-by: Rex Zhu 
Reviewed-by: Huang Rui 
Signed-off-by: Alex Deucher

drm/amd/powerplay: update phm_get_voltage_evv_on_sclk for iceland

2016-11-10T16:11:33+00:00

Was missing the handling for iceland.

bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=185681
https://bugs.freedesktop.org/show_bug.cgi?id=98357

Reviewed-by: Rex Zhu 
Reviewed-by: Huang Rui 
Signed-off-by: Alex Deucher

drm/amd/powerplay: propagate errors in phm_get_voltage_evv_on_sclk

2016-11-10T16:10:27+00:00

Missing for one case.

bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=185681
https://bugs.freedesktop.org/show_bug.cgi?id=98357

Reviewed-by: Rex Zhu 
Reviewed-by: Huang Rui 
Signed-off-by: Alex Deucher

drm/amd/powerplay: return false instead of -EINVAL

2016-11-08T16:43:05+00:00

Returning -EINVAL from a bool-returning function
phm_check_smc_update_required_for_display_configuration has an unexpected
effect of returning true, which is probably not what was intended.
Replace -EINVAL by false.

The only place this function is called from is
psm_adjust_power_state_dynamic in
drivers/gpu/drm/amd/powerplay/eventmgr/psm.c:106:

	if (!equal || phm_check_smc_update_required_for_display_configuration(hwmgr)) {
		phm_apply_state_adjust_rules(hwmgr, requested, pcurrent);
		phm_set_power_state(hwmgr, &pcurrent->hardware, &requested->hardware);
		hwmgr->current_ps = requested;
	}

It seems to expect a boolean value here.

This issue has been found using the following Coccinelle semantic patch
written by Peter Senna Tschudin:

@@
identifier f;
constant C;
typedef bool;
@@
bool f (...){
<+...
* return -C;
...+>
}


Reviewed-by: Alex Deucher 
Signed-off-by: Andrew Shadura 
Signed-off-by: Alex Deucher