linux.git/drivers/gpu/drm/amd/display/dc/dml, branch v5.15

drm/amd/display: Fix prefetch bandwidth calculation for DCN3.1

2021-10-20T19:17:13+00:00

[Why]
Prefetch BW calculated is lower than the DML reference because of a
porting error that's excluding cursor and row bandwidth from the
pixel data bandwidth.

[How]
Change the dml_max4 to dml_max3 and include cursor and row bandwidth
in the same calculation as the rest of the pixel data during vactive.

Reviewed-by: Dmytro Laktyushkin 
Acked-by: Agustin Gutierrez Sanchez 
Signed-off-by: Nicholas Kazlauskas 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher 
Cc: stable@vger.kernel.org

drm/amd/display: cleanup idents after a revert

2021-08-31T18:19:20+00:00

[WHY]
The change has caused high idle memory clock speed and power
consumption at some resolutions and frame rates for Navi10

[HOW]
Reverted change "drm/amd/display: Fixed Intermittent blue
screen on OLED panel"

Reviewed-by: Aric Cyr  
Acked-by: Mikita Lipski 
Signed-off-by: Angus Wang 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher

drm/amd/display: Move AllowDRAMSelfRefreshOrDRAMClockChangeInVblank to bounding box

2021-08-26T17:57:33+00:00

[Why]
This is a global parameter, not a per pipe parameter and it's useful
for experimenting with the prefetch schedule to be adjustable from
the SOC bb.

[How]
Add a parameter to the SOC bb, default is the existing policy for
all DCN. Fill it in when filling SOC bb parameters.

Revert the policy to use MinDCFClk at the same time since that's not
going to give us P-State in most cases on the spreadsheet.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1403
Signed-off-by: Nicholas Kazlauskas 
Signed-off-by: Aurabindo Pillai 
Tested-by: Daniel Wheeler 
Acked-by: Alex Deucher 
Signed-off-by: Alex Deucher

drm/amd/display: Add DC_FP helper to check FPU state

2021-08-06T01:17:59+00:00

To fully isolate FPU operations in a single place, we must avoid
situations where compilers spill FP values to registers due to FP enable
in a specific C file. Note that even if we isolate all FPU functions in
a single file and call its interface from other files, the compiler
might enable the use of FPU before we call DC_FP_START. Nevertheless, it
is the programmer's responsibility to invoke DC_FP_START/END in the
correct place. To highlight situations where developers forgot to use
the FP protection before calling the DC FPU interface functions, we
introduce a helper that checks if the function is invoked under FP
protection. If not, it will trigger a kernel warning.

Changes cince V3:
- Rebase

Changes cince V2 (Christian):
- Do not use this_cpu_* between get/put_cpu_ptr().
- In the kernel documentation, better describe restrictions.
- Make dc_assert_fp_enabled trigger the ASSERT message.

Changes since V1:
- Remove fp_enable variables
- Rename dc_is_fp_enabled to dc_assert_fp_enabled
- Replace wrong variable type

Cc: Harry Wentland 
Cc: Anson Jacob 
Cc: Christian König 
Cc: Hersen Wu 
Cc: Aric Cyr 
Cc: Jun Lei 
Cc: Dmytro Laktyushkin 
Cc: Qingqing Zhuo 
Reported-by: kernel test robot 
Signed-off-by: Rodrigo Siqueira 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher

drm/amd/display: Move specific DCN2x code that uses FPU to DML

2021-08-06T01:17:59+00:00

The display core files rely on FPU, which requires to be compiled with
special flags. Ideally, we don't want these FPU operations spread around
the DC code; nevertheless, it happens in the current source. This commit
introduces a new directory inside DML for centralizing shared DCN
functions that require FPU and have been used outside DML. For
illustrating this process of transferring FPU functions to the DML
folder, this commit moves one of the functions
dcn20_populate_dml_writeback_from_context) that require FPU access to a
single shared file. Notice that this is the first part of the work, and
it does not fix the FPU issue yet; we still need other patches for
achieving the complete FPU isolation.

Changes since V3:
- Jun: Instead of creating a new directory to keep the FPU code, let's
make the DML folder the only part that requires FPU access. Drop
fpu_operation folder.
- Christian: Fix function code style.

Changes since V2:
- Christian: Remove unnecessary wrapper.
- lkp: Add missing prototype.
- Only compile the FPU operations if the DCN option is enabled.

Change since V1:
- Update documentation and rebase.

Cc: Harry Wentland 
Cc: Anson Jacob 
Cc: Christian König 
Cc: Hersen Wu 
Cc: Aric Cyr 
Cc: Jun Lei 
Cc: Dmytro Laktyushkin 
Cc: Qingqing Zhuo 
Reported-by: kernel test robot 
Signed-off-by: Rodrigo Siqueira 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher

drm/amd/display: Fix typo in comments

2021-08-02T21:21:25+00:00

Remove the repeated word 'the' from comments

Signed-off-by: Cai Huoqing 
Signed-off-by: Alex Deucher

drm/amd/display: Guard DST_Y_PREFETCH register overflow in DCN21

2021-07-27T16:04:19+00:00

[why]
DST_Y_PREFETCH can overflow when DestinationLinesForPrefetch values are
too large due to the former being limited to 8 bits.

[how]
Set the maximum value of DestinationLinesForPrefetch to be 255 * refclk
period.

Reviewed-by: Laktyushkin Dmytro 
Acked-by: Solomon Chiu 
Signed-off-by: Victor Lu 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher

drm/amd/display: Fix comparison error in dcn21 DML

2021-07-23T14:07:58+00:00

[why]
A comparison error made it possible to not iterate through all the
specified prefetch modes.

[how]
Correct "<" to "<="

Reviewed-by: Dmytro Laktyushkin 
Reviewed-by: Yongqiang Sun 
Acked-by: Rodrigo Siqueira 
Signed-off-by: Victor Lu 
Signed-off-by: Alex Deucher

drm/amd/display: log additional register state for debug

2021-07-21T17:39:25+00:00

[Why & How]
Extend existing state collection functions to add some additional
registers useful for debug, and add state collection function for DC
hubbub

Acked-by: Rodrigo Siqueira 
Signed-off-by: Josip Pavic 
Signed-off-by: Alex Deucher

drm/amd/display: Adjust types and formatting for future development

2021-07-08T19:16:21+00:00

Type adjustments and formatting fixes.

Signed-off-by: Alvin Lee 
Reviewed-by: Dmytro Laktyushkin 
Acked-by: Rodrigo Siqueira 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher