linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c, branch v6.9

drm/amdgpu: Fix comparison in amdgpu_res_cpu_visible

2024-05-10T17:05:13+00:00

It incorrectly claimed a resource isn't CPU visible if it's located at
the very end of CPU visible VRAM.

Fixes: a6ff969fe9cb ("drm/amdgpu: fix visible VRAM handling during faults")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3343
Reviewed-by: Christian König 
Reviewed-by: Alex Deucher 
Reported-and-Tested-by: Jeremy Day 
Signed-off-by: Michel Dänzer 
Signed-off-by: Alex Deucher 
CC: stable@vger.kernel.org

drm/amdgpu: fix doorbell regression

2024-05-01T01:59:16+00:00

This patch adds a missed handling of PL domain doorbell while
handling VRAM faults.

Cc: Christian Koenig 
Cc: Alex Deucher 
Fixes: a6ff969fe9cb ("drm/amdgpu: fix visible VRAM handling during faults")
Reviewed-by: Christian Koenig 
Signed-off-by: Shashank Sharma 
Signed-off-by: Arvind Yadav 
Signed-off-by: Alex Deucher

drm/amdgpu: once more fix the call oder in amdgpu_ttm_move() v2

2024-05-01T01:39:57+00:00

This reverts drm/amdgpu: fix ftrace event amdgpu_bo_move always move
on same heap. The basic problem here is that after the move the old
location is simply not available any more.

Some fixes were suggested, but essentially we should call the move
notification before actually moving things because only this way we have
the correct order for DMA-buf and VM move notifications as well.

Also rework the statistic handling so that we don't update the eviction
counter before the move.

v2: add missing NULL check

Signed-off-by: Christian König 
Fixes: 94aeb4117343 ("drm/amdgpu: fix ftrace event amdgpu_bo_move always move on same heap")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3171
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher 
CC: stable@vger.kernel.org

drm/amdgpu: fix visible VRAM handling during faults

2024-04-17T15:50:43+00:00

When we removed the hacky start code check we actually didn't took into
account that *all* VRAM pages needs to be CPU accessible.

Clean up the code and unify the handling into a single helper which
checks if the whole resource is CPU accessible.

The only place where a partial check would make sense is during
eviction, but that is neglitible.

Signed-off-by: Christian König 
Fixes: aed01a68047b ("drm/amdgpu: Remove TTM resource->start visible VRAM condition v2")
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher 
CC: stable@vger.kernel.org

drm/amdgpu: remove invalid resource->start check v2

2024-04-17T15:02:57+00:00

The majority of those where removed in the commit aed01a68047b
("drm/amdgpu: Remove TTM resource->start visible VRAM condition v2")

But this one was missed because it's working on the resource and not the
BO. Since we also no longer use a fake start address for visible BOs
this will now trigger invalid mapping errors.

v2: also remove the unused variable

Signed-off-by: Christian König 
Fixes: aed01a68047b ("drm/amdgpu: Remove TTM resource->start visible VRAM condition v2")
CC: stable@vger.kernel.org
Acked-by: Pierre-Eric Pelloux-Prayer 
Signed-off-by: Alex Deucher

drm/amdgpu: amdgpu_ttm_gart_bind set gtt bound flag

2024-03-20T17:12:57+00:00

Otherwise after the GTT bo is released, the GTT and gart space is freed
but amdgpu_ttm_backend_unbind will not clear the gart page table entry
and leave valid mapping entry pointing to the stale system page. Then
if GPU access the gart address mistakely, it will read undefined value
instead page fault, harder to debug and reproduce the real issue.

Cc: stable@vger.kernel.org
Signed-off-by: Philip Yang 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher

Merge drm/drm-next into drm-misc-next

2024-01-29T13:20:23+00:00

Kickstart 6.9 development cycle.

Signed-off-by: Maxime Ripard

drm/ttm: replace busy placement with flags v6

2024-01-25T08:59:44+00:00

Instead of a list of separate busy placement add flags which indicate
that a placement should only be used when there is room or if we need to
evict.

v2: add missing TTM_PL_FLAG_IDLE for i915
v3: fix auto build test ERROR on drm-tip/drm-tip
v4: fix some typos pointed out by checkpatch
v5: cleanup some rebase problems with VMWGFX
v6: implement some missing VMWGFX functionality pointed out by Zack,
    rename the flags as suggested by Michel, rebase on drm-tip and
    adjust XE as well

Signed-off-by: Christian König 
Signed-off-by: Somalapuram Amaranath 
Reviewed-by: Zack Rusin 
Reviewed-by: Thomas Zimmermann 
Reviewed-by: Thomas Hellström 
Link: https://patchwork.freedesktop.org/patch/msgid/20240112125158.2748-4-christian.koenig@amd.com

drm/amdgpu: fix ftrace event amdgpu_bo_move always move on same heap

2023-12-14T20:25:48+00:00

Issue: during evict or validate happened on amdgpu_bo, the 'from' and
'to' is always same in ftrace event of amdgpu_bo_move

where calling the 'trace_amdgpu_bo_move', the comment says move_notify
is called before move happens, but actually it is called after move
happens, here the new_mem is same as bo->resource

Fix: move trace_amdgpu_bo_move from move_notify to amdgpu_bo_move

Signed-off-by: Wang, Beyond 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher

drm/amdgpu: fix AGP addressing when GART is not at 0

2023-11-29T21:49:22+00:00

This worked by luck if the GART aperture ended up at 0.  When
we ended up moving GART on some chips, the GART aperture ended
up offsetting the AGP address since the resource->start is
a GART offset, not an MC address.  Fix this by moving the AGP
address setup into amdgpu_bo_gpu_offset_no_check().

v2: check mem_type before checking agp
v3: check if the ttm bo has a ttm_tt allocated yet

Fixes: 67318cb84341 ("drm/amdgpu/gmc11: set gart placement GC11")
Tested-by: Mario Limonciello 
Reported-by: Jesse Zhang 
Reported-by: Yifan Zhang 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher 
Cc: christian.koenig@amd.com
Cc: mario.limonciello@amd.com