linux.git/drivers/gpio, branch v6.2-rc8

gpio: ep93xx: remove unused variable

2023-01-27T13:05:38+00:00

This one was left behind by a previous cleanup patch:

drivers/gpio/gpio-ep93xx.c: In function 'ep93xx_gpio_add_bank':
drivers/gpio/gpio-ep93xx.c:366:34: error: unused variable 'ic' [-Werror=unused-variable]

Fixes: 216f37366e86 ("gpio: ep93xx: Make irqchip immutable")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Bartosz Golaszewski

gpio: ep93xx: Make irqchip immutable

2023-01-25T12:41:54+00:00

This turns the Cirrus ep93xx gpio irqchip immutable.

Preserve per-chip labels by adding an ->irq_print_chip() callback.

Signed-off-by: Nikita Shubin 
Signed-off-by: Bartosz Golaszewski

gpio: ep93xx: Fix port F hwirq numbers in handler

2023-01-25T12:41:37+00:00

Fix wrong translation of irq numbers in port F handler, as ep93xx hwirqs
increased by 1, we should simply decrease them by 1 in translation.

Fixes: 482c27273f52 ("ARM: ep93xx: renumber interrupts")
Signed-off-by: Nikita Shubin 
Acked-by: Arnd Bergmann 
Signed-off-by: Bartosz Golaszewski

gpio: mxc: Unlock on error path in mxc_flip_edge()

2023-01-25T12:33:29+00:00

We recently added locking to this function but one error path was
over looked.  Drop the lock before returning.

Fixes: e5464277625c ("gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock")
Signed-off-by: Dan Carpenter 
Acked-by: Marek Vasut 
Signed-off-by: Bartosz Golaszewski

gpiolib-acpi: Don't set GPIOs for wakeup in S3 mode

2023-01-23T15:02:13+00:00

commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
adjusted the policy to enable wakeup by default if the ACPI tables
indicated that a device was wake capable.

It was reported however that this broke suspend on at least two System76
systems in S3 mode and two Lenovo Gen2a systems, but only with S3.
When the machines are set to s2idle, wakeup behaves properly.

Configuring the GPIOs for wakeup with S3 doesn't work properly, so only
set it when the system supports low power idle.

Fixes: 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
Fixes: b38f2d5d9615c ("i2c: acpi: Use ACPI wake capability bit to set wake_irq")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2357
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2162013
Reported-by: Nathan Smythe 
Tested-by: Nathan Smythe 
Suggested-by: Raul Rangel 
Signed-off-by: Mario Limonciello 
Acked-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xRU

2023-01-18T14:29:16+00:00

commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
changed the policy such that I2C touchpads may be able to wake up the
system by default if the system is configured as such.

However on Clevo NL5xRU there is a mistake in the ACPI tables that the
TP_ATTN# signal connected to GPIO 9 is configured as ActiveLow and level
triggered but connected to a pull up. As soon as the system suspends the
touchpad loses power and then the system wakes up.

To avoid this problem, introduce a quirk for this model that will prevent
the wakeup capability for being set for GPIO 9.

Fixes: 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
Reported-by: Werner Sembach 
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1720627
Co-developed-by: Werner Sembach 
Signed-off-by: Werner Sembach 
Signed-off-by: Mario Limonciello 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: acpi: Allow ignoring wake capability on pins that aren't in _AEI

2023-01-18T14:29:16+00:00

Using the `ignore_wake` quirk or module parameter doesn't work for any pin
that has been specified in the _CRS instead of _AEI.

Extend the `acpi_gpio_irq_is_wake` check to cover both places.

Suggested-by: Raul Rangel 
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1722335
Signed-off-by: Mario Limonciello 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode

2023-01-16T09:55:05+00:00

Always configure GPIO pins which are used as interrupt source as INPUTs.
In case the default pin configuration is OUTPUT, or the prior stage does
configure the pins as OUTPUT, then Linux will not reconfigure the pin as
INPUT and no interrupts are received.

Always configure the interrupt source GPIO pin as input to fix the above case.

Reviewed-by: Linus Walleij 
Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform")
Signed-off-by: Marek Vasut 
Signed-off-by: Bartosz Golaszewski

gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock

2023-01-16T09:54:45+00:00

The driver currently performs register read-modify-write without locking
in its irqchip part, this could lead to a race condition when configuring
interrupt mode setting. Add the missing bgpio spinlock lock/unlock around
the register read-modify-write.

Reviewed-by: Linus Walleij 
Reviewed-by: Marc Zyngier 
Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform")
Signed-off-by: Marek Vasut 
Signed-off-by: Bartosz Golaszewski

gpio: sifive: Fix refcount leak in sifive_gpio_probe

2023-01-02T12:01:14+00:00

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Bartosz Golaszewski