linux.git/drivers/gpio, branch v6.2-rc5

gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xRU

2023-01-18T14:29:16+00:00

commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
changed the policy such that I2C touchpads may be able to wake up the
system by default if the system is configured as such.

However on Clevo NL5xRU there is a mistake in the ACPI tables that the
TP_ATTN# signal connected to GPIO 9 is configured as ActiveLow and level
triggered but connected to a pull up. As soon as the system suspends the
touchpad loses power and then the system wakes up.

To avoid this problem, introduce a quirk for this model that will prevent
the wakeup capability for being set for GPIO 9.

Fixes: 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
Reported-by: Werner Sembach 
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1720627
Co-developed-by: Werner Sembach 
Signed-off-by: Werner Sembach 
Signed-off-by: Mario Limonciello 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: acpi: Allow ignoring wake capability on pins that aren't in _AEI

2023-01-18T14:29:16+00:00

Using the `ignore_wake` quirk or module parameter doesn't work for any pin
that has been specified in the _CRS instead of _AEI.

Extend the `acpi_gpio_irq_is_wake` check to cover both places.

Suggested-by: Raul Rangel 
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1722335
Signed-off-by: Mario Limonciello 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode

2023-01-16T09:55:05+00:00

Always configure GPIO pins which are used as interrupt source as INPUTs.
In case the default pin configuration is OUTPUT, or the prior stage does
configure the pins as OUTPUT, then Linux will not reconfigure the pin as
INPUT and no interrupts are received.

Always configure the interrupt source GPIO pin as input to fix the above case.

Reviewed-by: Linus Walleij 
Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform")
Signed-off-by: Marek Vasut 
Signed-off-by: Bartosz Golaszewski

gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock

2023-01-16T09:54:45+00:00

The driver currently performs register read-modify-write without locking
in its irqchip part, this could lead to a race condition when configuring
interrupt mode setting. Add the missing bgpio spinlock lock/unlock around
the register read-modify-write.

Reviewed-by: Linus Walleij 
Reviewed-by: Marc Zyngier 
Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform")
Signed-off-by: Marek Vasut 
Signed-off-by: Bartosz Golaszewski

gpio: sifive: Fix refcount leak in sifive_gpio_probe

2023-01-02T12:01:14+00:00

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Bartosz Golaszewski

gpio: sprd: Make the irqchip immutable

2022-12-30T15:59:06+00:00

Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
new helper functions, and call the appropriate gpiolib functions.

Signed-off-by: Cixi Geng 
Reported-by: kernel test robot 
Reported-by: Julia Lawall 
Reviewed-by: Baolin Wang 
Signed-off-by: Bartosz Golaszewski

gpio: pmic-eic-sprd: Make the irqchip immutable

2022-12-30T15:58:58+00:00

Remove the irq_chip from pmic_eic structure,
use the various calls by defining the statically
irq_chip structure.

Signed-off-by: Cixi Geng 
Reviewed-by: Baolin Wang 
Signed-off-by: Bartosz Golaszewski

gpio: eic-sprd: Make the irqchip immutable

2022-12-30T15:57:27+00:00

Remove the irq_chip from pmic_eic structure,
use the various calls by defining the statically
irq_chip structure.

Signed-off-by: Cixi Geng 
Reviewed-by: Baolin Wang 
Signed-off-by: Bartosz Golaszewski

gpio: pca953x: avoid to use uninitialized value pinctrl

2022-12-30T12:38:33+00:00

There is a variable pinctrl declared without initializer. And then
has the case (switch operation chose the default case) to directly
use this uninitialized value, this is not a safe behavior. So here
initialize the pinctrl as 0 to avoid this issue.
This is reported by Coverity.

Fixes: 13c5d4ce8060 ("gpio: pca953x: Add support for PCAL6534")
Signed-off-by: Haibo Chen 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: Fix using uninitialized lookup-flags on ACPI platforms

2022-12-30T10:03:05+00:00

Commit 8eb1f71e7acc ("gpiolib: consolidate GPIO lookups") refactors
fwnode_get_named_gpiod() and gpiod_get_index() into a unified
gpiod_find_and_request() helper.

The old functions both initialized their local lookupflags variable to
GPIO_LOOKUP_FLAGS_DEFAULT, but the new code leaves it uninitialized.

This is a problem for at least ACPI platforms, where acpi_find_gpio()
only does a bunch of *lookupflags |= GPIO_* statements and thus relies
on the variable being initialized.

The variable not being initialized leads to:

1. Potentially the wrong flags getting used
2. The check for conflicting lookup flags in gpiod_configure_flags():
   "multiple pull-up, pull-down or pull-disable enabled, invalid config"
   sometimes triggering, making the GPIO unavailable

Restore the initialization of lookupflags to GPIO_LOOKUP_FLAGS_DEFAULT
to fix this.

Fixes: 8eb1f71e7acc ("gpiolib: consolidate GPIO lookups")
Signed-off-by: Hans de Goede 
Signed-off-by: Bartosz Golaszewski