linux.git/drivers/gpio/gpiolib-devres.c, branch v5.9

gpio: don't use same lockdep class for all devm_gpiochip_add_data users

2020-08-03T23:22:02+00:00

Commit 959bc7b22bd2 ("gpio: Automatically add lockdep keys") documents
in its commits message its intention to "create a unique class key for
each driver".

It does so by having gpiochip_add_data add in-place the definition of
two static lockdep classes for LOCKDEP use. That way, every caller of
the macro adds their gpiochip with unique lockdep classes.

There are many indirect callers of gpiochip_add_data, however, via
use of devm_gpiochip_add_data. devm_gpiochip_add_data has external
linkage and all its users will share the same lockdep classes, which
probably is not intended.

Fix this by replicating the gpio_chip_add_data statics-in-macro for
the devm_ version as well.

Fixes: 959bc7b22bd2 ("gpio: Automatically add lockdep keys")
Signed-off-by: Ahmad Fatoum 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Bartosz Golaszewski 
Link: https://lore.kernel.org/r/20200731123835.8003-1-a.fatoum@pengutronix.de
Signed-off-by: Linus Walleij

gpio: Move devres calls to devres file

2020-03-20T09:23:06+00:00

These two devres functions devm_gpiochip_[add|remove]()
were in the wrong file. They should be in gpiolib-devres.c
not gpiolib.c.

Link: https://lore.kernel.org/r/20200313081522.35143-1-linus.walleij@linaro.org
Reviewed-by: Bartosz Golaszewski 
Signed-off-by: Linus Walleij

treewide: remove redundant IS_ERR() before error code check

2020-02-04T03:05:27+00:00

'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p).
Hence, IS_ERR(p) is unneeded.

The semantic patch that generates this commit is as follows:

// 
@@
expression ptr;
constant error_code;
@@
-IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code)
+PTR_ERR(ptr) == - error_code
// 

Link: http://lkml.kernel.org/r/20200106045833.1725-1-masahiroy@kernel.org
Signed-off-by: Masahiro Yamada 
Cc: Julia Lawall 
Acked-by: Stephen Boyd  [drivers/clk/clk.c]
Acked-by: Bartosz Golaszewski  [GPIO]
Acked-by: Wolfram Sang  [drivers/i2c]
Acked-by: Rafael J. Wysocki  [acpi/scan.c]
Acked-by: Rob Herring 
Cc: Eric Biggers 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

gpiolib: introduce fwnode_gpiod_get_index()

2019-10-03T10:04:28+00:00

This introduces fwnode_gpiod_get_index() that iterates through common gpio
suffixes when trying to locate a GPIO within a given firmware node.

We also switch devm_fwnode_gpiod_get_index() to call
fwnode_gpiod_get_index() instead of iterating through GPIO suffixes on
its own.

Reviewed-by: Andy Shevchenko 
Signed-off-by: Dmitry Torokhov 
Link: https://lore.kernel.org/r/20190913032240.50333-3-dmitry.torokhov@gmail.com
Reviewed-by: Mika Westerberg 
Signed-off-by: Linus Walleij

gpiolib: introduce devm_fwnode_gpiod_get_index()

2019-10-03T10:03:58+00:00

devm_fwnode_get_index_gpiod_from_child() is too long, besides the fwnode
in question does not have to be a child of device node. Let's rename it
to devm_fwnode_gpiod_get_index() and keep the old name for compatibility
for now.

Also let's add a devm_fwnode_gpiod_get() wrapper as majority of the
callers need a single GPIO.

Reviewed-by: Andy Shevchenko 
Signed-off-by: Dmitry Torokhov 
Reviewed-by: Mika Westerberg 
Link: https://lore.kernel.org/r/20190913032240.50333-2-dmitry.torokhov@gmail.com
Signed-off-by: Linus Walleij

gpio: devres: Switch to EXPORT_SYMBOL_GPL()

2019-09-11T13:47:39+00:00

Change all exported symbols for managed GPIO functions from
EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL(), like is used for their
non-managed counterparts.

Signed-off-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/r/20190906084539.21838-5-geert+renesas@glider.be
Signed-off-by: Linus Walleij

gpio: Add devm_gpiod_unhinge()

2018-12-11T01:04:23+00:00

This adds a function named devm_gpiod_unhinge() that removes
the resource management from a GPIO descriptor.

I am not sure if this is the best anglosaxon name for the
function, no other managed resources have an equivalent
currently, but I chose "unhinge" as the closest intuitive
thing I could imagine that fits Rusty Russell's API design
criterions "the obvious use is the correct one" and
"the name tells you how to use it".

The idea came out of a remark from Mark Brown that it should
be possible to handle over management of a resource from
devres to the regulator core, and indeed we can do that.

Signed-off-by: Linus Walleij 
Reviewed-by: Marek Szyprowski 
Tested-by: Marek Szyprowski 
Reviewed-by: Charles Keepax 
Signed-off-by: Mark Brown

gpio: devres: Handle nonexclusive GPIOs

2018-12-11T01:04:17+00:00

When we get a nonexeclusive GPIO descriptor using managed
resources, we should only add it to the list of managed
resources once: on the first user. Augment the
devm_gpiod_get_index() and devm_gpiod_get_from_of_node()
calls to account for this by checking if the descriptor
is already resource managed before we proceed to allocate
a new resource management struct.

Fixes: b0ce7b29bfcd ("regulator/gpio: Allow nonexclusive GPIO access")
Reported-by: Marek Szyprowski 
Signed-off-by: Linus Walleij 
Reviewed-by: Marek Szyprowski 
Tested-by: Marek Szyprowski 
Reviewed-by: Charles Keepax 
Signed-off-by: Mark Brown

gpio: Rename devres implementation file

2018-09-25T07:11:50+00:00

All the other core files are named "gpiolib-" so
let's rename the devres as well so we have some logical
namespacing here.

Signed-off-by: Linus Walleij