linux.git/drivers/gpio/gpio-eic-sprd.c, branch v6.8

gpio: eic-sprd: Clear interrupt after set the interrupt type

2024-01-22T10:38:08+00:00

The raw interrupt status of eic maybe set before the interrupt is enabled,
since the eic interrupt has a latch function, which would trigger the
interrupt event once enabled it from user side. To solve this problem,
interrupts generated before setting the interrupt trigger type are ignored.

Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Acked-by: Chunyan Zhang 
Signed-off-by: Wenhua Lin 
Signed-off-by: Bartosz Golaszewski

gpio: eic-sprd: use a helper variable for &pdev->dev

2023-09-13T12:13:32+00:00

Instead of dereferencing pdev everywhere, just store the address of the
underlying struct device in a local variable.

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Baolin Wang

gpio: eic-sprd: unregister from the irq notifier on remove()

2023-09-13T12:13:06+00:00

This is a tristate module, it can be unloaded. We need to cleanup properly
and unregister from the interrupt notifier on driver detach.

Fixes: b32415652a4d ("gpio: eic-sprd: use atomic notifiers to notify all chips about irqs")
Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Baolin Wang

gpio: eic-sprd: use atomic notifiers to notify all chips about irqs

2023-09-11T09:17:06+00:00

Calling gpiochip_find() from interrupt handler in this driver is an
abuse of the GPIO API. It only happens to work because nobody added a
might_sleep() to it and the lock used by GPIOLIB is a spinlock.

Both will soon be changed as we're limiting both the number of
interfaces allowed to be called from atomic context as well as making
struct gpio_chip private to the GPIO code that owns it. We'll also
switch to protecting the global GPIO device list with a mutex as there
is no reason to allow changes to it from interrupt handlers.

Instead of iterating over all SPRD chips and looking up each
corresponding GPIO chip, let's make each SPRD GPIO controller register
with a notifier chain. The chain will be called at interrupt so that
every chip that already probed will be notified. The rest of the
interrupt handling remains the same. This should result in faster code as
we're avoiding iterating over the list of all GPIO devices.

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Chunyan Zhang 
Tested-by: Wenhua Lin

gpio: eic-sprd: remove unneeded platform_set_drvdata() call

2023-07-29T14:07:04+00:00

The platform_set_drvdata() call was never used, ever since the driver was
originally added.
It looks like this copy+paste left-over. Possibly the author copied from a
driver that had this line, but also had a remove hook.

Reviewed-by: Alexandru Ardelean 
Signed-off-by: Andrei Coardos 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Baolin Wang 
Signed-off-by: Bartosz Golaszewski

gpio: Explicitly include correct DT includes

2023-07-19T11:24:01+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Andy Shevchenko 
Acked-by: Romain Perier 
Signed-off-by: Bartosz Golaszewski

gpio: eic-sprd: Make the irqchip immutable

2022-12-30T15:57:27+00:00

Remove the irq_chip from pmic_eic structure,
use the various calls by defining the statically
irq_chip structure.

Signed-off-by: Cixi Geng 
Reviewed-by: Baolin Wang 
Signed-off-by: Bartosz Golaszewski

gpio: Get rid of duplicate of_node assignment in the drivers

2021-12-17T16:39:35+00:00

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove these assignment all at once.

For the details one may look into the of_gpio_dev_init() implementation.

While at it, remove duplicate parent device assignment where it is the case.

Signed-off-by: Andy Shevchenko 
Reviewed-By: Matti Vaittinen 
Signed-off-by: Bartosz Golaszewski

gpio: eic-sprd: break loop when getting NULL device resource

2020-12-09T08:41:49+00:00

EIC controller have unfixed numbers of banks on different Spreadtrum SoCs,
and each bank has its own base address, the loop of getting there base
address in driver should break if the resource gotten via
platform_get_resource() is NULL already. The later ones would be all NULL
even if the loop continues.

Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Signed-off-by: Chunyan Zhang 
Link: https://lore.kernel.org/r/20201209055106.840100-1-zhang.lyra@gmail.com
Signed-off-by: Linus Walleij

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva