linux.git/drivers/firmware/dmi_scan.c, branch v3.19

dmi: add support for SMBIOS 3.0 64-bit entry point

2014-11-05T08:03:19+00:00

The DMTF SMBIOS reference spec v3.0.0 defines a new 64-bit entry point,
which enables support for SMBIOS structure tables residing at a physical
offset over 4 GB. This is especially important for upcoming arm64
platforms whose system RAM resides entirely above the 4 GB boundary.

For the UEFI case, this code attempts to detect the new SMBIOS 3.0
header magic at the offset passed in the SMBIOS3_TABLE_GUID UEFI
configuration table. If this configuration table is not provided, or
if we fail to parse the header, we fall back to using the legacy
SMBIOS_TABLE_GUID configuration table. This is in line with the spec,
that allows both configuration tables to be provided, but mandates that
they must point to the same structure table, unless the version pointed
to by the 64-bit entry point is a superset of the 32-bit one.

For the non-UEFI case, the detection logic is modified to look for the
SMBIOS 3.0 header magic before it looks for the legacy header magic.

Note that this patch is based on version 3.0.0d [draft] of the
specification, which is expected not to deviate from the final version
in ways that would affect the correctness of this implementation.

Tested-by: Suravee Suthikulpanit 
Acked-by: Leif Lindholm 
Tested-by: Leif Lindholm 
Cc: Andrew Morton 
Cc: Tony Luck 
Acked-by: Matt Fleming 
Signed-off-by: Ard Biesheuvel

firmware/dmi_scan: generalize for use by other archs

2014-01-24T00:36:57+00:00

This patch makes a couple of changes to the SMBIOS/DMI scanning
code so it can be used on other archs (such as ARM and arm64):
(a) wrap the calls to ioremap()/iounmap(), this allows the use of a
    flavor of ioremap() more suitable for random unaligned access;
(b) allow the non-EFI fallback probe into hardcoded physical address
    0xF0000 to be disabled.

Signed-off-by: Ard Biesheuvel 
Acked-by: Grant Likely 
Cc: Ingo Molnar 
Cc "Luck, Tony" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi: Avoid unaligned memory access in save_mem_devices()

2013-11-03T09:40:12+00:00

Firmware is not required to maintain alignment of SMBIOS
entries, so we should take care accessing fields within these
structures. Use "get_unaligned()" to avoid problems.

[ Found on ia64 (which grumbles about unaligned access) ]

Signed-off-by: Tony Luck 
Cc: Chen Gong 
Link: http://lkml.kernel.org/r/27d82dbff5be1025bf18ab88498632d36c2fcf3c.1383331440.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar

DMI: Parse memory device (type 17) in SMBIOS

2013-10-23T17:10:12+00:00

This patch adds a new interface to decode memory device (type 17)
to help error reporting on DIMMs.

Original-author: Tony Luck 
Signed-off-by: Chen, Gong 
Acked-by: Naveen N. Rao 
Acked-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Signed-off-by: Tony Luck

firmware/dmi_scan: drop OOM messages

2013-09-11T22:58:51+00:00

As reported by Joe Perches: OOM messages generally aren't useful.
dmi_alloc is either a trivial front-end to kzalloc, and kzalloc already
does a dump_stack() when OOM, or for x86, dmi_alloc uses extend_brk
which BUGs when unsuccessful.

So we can remove all 6 such log messages in the dmi_scan driver, to
shrink the binary size (by 528 bytes on x86_64.)

Signed-off-by: Jean Delvare 
Reported-by: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: constify strings

2013-09-11T22:58:51+00:00

Add const to all DMI string pointers where this is possible.  This fixes a
checkpatch warning.

Signed-off-by: Jean Delvare 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: fix most checkpatch errors and warnings

2013-09-11T22:58:50+00:00

Fix all errors and trivial warnings reported by checkpatch for file
drivers/firmware/dmi_scan.c.

Signed-off-by: Jean Delvare 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: drop obsolete comment

2013-09-11T22:58:50+00:00

This comment predates the introduction of early_ioremap.  Since then the
missing calls to dmi_iounmap have been added by Ingo and Yinghai in
commits 0d64484f7ea1 ("x86: fix DMI ioremap leak") and 3212bff370c2
("x86: left over fix for leak of early_ioremp in dmi_scan") .  That was
over 5 years ago so it is about time to drop this now misleading
comment.

Signed-off-by: Jean Delvare 
Cc: Ingo Molnar 
Cc: Yinghai Lu 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi_scan: add comments on dmi_present() and the loop in dmi_scan_machine()

2013-07-31T21:41:02+00:00

My previous refactoring in commit 79bae42d51a5 ("dmi_scan: refactor
dmi_scan_machine(), {smbios,dmi}_present()") resulted in slightly tricky
code (though I think it's more elegant).  Explain what it's doing.

Signed-off-by: Ben Hutchings 
Cc: Zhenzhong Duan 
Cc: Jean Delvare 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi: add support for exact DMI matches in addition to substring matching

2013-07-03T23:07:42+00:00

dmi_match() considers a substring match to be a successful match.  This is
not always sufficient to distinguish between DMI data for different
systems.  Add support for exact string matching using strcmp() in addition
to the substring matching using strstr().

The specific use case in the i915 driver is to allow us to use an exact
match for D510MO, without also incorrectly matching D510MOV:

  {
	.ident = "Intel D510MO",
	.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
		DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
	},
  }

Signed-off-by: Jani Nikula 
Cc: 
Cc: Chris Wilson 
Cc: Cornel Panceac 
Acked-by: Daniel Vetter 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds