linux.git/drivers/firmware/dmi_scan.c, branch v3.13

dmi: Avoid unaligned memory access in save_mem_devices()

2013-11-03T09:40:12+00:00

Firmware is not required to maintain alignment of SMBIOS
entries, so we should take care accessing fields within these
structures. Use "get_unaligned()" to avoid problems.

[ Found on ia64 (which grumbles about unaligned access) ]

Signed-off-by: Tony Luck 
Cc: Chen Gong 
Link: http://lkml.kernel.org/r/27d82dbff5be1025bf18ab88498632d36c2fcf3c.1383331440.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar

DMI: Parse memory device (type 17) in SMBIOS

2013-10-23T17:10:12+00:00

This patch adds a new interface to decode memory device (type 17)
to help error reporting on DIMMs.

Original-author: Tony Luck 
Signed-off-by: Chen, Gong 
Acked-by: Naveen N. Rao 
Acked-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Signed-off-by: Tony Luck

firmware/dmi_scan: drop OOM messages

2013-09-11T22:58:51+00:00

As reported by Joe Perches: OOM messages generally aren't useful.
dmi_alloc is either a trivial front-end to kzalloc, and kzalloc already
does a dump_stack() when OOM, or for x86, dmi_alloc uses extend_brk
which BUGs when unsuccessful.

So we can remove all 6 such log messages in the dmi_scan driver, to
shrink the binary size (by 528 bytes on x86_64.)

Signed-off-by: Jean Delvare 
Reported-by: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: constify strings

2013-09-11T22:58:51+00:00

Add const to all DMI string pointers where this is possible.  This fixes a
checkpatch warning.

Signed-off-by: Jean Delvare 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: fix most checkpatch errors and warnings

2013-09-11T22:58:50+00:00

Fix all errors and trivial warnings reported by checkpatch for file
drivers/firmware/dmi_scan.c.

Signed-off-by: Jean Delvare 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/dmi_scan: drop obsolete comment

2013-09-11T22:58:50+00:00

This comment predates the introduction of early_ioremap.  Since then the
missing calls to dmi_iounmap have been added by Ingo and Yinghai in
commits 0d64484f7ea1 ("x86: fix DMI ioremap leak") and 3212bff370c2
("x86: left over fix for leak of early_ioremp in dmi_scan") .  That was
over 5 years ago so it is about time to drop this now misleading
comment.

Signed-off-by: Jean Delvare 
Cc: Ingo Molnar 
Cc: Yinghai Lu 
Cc: Joe Perches 
Cc: Ben Hutchings 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi_scan: add comments on dmi_present() and the loop in dmi_scan_machine()

2013-07-31T21:41:02+00:00

My previous refactoring in commit 79bae42d51a5 ("dmi_scan: refactor
dmi_scan_machine(), {smbios,dmi}_present()") resulted in slightly tricky
code (though I think it's more elegant).  Explain what it's doing.

Signed-off-by: Ben Hutchings 
Cc: Zhenzhong Duan 
Cc: Jean Delvare 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi: add support for exact DMI matches in addition to substring matching

2013-07-03T23:07:42+00:00

dmi_match() considers a substring match to be a successful match.  This is
not always sufficient to distinguish between DMI data for different
systems.  Add support for exact string matching using strcmp() in addition
to the substring matching using strstr().

The specific use case in the i915 driver is to allow us to use an exact
match for D510MO, without also incorrectly matching D510MOV:

  {
	.ident = "Intel D510MO",
	.matches = {
		DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
		DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
	},
  }

Signed-off-by: Jani Nikula 
Cc: 
Cc: Chris Wilson 
Cc: Cornel Panceac 
Acked-by: Daniel Vetter 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmi_scan: refactor dmi_scan_machine(), {smbios,dmi}_present()

2013-05-01T00:04:04+00:00

Move the calls to memcpy_fromio() up into the loop in
dmi_scan_machine(), and move the signature checks back down into
dmi_decode().  We need to check at 16-byte intervals but keep a 32-byte
buffer for an SMBIOS entry, so shift the buffer after each iteration.

Merge smbios_present() into dmi_present(), so we look for an SMBIOS
signature at the beginning of the given buffer and then for a DMI
signature at an offset of 16 bytes.

[artem.savkov@gmail.com: use proper buf type in dmi_present()]
Signed-off-by: Ben Hutchings 
Reported-by: Tim McGrath 
Tested-by: Tim Mcgrath 
Cc: Zhenzhong Duan 
Signed-off-by: Artem Savkov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dump_stack: implement arch-specific hardware description in task dumps

2013-05-01T00:04:02+00:00

x86 and ia64 can acquire extra hardware identification information
from DMI and print it along with task dumps; however, the usage isn't
consistent.

* x86 show_regs() collects vendor, product and board strings and print
  them out with PID, comm and utsname.  Some of the information is
  printed again later in the same dump.

* warn_slowpath_common() explicitly accesses the DMI board and prints
  it out with "Hardware name:" label.  This applies to both x86 and
  ia64 but is irrelevant on all other archs.

* ia64 doesn't show DMI information on other non-WARN dumps.

This patch introduces arch-specific hardware description used by
dump_stack().  It can be set by calling dump_stack_set_arch_desc()
during boot and, if exists, printed out in a separate line with
"Hardware name:" label.

dmi_set_dump_stack_arch_desc() is added which sets arch-specific
description from DMI data.  It uses dmi_ids_string[] which is set from
dmi_present() used for DMI debug message.  It is superset of the
information x86 show_regs() is using.  The function is called from x86
and ia64 boot code right after dmi_scan_machine().

This makes the explicit DMI handling in warn_slowpath_common()
unnecessary.  Removed.

show_regs() isn't yet converted to use generic debug information
printing and this patch doesn't remove the duplicate DMI handling in
x86 show_regs().  The next patch will unify show_regs() handling and
remove the duplication.

An example WARN dump follows.

 WARNING: at kernel/workqueue.c:4841 init_workqueues+0x35/0x505()
 Modules linked in:
 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.9.0-rc1-work+ #3
 Hardware name: empty empty/S3992, BIOS 080011  10/26/2007
  0000000000000009 ffff88007c861e08 ffffffff81c614dc ffff88007c861e48
  ffffffff8108f500 ffffffff82228240 0000000000000040 ffffffff8234a08e
  0000000000000000 0000000000000000 0000000000000000 ffff88007c861e58
 Call Trace:
  [] dump_stack+0x19/0x1b
  [] warn_slowpath_common+0x70/0xa0
  [] warn_slowpath_null+0x1a/0x20
  [] init_workqueues+0x35/0x505
  ...

v2: Use the same string as the debug message from dmi_present() which
    also contains BIOS information.  Move hardware name into its own
    line as warn_slowpath_common() did.  This change was suggested by
    Bjorn Helgaas.

Signed-off-by: Tejun Heo 
Cc: Bjorn Helgaas 
Cc: David S. Miller 
Cc: Fengguang Wu 
Cc: Heiko Carstens 
Cc: Jesper Nilsson 
Cc: Martin Schwidefsky 
Cc: Mike Frysinger 
Cc: Vineet Gupta 
Cc: Sam Ravnborg 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds