linux.git/drivers/firewire/fw-transaction.c, branch master

firewire: rename source files

2009-06-05T14:26:18+00:00

The source files of firewire-core, firewire-ohci, firewire-sbp2, i.e.
 "drivers/firewire/fw-*.c"
are renamed to
 "drivers/firewire/core-*.c",
 "drivers/firewire/ohci.c",
 "drivers/firewire/sbp2.c".

The old fw- prefix was redundant to the directory name.  The new core-
prefix distinguishes the files according to which driver they belong to.

This change comes a little late, but still before further firewire
drivers are added as anticipated RSN.

Signed-off-by: Stefan Richter

firewire: reorganize header files

2009-06-05T14:26:18+00:00

The three header files of firewire-core, i.e.
 "drivers/firewire/fw-device.h",
 "drivers/firewire/fw-topology.h",
 "drivers/firewire/fw-transaction.h",
are replaced by
 "drivers/firewire/core.h",
 "include/linux/firewire.h".

The latter includes everything which a firewire high-level driver (like
firewire-sbp2) needs besides linux/firewire-constants.h, while core.h
contains the rest which is needed by firewire-core itself and by low-
level drivers (card drivers) like firewire-ohci.

High-level drivers can now also reside outside of drivers/firewire
without having to add drivers/firewire to the header file search path in
makefiles.  At least the firedtv driver will be such a driver.

I also considered to spread the contents of core.h over several files,
one for each .c file where the respective implementation resides.  But
it turned out that most core .c files will end up including most of the
core .h files.  Also, the combined core.h isn't unreasonably big, and it
will lose more of its contents to linux/firewire.h anyway soon when more
firewire drivers are added.  (IP-over-1394, firedtv, and there are plans
for one or two more.)

Furthermore, fw-ohci.h is renamed to ohci.h.  The name of core.h and
ohci.h is chosen with regard to name changes of the .c files in a
follow-up change.

Signed-off-by: Stefan Richter

firewire: clean up includes

2009-06-05T14:26:17+00:00

Include required headers which were only indirectly included.
Remove unused includes and an unused constant.

Signed-off-by: Stefan Richter

firewire: core: drop unused call parameters of close_transaction

2009-03-24T19:56:51+00:00

All callers inserted NULL and 0 here.

Signed-off-by: Stefan Richter

firewire: cdev: add closure to async stream ioctl

2009-03-24T19:56:50+00:00

This changes the as yet unreleased FW_CDEV_IOC_SEND_STREAM_PACKET ioctl
to generate an fw_cdev_event_response event just like the other two
ioctls for asynchronous request transmission do.  This way, clients get
feedback on successful or unsuccessful transmission.

This also adds input validation for length, tag, channel, sy, speed.

Signed-off-by: Stefan Richter

firewire: implement asynchronous stream transmission

2009-03-24T19:56:49+00:00

Allow userspace and other firewire drivers (fw-ipv4 I'm looking at
you!) to send Asynchronous Transmit Streams as described in 7.8.3 of
release 1.1 of the 1394 Open Host Controller Interface Specification.

Signed-off-by: Jay Fenlason 
Signed-off-by: Stefan Richter  (tweaks)

firewire: core: normalize a function argument name

2009-03-24T19:56:48+00:00

It's called "payload" rather than "data" almost everywhere in
fw-transaction.c.

Signed-off-by: Stefan Richter

firewire: remove line breaks before function names

2009-03-24T19:56:40+00:00

type
    function_name(parameters);

is nice to look at but was not used consistently.

Signed-off-by: Stefan Richter

firewire: standardize a variable name

2009-03-24T19:56:39+00:00

"ret" is the new "retval".

Signed-off-by: Stefan Richter

firewire: core: remove obsolete assertions

2009-03-24T19:56:39+00:00

This code never changes.

Signed-off-by: Stefan Richter