linux.git/drivers/extcon, branch v6.6

extcon: cht_wc: add POWER_SUPPLY dependency

2023-08-05T06:42:15+00:00

The driver fails to link when CONFIG_POWER_SUPPLY is disabled:

x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_psy_get_prop':
extcon-intel-cht-wc.c:(.text+0x15ccda7): undefined reference to `power_supply_get_drvdata'
x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_pwrsrc_event':
extcon-intel-cht-wc.c:(.text+0x15cd3e9): undefined reference to `power_supply_changed'
x86_64-linux-ld: vmlinux.o: in function `cht_wc_extcon_probe':
extcon-intel-cht-wc.c:(.text+0x15cd596): undefined reference to `devm_power_supply_register'

It should be possible to change the driver to not require this at
compile time and still provide other functions, but adding a hard
Kconfig dependency does not seem to have any practical downsides
and is simpler since the option is normally enabled anyway.

Fixes: 66e31186cd2aa ("extcon: intel-cht-wc: Add support for registering a power_supply class-device")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Hans de Goede 
Signed-off-by: Chanwoo Choi

extcon: Switch i2c drivers back to use .probe()

2023-06-01T14:42:28+00:00

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Chanwoo Choi

extcon: Drop unneeded assignments

2023-05-29T14:41:29+00:00

In one case the assignment is duplicative, in the other,
it's better to move it into the loop — the user of it.

Signed-off-by: Andy Shevchenko 
Acked-by: Chanwoo Choi 
Signed-off-by: Chanwoo Choi

extcon: Use sizeof(*pointer) instead of sizeof(type)

2023-05-29T14:41:29+00:00

It is preferred to use sizeof(*pointer) instead of sizeof(type).
The type of the variable can change and one needs not change
the former (unlike the latter). No functional change intended.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Use unique number for the extcon device ID

2023-05-29T14:41:29+00:00

The use of atomic variable is still racy when we do not control which
device has been unregistered and there is a (theoretical) possibility
of the overflow that may cause a duplicate extcon device ID number
to be allocated next time a device is registered.

Replace above mentioned approach by using IDA framework.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Remove dup device name in the message and unneeded error check

2023-05-29T14:41:29+00:00

The device name is already printed with dev_err(), no need to repeat.
The device pointer itself is not supposed to be an error point, drop
that check.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Use dev_of_node(dev) instead of dev->of_node

2023-05-29T14:41:29+00:00

The dev_of_node function should be preferred.
In the result we may drop unneeded NULL check
of the pointer to the device object.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Use device_match_of_node() helper

2023-05-29T14:41:29+00:00

Instead of open coding, use device_match_of_node() helper.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Amend kernel documentation of struct extcon_dev

2023-05-29T14:41:29+00:00

First of all, the @lock description is missing. Add it.
Second, correct the terminator value for the mutual exclusive
cabling.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi

extcon: Use sysfs_emit() to instead of sprintf()

2023-05-29T14:41:28+00:00

Follow the advice of the Documentation/filesystems/sysfs.rst that
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Chanwoo Choi