linux.git/drivers/crypto/qat, branch v5.14

crypto: qat - ratelimit invalid ioctl message and print the invalid cmd

2021-06-28T03:28:08+00:00

Currently incorrect QAT ioctls can spam the kernel log with error messages
of the form "QAT: Invalid ioctl" if a userspace program uses the wrong
ioctl command. Quench the messages by ratelimiting them and also print
the invalid command being used as that is useful to know.

Signed-off-by: Colin Ian King 
Acked-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - remove unused macro in FW loader

2021-05-28T06:20:40+00:00

Remove the unused macro ICP_DH895XCC_PESRAM_BAR_SIZE in the firmware
loader.

This is to fix the following warning when compiling the driver using the
clang compiler with CC=clang W=2:

    drivers/crypto/qat/qat_common/qat_uclo.c:345:9: warning: macro is not used [-Wunused-macros]

Signed-off-by: Jack Xu 
Co-developed-by: Zhehui Xiang 
Signed-off-by: Zhehui Xiang 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - check return code of qat_hal_rd_rel_reg()

2021-05-28T06:20:40+00:00

Check the return code of the function qat_hal_rd_rel_reg() and return it
to the caller.

This is to fix the following warning when compiling the driver with
clang scan-build:

    drivers/crypto/qat/qat_common/qat_hal.c:1436:2: warning: 6th function call argument is an uninitialized value

Signed-off-by: Jack Xu 
Co-developed-by: Zhehui Xiang 
Signed-off-by: Zhehui Xiang 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - report an error if MMP file size is too large

2021-05-28T06:20:40+00:00

Change the return status to error if MMP file size is too large so the
driver load fails early if a large MMP firmware is loaded.

Signed-off-by: Jack Xu 
Co-developed-by: Zhehui Xiang 
Signed-off-by: Zhehui Xiang 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - check MMP size before writing to the SRAM

2021-05-28T06:20:40+00:00

Change "sram_visible" to "mmp_sram_size" and compare it with the MMP
size to prevent an overly large MMP file being written to SRAM.

Signed-off-by: Jack Xu 
Co-developed-by: Zhehui Xiang 
Signed-off-by: Zhehui Xiang 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - return error when failing to map FW

2021-05-28T06:20:40+00:00

Save the return value of qat_uclo_map_auth_fw() function so that the
function qat_uclo_wr_mimage() could return the correct value.
This way, the procedure of adf_gen2_ae_fw_load() function could stop
and exit properly by checking the return value of qat_uclo_wr_mimage().

Signed-off-by: Jack Xu 
Co-developed-by: Zhehui Xiang 
Signed-off-by: Zhehui Xiang 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - enable detection of accelerators hang

2021-04-16T11:16:34+00:00

Enable the detection of hangs by setting watchdog timers (WDTs) on
generations that supports that feature.

The default timeout value comes from HW specs. WTDs are reset each time
an accelerator wins arbitration and is able to send/read a command to/from
an accelerator.

The value has added significant margin to make sure there are no spurious
timeouts. The scope of watchdog is per QAT device.

If a timeout is detected, the firmware resets the accelerator and
returns a response descriptor with an appropriate error code.

Signed-off-by: Wojciech Ziemba 
Reviewed-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu

crypto: qat - Fix a double free in adf_create_ring

2021-04-09T07:45:14+00:00

In adf_create_ring, if the callee adf_init_ring() failed, the callee will
free the ring->base_addr by dma_free_coherent() and return -EFAULT. Then
adf_create_ring will goto err and the ring->base_addr will be freed again
in adf_cleanup_ring().

My patch sets ring->base_addr to NULL after the first freed to avoid the
double free.

Fixes: a672a9dc872ec ("crypto: qat - Intel(R) QAT transport code")
Signed-off-by: Lv Yunlong 
Signed-off-by: Herbert Xu

crypto: qat - fix error path in adf_isr_resource_alloc()

2021-04-02T07:28:12+00:00

The function adf_isr_resource_alloc() is not unwinding correctly in case
of error.
This patch fixes the error paths and propagate the errors to the caller.

Fixes: 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc accelerator")
Signed-off-by: Giovanni Cabiddu 
Reviewed-by: Marco Chiappero 
Signed-off-by: Herbert Xu

crypto: qat - ADF_STATUS_PF_RUNNING should be set after adf_dev_init

2021-03-26T09:02:36+00:00

ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown()
before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the
vf2pf_lock is initialized in adf_dev_init(), which can fail and when it
fail, the vf2pf_lock is either not initialized or destroyed, a subsequent
use of vf2pf_lock will cause issue.
To fix this issue, only set this flag if adf_dev_init() returns 0.

[    7.178404] BUG: KASAN: user-memory-access in __mutex_lock.isra.0+0x1ac/0x7c0
[    7.180345] Call Trace:
[    7.182576]  mutex_lock+0xc9/0xd0
[    7.183257]  adf_iov_putmsg+0x118/0x1a0 [intel_qat]
[    7.183541]  adf_vf2pf_shutdown+0x4d/0x7b [intel_qat]
[    7.183834]  adf_dev_shutdown+0x172/0x2b0 [intel_qat]
[    7.184127]  adf_probe+0x5e9/0x600 [qat_dh895xccvf]

Signed-off-by: Tong Zhang 
Reviewed-by: Andy Shevchenko 
Fixes: 25c6ffb249f6 ("crypto: qat - check if PF is running")
Acked-by: Giovanni Cabiddu 
Signed-off-by: Herbert Xu