linux.git/drivers/crypto/nx, branch v5.8

crypto/nx: Remove 'pid' in vas_tx_win_attr struct

2020-04-20T06:53:14+00:00

When window is opened, pid reference is taken for user space
windows. Not needed for kernel windows. So remove 'pid' in
vas_tx_win_attr struct.

Signed-off-by: Haren Myneni 
Acked-by: Herbert Xu 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1587114674.2275.1132.camel@hbabu-laptop

crypto/nx: Enable and setup GZIP compression type

2020-04-20T06:53:14+00:00

Changes to probe GZIP device-tree nodes, open RX windows and setup
GZIP compression type. No plans to provide GZIP usage in kernel right
now, but this patch enables GZIP for user space usage.

Signed-off-by: Haren Myneni 
Acked-by: Herbert Xu 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1587114624.2275.1129.camel@hbabu-laptop

crypto/nx: Make enable code generic to add new GZIP compression type

2020-04-20T06:53:14+00:00

Make setup and enable code generic to support new GZIP compression type.
Changed nx842 reference to nx and moved some code to new functions.
Functionality is not changed except sparse warning fix - setting NULL
instead of 0 for per_cpu send window in nx_delete_coprocs().

Signed-off-by: Haren Myneni 
Acked-by: Herbert Xu 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1587114569.2275.1126.camel@hbabu-laptop

crypto/nx: Rename nx-842-powernv file name to nx-common-powernv

2020-04-20T06:53:14+00:00

Rename nx-842-powernv.c to nx-common-powernv.c to add code for setup
and enable new GZIP compression type. The actual functionality is not
changed in this patch.

Signed-off-by: Haren Myneni 
Acked-by: Herbert Xu 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1587114200.2275.1113.camel@hbabu-laptop

crypto/nx: Initialize coproc entry with kzalloc

2020-04-20T06:53:14+00:00

coproc entry is initialized during NX probe on power9, but not on P8.
nx842_delete_coprocs() is used for both and frees receive window if it
is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin
is not initialized.

This patch replaces kmalloc with kzalloc in nx842_powernv_probe()

Signed-off-by: Haren Myneni 
Acked-by: Herbert Xu 
Signed-off-by: Michael Ellerman 
Link: https://lore.kernel.org/r/1587114163.2275.1110.camel@hbabu-laptop

crypto: Replace zero-length array with flexible-array member

2020-03-06T01:28:21+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: nx - remove stale comment referring to the blkcipher walk API

2019-11-17T01:02:49+00:00

These drivers do not use either the deprecated blkcipher or the current
skcipher walk API, so this comment must refer to a previous state of the
driver that no longer exists. So drop the comments.

Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics

2019-10-25T15:09:59+00:00

Variables of type atomic{,64}_t can be used fine with
debugfs_create_u{32,64}, when passing a pointer to the embedded counter.
This allows to get rid of the casts, which prevented compiler checks.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: nx - convert AES-CTR to skcipher API

2019-10-23T08:47:00+00:00

Convert the PowerPC Nest (NX) implementation of AES-CTR from the
deprecated "blkcipher" API to the "skcipher" API.  This is needed in
order for the blkcipher API to be removed.

Signed-off-by: Eric Biggers 
Reviewed-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: nx - convert AES-CBC to skcipher API

2019-10-23T08:46:59+00:00

Convert the PowerPC Nest (NX) implementation of AES-CBC from the
deprecated "blkcipher" API to the "skcipher" API.  This is needed in
order for the blkcipher API to be removed.

Signed-off-by: Eric Biggers 
Reviewed-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu