linux.git/drivers/crypto/marvell, branch v4.8

crypto: marvell - Don't copy IV vectors from the _process op for ciphers

2016-07-29T10:30:17+00:00

The IV output vectors should only be copied from the _complete operation
and not from the _process operation, i.e only from the operation that is
designed to copy the result of the request to the right location. This
copy is already done in the _complete operation, so this commit removes
the duplicated code in the _process op.

Fixes: 3610d6cd5231 ("crypto: marvell - Add a complete...")
Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Update cache with input sg only when it is unmapped

2016-07-28T05:04:44+00:00

So far, the cache of the ahash requests was updated from the 'complete'
operation. This complete operation is called from mv_cesa_tdma_process
before the cleanup operation, which means that the content of req->src
can be read and copied when it is still mapped. This commit fixes the
issue by moving this cache update from mv_cesa_ahash_complete to
mv_cesa_ahash_req_cleanup, so the copy is done once the sglist is
unmapped.

Fixes: 1bf6682cb31d ("crypto: marvell - Add a complete operation for..")
Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Don't chain at DMA level when backlog is disabled

2016-07-28T05:04:43+00:00

The flag CRYPTO_TFM_REQ_MAY_BACKLOG is optional and can be set from the
user to put requests into the backlog queue when the main cryptographic
queue is full. Before calling mv_cesa_tdma_chain we must check the value
of the return status to be sure that the current request has been
correctly queued or added to the backlog.

Fixes: 85030c5168f1 ("crypto: marvell - Add support for chaining...")
Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Fix memory leaks in TDMA chain for cipher requests

2016-07-28T05:04:42+00:00

So far in mv_cesa_ablkcipher_dma_req_init, if an error is thrown while
the tdma chain is built there is a memory leak. This issue exists
because the chain is assigned later at the end of the function, so the
cleanup function is called with the wrong version of the chain.

Fixes: db509a45339f ("crypto: marvell/cesa - add TDMA support")
Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Fix wrong flag used for GFP in mv_cesa_dma_add_iv_op

2016-07-19T07:42:40+00:00

Use the parameter 'gfp_flags' instead of 'flag' as second argument of
dma_pool_alloc(). The parameter 'flag' is for the TDMA descriptor, its
content has no sense for the allocator.

Fixes: bac8e805a30d ("crypto: marvell - Copy IV vectors by DMA...")
Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Increase the size of the crypto queue

2016-06-23T10:29:52+00:00

Now that crypto requests are chained together at the DMA level, we
increase the size of the crypto queue for each engine. The result is
that as the backlog list is reached later, it does not stop the crypto
stack from sending asychronous requests, so more cryptographic tasks
are processed by the engines.

Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Add support for chaining crypto requests in TDMA mode

2016-06-23T10:29:51+00:00

The Cryptographic Engines and Security Accelerators (CESA) supports the
Multi-Packet Chain Mode. With this mode enabled, multiple tdma requests
can be chained and processed by the hardware without software
intervention. This mode was already activated, however the crypto
requests were not chained together. By doing so, we reduce significantly
the number of IRQs. Instead of being interrupted at the end of each
crypto request, we are interrupted at the end of the last cryptographic
request processed by the engine.

This commits re-factorizes the code, changes the code architecture and
adds the required data structures to chain cryptographic requests
together before sending them to an engine (stopped or possibly already
running).

Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Add load balancing between engines

2016-06-23T10:29:51+00:00

This commits adds support for fine grained load balancing on
multi-engine IPs. The engine is pre-selected based on its current load
and on the weight of the crypto request that is about to be processed.
The global crypto queue is also moved to each engine. These changes are
required to allow chaining crypto requests at the DMA level. By using
a crypto queue per engine, we make sure that we keep the state of the
tdma chain synchronized with the crypto queue. We also reduce contention
on 'cesa_dev->lock' and improve parallelism.

Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Move SRAM I/O operations to step functions

2016-06-23T10:17:25+00:00

Currently the crypto requests were sent to engines sequentially.
This commit moves the SRAM I/O operations from the prepare to the step
functions. It provides flexibility for future works and allow to prepare
a request while the engine is running.

Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu

crypto: marvell - Add a complete operation for async requests

2016-06-23T10:17:24+00:00

So far, the 'process' operation was used to check if the current request
was correctly handled by the engine, if it was the case it copied
information from the SRAM to the main memory. Now, we split this
operation. We keep the 'process' operation, which still checks if the
request was correctly handled by the engine or not, then we add a new
operation for completion. The 'complete' method copies the content of
the SRAM to memory. This will soon become useful if we want to call
the process and the complete operations from different locations
depending on the type of the request (different cleanup logic).

Signed-off-by: Romain Perier 
Acked-by: Boris Brezillon 
Signed-off-by: Herbert Xu