linux.git/drivers/crypto/ccree/cc_driver.c, branch v5.8

crypto: ccree - use existing dev helper in init_cc_resources()

2020-02-22T01:25:46+00:00

Use the existing dev helper variable instead of plat_dev->dev.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - spelling s/Crytpcell/Cryptocell/

2020-02-22T01:25:46+00:00

Fix a typo in a comment.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove cc_pm_is_dev_suspended() wrapper

2020-02-22T01:25:44+00:00

If CONFIG_PM=y, cc_pm_is_dev_suspended() is just a wrapper around
pm_runtime_suspended().
If CONFIG_PM=n, cc_pm_is_dev_suspended() a dummy that behaves exactly
the same as the dummy for pm_runtime_suspended().

Hence remove cc_pm_is_dev_suspended(), and call pm_runtime_suspended()
directly.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - use of_device_get_match_data()

2020-02-22T01:25:44+00:00

If the driver is probed, it means a match was found in
arm_ccree_dev_of_match[].  Hence we can just use the
of_device_get_match_data() helper.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - simplify Runtime PM handling

2020-02-22T01:25:44+00:00

Currently, a large part of the probe function runs before Runtime PM is
enabled.  As the driver manages the device's clock manually, this may
work fine on some systems, but may break on platforms with a more
complex power hierarchy.

Fix this by moving the initialization of Runtime PM before the first
register access (in cc_wait_for_reset_completion()), and putting the
device to sleep only after the last access (in cc_set_ree_fips_status()).

This allows to remove the pm_on flag, which was used to track manually
if Runtime PM had been enabled or not.
Remove the cc_pm_{init,go,fini}() wrappers, as they are called only
once, and obscure operation.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - clean up clock handling

2020-02-22T01:25:43+00:00

Use devm_clk_get_optional() instead of devm_clk_get() and explicit
optional clock handling.
As clk_prepare_enable() and clk_disable_unprepare() handle optional
clocks fine, the cc_clk_on() and cc_clk_off() wrappers can be removed.

While at it, use the new "%pe" format specifier to print error codes.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove empty cc_sram_mgr_fini()

2020-02-22T01:25:43+00:00

cc_sram_mgr_fini() doesn't do anything, so it can just be removed.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - drop duplicated error message on SRAM exhaustion

2020-02-22T01:25:43+00:00

When no SRAM can be allocated, cc_sram_alloc() already prints an error
message.  Hence there is no need to duplicate this in all callers.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - swap SHA384 and SHA512 larval hashes at build time

2020-02-22T01:25:43+00:00

Due to the way the hardware works, every double word in the SHA384 and
SHA512 larval hashes must be swapped.  Currently this is done at run
time, during driver initialization.

However, this swapping can easily be done at build time.  Treating each
double word as two words has the benefit of changing the larval hashes'
types from u64[] to u32[], like for all other hashes, and allows
dropping the casts and size doublings when calling cc_set_sram_desc().

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - split overloaded usage of irq field

2020-01-22T08:21:10+00:00

We were using the irq field of the drvdata struct in
an overloaded fahsion - saving the IRQ number during init
and then storing the pending itnerrupt sources during
interrupt in the same field.

This worked because these usage are mutually exclusive but
are confusing. So simplify the code and change the init use
case to use a simple local variable.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu