linux.git/drivers/crypto/ccree/cc_buffer_mgr.c, branch v5.8

crypto: ccree - refactor AEAD IV in AAD handling

2020-03-12T12:00:16+00:00

Our handling of ciphers with IV trailing the AAD was correct
but overly complicated. Refactor to simplify and possibly
save one DMA burst.

This has the added bonus of behaving the same as the generic
rfc4543 implementation for none compliants inputs where the
IV in the iv field was not the same as the IV in the AAD.

There should be no change in behaviour with correct inputs.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - remove ancient TODO remarks

2020-03-12T12:00:16+00:00

Remove left over ancient and now misleading TODO remarks.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - improve kerneldoc in cc_buffer_mgr.c

2020-02-22T01:25:45+00:00

Miscellaneous improvements:
  - Add missing parameter and return value descriptions.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove struct buff_mgr_handle

2020-02-22T01:25:45+00:00

The buff_mgr_handle structure contains only a single member, and only
one instance exists.  Simplify the code and reduce memory consumption by
moving this member to struct cc_drvdata.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - make mlli_params.mlli_virt_addr void *

2020-02-22T01:25:43+00:00

mlli_params.mlli_virt_addr is just a buffer of memory.
This allows to drop a cast.

No change in generated code.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove unneeded casts

2020-02-22T01:25:43+00:00

Unneeded casts prevent the compiler from performing valuable checks.
This is especially true for function pointers.

Remove these casts, to prevent silently introducing bugs when a
variable's type might be changed in the future.

No change in generated code.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - dec auth tag size from cryptlen map

2020-02-13T09:05:25+00:00

Remove the auth tag size from cryptlen before mapping the destination
in out-of-place AEAD decryption thus resolving a crash with
extended testmgr tests.

Signed-off-by: Gilad Ben-Yossef 
Reported-by: Geert Uytterhoeven 
Cc: stable@vger.kernel.org # v4.19+
Tested-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - only try to map auth tag if needed

2020-02-13T09:05:24+00:00

Make sure to only add the size of the auth tag to the source mapping
for encryption if it is an in-place operation. Failing to do this
previously caused us to try and map auth size len bytes from a NULL
mapping and crashing if both the cryptlen and assoclen are zero.

Reported-by: Geert Uytterhoeven 
Tested-by: Geert Uytterhoeven 
Signed-off-by: Gilad Ben-Yossef 
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu

crypto: ccree - protect against empty or NULL scatterlists

2020-02-13T09:05:24+00:00

Deal gracefully with a NULL or empty scatterlist which can happen
if both cryptlen and assoclen are zero and we're doing in-place
AEAD encryption.

This fixes a crash when this causes us to try and map a NULL page,
at least with some platforms / DMA mapping configs.

Cc: stable@vger.kernel.org # v4.19+
Reported-by: Geert Uytterhoeven 
Tested-by: Geert Uytterhoeven 
Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - use std api sg_zero_buffer

2019-08-09T05:05:31+00:00

Replace internal cc_zero_sgl() with kernel API of the same function
sg_zero_buffer().

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu