linux.git/drivers/clk/clk-devres.c, branch v6.0

clk: Fix pointer casting to prevent oops in devm_clk_release()

2022-06-22T23:10:23+00:00

The release function is called with a pointer to the memory returned by
devres_alloc(). I was confused about that by the code before the
generalization that used a struct clk **ptr.

Reported-by: Marek Szyprowski 
Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20220620171815.114212-1-u.kleine-koenig@pengutronix.de
Tested-by: Marek Szyprowski 
Tested-by: Linux Kernel Functional Testing 
Signed-off-by: Stephen Boyd

clk: Provide new devm_clk helpers for prepared and enabled clocks

2022-06-16T02:22:29+00:00

When a driver keeps a clock prepared (or enabled) during the whole
lifetime of the driver, these helpers allow to simplify the drivers.

Reviewed-by: Jonathan Cameron 
Reviewed-by: Alexandru Ardelean 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20220520075737.758761-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd

clk: generalize devm_clk_get() a bit

2022-06-16T02:22:29+00:00

Allow to add an exit hook to devm managed clocks. Also use
clk_get_optional() in devm_clk_get_optional instead of open coding it.
The generalisation will be used in the next commit to add some more
devm_clk helpers.

Reviewed-by: Jonathan Cameron 
Reviewed-by: Alexandru Ardelean 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20220520075737.758761-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd

clk: fix leak on devm_clk_bulk_get_all() unwind

2021-07-31T07:53:38+00:00

clk_bulk_get_all() allocates an array of struct clk_bulk data for us
(unlike clk_bulk_get()), so we need to free it. Let's use the
clk_bulk_put_all() helper.

kmemleak complains, on an RK3399 Gru/Kevin system:

unreferenced object 0xffffff80045def00 (size 128):
  comm "swapper/0", pid 1, jiffies 4294667682 (age 86.394s)
  hex dump (first 32 bytes):
    44 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00  D2`.............
    48 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00  H2`.............
  backtrace:
    [<00000000742860d6>] __kmalloc+0x22c/0x39c
    [<00000000b0493f2c>] clk_bulk_get_all+0x64/0x188
    [<00000000325f5900>] devm_clk_bulk_get_all+0x58/0xa8
    [<00000000175b9bc5>] dwc3_probe+0x8ac/0xb5c
    [<000000009169e2f9>] platform_drv_probe+0x9c/0xbc
    [<000000005c51e2ee>] really_probe+0x13c/0x378
    [<00000000c47b1f24>] driver_probe_device+0x84/0xc0
    [<00000000f870fcfb>] __device_attach_driver+0x94/0xb0
    [<000000004d1b92ae>] bus_for_each_drv+0x8c/0xd8
    [<00000000481d60c3>] __device_attach+0xc4/0x150
    [<00000000a163bd36>] device_initial_probe+0x1c/0x28
    [<00000000accb6bad>] bus_probe_device+0x3c/0x9c
    [<000000001a199f89>] device_add+0x218/0x3cc
    [<000000001bd84952>] of_device_add+0x40/0x50
    [<000000009c658c29>] of_platform_device_create_pdata+0xac/0x100
    [<0000000021c69ba4>] of_platform_bus_create+0x190/0x224

Fixes: f08c2e2865f6 ("clk: add managed version of clk_bulk_get_all")
Cc: Dong Aisheng 
Cc: stable@vger.kernel.org
Signed-off-by: Brian Norris 
Link: https://lore.kernel.org/r/20210731025950.2238582-1-briannorris@chromium.org
Signed-off-by: Stephen Boyd

clk: Add devm_clk_bulk_get_optional() function

2019-06-25T21:28:01+00:00

Add managed version of the clk_bulk_get_optional() helper function.

Signed-off-by: Sylwester Nawrocki 
[sboyd@kernel.org: Mark __devm_clk_bulk_get() static]
Signed-off-by: Stephen Boyd

clk: Add (devm_)clk_get_optional() functions

2019-02-06T18:33:10+00:00

This adds clk_get_optional() and devm_clk_get_optional() functions to get
optional clocks.

They behave the same as (devm_)clk_get() except where there is no clock
producer. In this case, instead of returning -ENOENT, the function
returns NULL. This makes error checking simpler and allows
clk_prepare_enable, etc to be called on the returned reference
without additional checks.

Signed-off-by: Phil Edworthy 
Reviewed-by: Andy Shevchenko 
Cc: Russell King 
[sboyd@kernel.org: Document in devres.txt]
Signed-off-by: Stephen Boyd

clk: Tag clk core files with SPDX

2018-12-11T17:57:47+00:00

These are all GPL-2.0 files per the existing license text. Replace the
boiler plate with the tag.

Signed-off-by: Stephen Boyd

clk: add managed version of clk_bulk_get_all

2018-10-16T22:42:49+00:00

This patch introduces the managed version of clk_bulk_get_all.

Cc: Michael Turquette 
Cc: Stephen Boyd 
Tested-by: Thor Thayer 
Signed-off-by: Dong Aisheng 
Signed-off-by: Stephen Boyd

clk: add managed version of clk_bulk_get

2017-06-02T22:37:49+00:00

This patch introduces the managed version of clk_bulk_get.

Cc: Michael Turquette 
Cc: Stephen Boyd 
Cc: Russell King 
Cc: Geert Uytterhoeven 
Cc: "Rafael J. Wysocki" 
Cc: Viresh Kumar 
Cc: Mark Brown 
Cc: Shawn Guo 
Cc: Fabio Estevam 
Cc: Sascha Hauer 
Cc: Anson Huang 
Cc: Robin Gong 
Cc: Bai Ping 
Cc: Leonard Crestez 
Cc: Octavian Purdila 
Signed-off-by: Dong Aisheng 
Signed-off-by: Stephen Boyd

clk: add devm_get_clk_from_child() API

2016-12-09T00:37:33+00:00

Some driver is using this type of DT bindings for clock (more detail,
see ${LINUX}/Documentation/devicetree/bindings/sound/simple-card.txt).

	sound_soc {
		...
		cpu {
			clocks = <&xxx>;
			...
		};
		codec {
			clocks = <&xxx>;
			...
		};
	};

Current driver in this case uses of_clk_get() for each node, but there
is no devm_of_clk_get() today.
OTOH, the problem of having devm_of_clk_get() is that it encourages the
use of of_clk_get() when clk_get() is more desirable.

Thus, this patch adds new devm_get_clk_from_chile() which explicitly
reads as get a clock from a child node of this device.
By this function, we can also use this type of DT bindings

	sound_soc {
		clocks = <&xxx>, <&xxx>;
		clock-names = "cpu", "codec";
		clock-ranges;
		...
		cpu {
			...
		};
		codec {
			...
		};
	};

Signed-off-by: Kuninori Morimoto 
[sboyd@codeurora.org: Rename subject to clk + add API]
Signed-off-by: Stephen Boyd