linux.git/drivers/char/virtio_console.c, branch v3.19

virtio_console: fix sparse warnings

2014-12-09T10:06:33+00:00

CHECK drivers/char/virtio_console.c
drivers/char/virtio_console.c:687:36: warning: incorrect type in
	argument 1 (different address spaces)
drivers/char/virtio_console.c:687:36:    expected void [noderef]
	*to
drivers/char/virtio_console.c:687:36:    got char *out_buf
drivers/char/virtio_console.c:790:35: warning: incorrect type in
	argument 2 (different address spaces)
drivers/char/virtio_console.c:790:35:    expected char *out_buf
drivers/char/virtio_console.c:790:35:    got char [noderef]
	*ubuf

fill_readbuf is reused with both kernel and userspace pointers,
depending on value of to_user flag.

Tag address parameter as __user, and cast to/from regular pointer type
when we know it's safe.

Signed-off-by: Michael S. Tsirkin

virtio: drop VIRTIO_F_VERSION_1 from drivers

2014-12-09T10:06:32+00:00

Core activates this bit automatically now,
drop it from drivers that set it explicitly.

Signed-off-by: Michael S. Tsirkin

virtio_console: virtio 1.0 support

2014-12-09T10:06:32+00:00

Pretty straight-forward, just use accessors for all fields.

Signed-off-by: Michael S. Tsirkin

virtio: use u32, not bitmap for features

2014-12-09T10:05:23+00:00

It seemed like a good idea to use bitmap for features
in struct virtio_device, but it's actually a pain,
and seems to become even more painful when we get more
than 32 feature bits.  Just change it to a u32 for now.

Based on patch by Rusty.

Suggested-by: David Hildenbrand 
Signed-off-by: Rusty Russell 
Signed-off-by: Cornelia Huck 
Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck

virtio_console: move early VQ enablement

2014-11-13T07:53:26+00:00

Commit f5866db6 (virtio_console: enable VQs early) tried to make
sure that DRIVER_OK was set when virtio_console started using its
virtqueues. Doing this in add_port(), however, means that we try
to set DRIVER_OK again when when a port is dynamically added after
the probe function is done.

Let's move virtio_device_ready() to the probe function just before
trying to use the virtqueues instead. This is fine as nothing can
fail inbetween.

Reported-by: Thomas Graf 
Reviewed-by: Michael S. Tsirkin 
Signed-off-by: Cornelia Huck 

Signed-off-by: Michael S. Tsirkin

virtio_console: enable VQs early on restore

2014-10-14T23:55:09+00:00

virtio spec requires drivers to set DRIVER_OK before using VQs.
This is set automatically after resume returns, virtio console violated this
rule by adding inbufs, which causes the VQ to be used directly within
restore.

To fix, call virtio_device_ready before using VQs.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio_console: enable VQs early

2014-10-14T23:55:03+00:00

virtio spec requires drivers to set DRIVER_OK before using VQs.
This is set automatically after probe returns, virtio console violated this
rule by adding inbufs, which causes the VQ to be used directly within
probe.

To fix, call virtio_device_ready before using VQs.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell

virtio: console: remove unnecessary null test before debugfs_remove_recursive

2014-07-27T11:37:14+00:00

Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required

Cc: Arnd Bergmann 
Cc: virtualization@lists.linux-foundation.org
Reviewed-by: Amit Shah 
Signed-off-by: Fabian Frederick 
Signed-off-by: Rusty Russell

pipe: kill ->map() and ->unmap()

2014-04-02T03:19:19+00:00

all pipe_buffer_operations have the same instances of those...

Signed-off-by: Al Viro

fix a kmap leak in virtio_console

2014-02-09T20:21:16+00:00

While we are at it, don't do kmap() under kmap_atomic(), *especially*
for a page we'd allocated with GFP_KERNEL.  It's spelled "page_address",
and had that been more than that, we'd have a real trouble - kmap_high()
can block, and doing that while holding kmap_atomic() is a Bad Idea(tm).

Signed-off-by: Al Viro