linux.git/drivers/char/ttyprintk.c, branch v5.5

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 402

2019-06-05T15:37:13+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the smems of the gnu general public license as published by
  the free software foundation version 2 of the license

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 5 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Armijn Hemel 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190111.946565886@linutronix.de
Signed-off-by: Greg Kroah-Hartman

ttyprintk: make the printk log level configurable

2018-11-09T16:58:18+00:00

For some use cases it is handy to use a different printk log level than the
default (info) for the messages written to ttyprintk, so add a Kconfig
option similar to what we have for default console loglevel.

Signed-off-by: Peter Korsgaard 
Signed-off-by: Greg Kroah-Hartman

ttyprintk: Neaten and simplify printing

2016-09-13T15:30:17+00:00

The code is a bit obscure.

Simplify it by using a single routine to flush the tpk_buffer and
emit the buffer prefixed with "[U] ".

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

char: constify tty_port_operations structs

2016-02-07T07:31:08+00:00

Constifies tty_port_operations structure in
the char driver since it is not modified
after its initialization.

Detected and found using Coccinelle.

Suggested-by: Julia Lawall 
Signed-off-by: Aya Mahfouz 
Acked-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

ttyprintk: Allow built as a module

2014-04-16T21:21:06+00:00

The driver is well written to be used as a module, just the exit call
is missing.

Reviewed-by: Jean Delvare 
Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ttyprintk: Fix wrong tty_unregister_driver() call in the error path

2014-04-16T21:21:06+00:00

ttyprintk driver calls tty_unregister_driver() wrongly in the error
path of tty_register_driver().  Also, setting ttyprintk_driver to NULL
is utterly superfluous, so let's get rid of it, too.

Reported-by: Jean Delvare 
Reviewed-by: Jean Delvare 
Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

drivers/char: don't use module_init in non-modular ttyprintk.c

2014-01-13T22:57:20+00:00

The TTY_PRINTK option is bool, and hence this code is either
present or absent.  It will never be modular, so using
module_init as an alias for __initcall is rather misleading.

Fix this up now, so that we can relocate module_init from
init.h into module.h in the future.  If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.

Note that direct use of __initcall is discouraged, vs. one
of the priority categorized subgroups.  As __initcall gets
mapped onto device_initcall, our use of device_initcall
directly in this change means that the runtime impact is
zero -- it will remain at level 6 in initcall ordering.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Greg Kroah-Hartman

ttyprintk: Fix NULL pointer deref by setting tty_port ops after initializing port

2013-05-21T17:13:23+00:00

tty_port_init() zeroes out the tty port, which means that we have to set the
ops pointer /after/, not before this call.  Otherwise, tty_port_open will crash
when it tries to deref ops, which is now a NULL pointer.

Signed-off-by: Darrick J. Wong 
Signed-off-by: Greg Kroah-Hartman

TTY: call tty_port_destroy in the rest of drivers

2012-11-16T01:20:58+00:00

After commit "TTY: move tty buffers to tty_port", the tty buffers are
not freed in some drivers. This is because tty_port_destructor is not
called whenever a tty_port is freed. This was an assumption I counted
with but was unfortunately untrue. So fix the drivers to fulfil this
assumption.

To be sure, the TTY buffers (and later some stuff) are gone along with
the tty_port, we have to call tty_port_destroy at tear-down places.
This is mostly where the structure containing a tty_port is freed.
This patch does exactly that -- put tty_port_destroy at those places.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

TTY: tty_alloc_driver() returns error pointers

2012-08-16T19:07:23+00:00

We changed these from alloc_tty_driver() to tty_alloc_driver() so the
error handling needs to modified to check for IS_ERR() instead of NULL.

Signed-off-by: Dan Carpenter 
Acked-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman