linux.git/drivers/char/tpm, branch v2.6.28

tpm: don't export static functions

2008-10-20T15:50:24+00:00

Today's linux-next build (powerpc_allyesconfig) failed like this:

drivers/char/tpm/tpm.c:1162: error: __ksymtab_tpm_dev_release causes a section type conflict

Caused by commit 253115b71fa06330bd58afbe01ccaf763a8a0cf1 ("The
tpm_dev_release function is only called for platform devices, not pnp")
which exported a static function.

Signed-off-by: Stephen Rothwell 
Cc: Rajiv Andrade 
Cc: James Morris 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/tpm/tpm.c: fix error-path memory leak

2008-10-16T18:21:49+00:00

tpm_register_hardware() leaks devname on an error path.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11425

Reported-by: Daniel Marjamki 
Cc: Debora Velarde 
Cc: Rajiv Andrade 
Cc: Marcel Selhorst 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tpm: work around bug in Broadcom BCM0102 chipset

2008-10-16T18:21:49+00:00

Patch tpm-correct-tpm-timeouts-to-jiffies-conversion reveals a bug in the
Broadcom BCM0102 TPM chipset used in the Dell Latitude D820 - although
most of the timeouts are returned in usecs as per the spec, one is
apparently returned in msecs, which results in a too-small value leading
to a timeout when the code treats it as usecs.  To prevent a regression,
we check for the known too-short value and adjust it to a value that makes
things work.

Signed-off-by: Valdis Kletnieks 
Cc: Marcin Obara 
Cc: Marcel Selhorst 
Cc: Kylene Jo Hall 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tpm: correct tpm timeouts to jiffies conversion

2008-10-16T18:21:49+00:00

This patch fixes timeouts conversion to jiffies, by replacing
msecs_to_jiffies() calls with usecs_to_jiffies().  According to TCG TPM
Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and
durations are returned in microseconds (usec) not in miliseconds (msec).

This fixes a long hang while loading TPM driver, if TPM chip starts in
"Idle" state instead of "Ready" state.  Without this patch - 'modprobe'
may hang for 30 seconds or more.

Signed-off-by: Marcin Obara 
Cc: Marcel Selhorst 
Cc: Kylene Jo Hall 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

As pointed out by Jonathan Corbet, the timer must be deleted before

2008-10-10T22:05:20+00:00

flushing the work queue in order to avoid a job being submitted after the
chip had been released.

Signed-off-by: Rajiv Andrade 
Signed-off-by: Mimi Zohar 
Cc: Jonathan Corbet 
Cc: "Serge E. Hallyn" 
Signed-off-by: Andrew Morton 
Signed-off-by: James Morris

The tpm_dev_release function is only called for platform devices, not pnp

2008-10-10T22:04:39+00:00

devices, so we implemented the .remove function for pnp ones.  Since it's
code is very similar to the one inside tpm_dev_release, we've created a
helper function tpm_dev_vendor_release, which is called by both.

Signed-off-by: Mimi Zohar 
Signed-off-by: Rajiv Andrade 
Cc: "Serge E. Hallyn" 
Cc: Bjorn Helgaas 
Signed-off-by: Andrew Morton 
Signed-off-by: James Morris

Protect tpm_chip_list when transversing it.

2008-10-10T22:04:23+00:00

Signed-off-by: Mimi Zohar 
Signed-off-by: Rajiv Andrade 
Acked-by: Serge E. Hallyn 
Cc: "Paul E. McKenney" 
Signed-off-by: Andrew Morton 
Signed-off-by: James Morris

Renames num_open to is_open, as only one process can open the file at a time.

2008-10-10T22:04:02+00:00

Signed-off-by: Mimi Zohar 
Signed-off-by: Rajiv Andrade 
Cc: "Serge E. Hallyn" 
Signed-off-by: Andrew Morton 
Signed-off-by: James Morris

Remove the BKL calls from the TPM driver, which were added in the overall

2008-10-10T22:03:39+00:00

misc-char-dev-BKL-pushdown.patch, as they are not needed.

Signed-off-by: Mimi Zohar 
Signed-off-by: Rajiv Andrade 
Cc: "Serge E. Hallyn" 
Signed-off-by: Andrew Morton 
Signed-off-by: James Morris

securityfs: do not depend on CONFIG_SECURITY

2008-08-28T00:47:42+00:00

Add a new Kconfig option SECURITYFS which will build securityfs support
but does not require CONFIG_SECURITY.  The only current user of
securityfs does not depend on CONFIG_SECURITY and there is no reason the
full LSM needs to be built to build this fs.

Signed-off-by: Eric Paris 
Signed-off-by: James Morris