linux.git/drivers/char/rocket.c, branch v2.6.24

Fix misspellings of "system", "controller", "interrupt" and "necessary".

2007-10-19T21:10:43+00:00

Fix the various misspellings of "system", controller", "interrupt" and
"[un]necessary".

Signed-off-by: Robert P. J. Day 
Signed-off-by: Adrian Bunk

Char: rocket, fix signed/unsigned warning

2007-10-18T21:37:27+00:00

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Char: rocket, remove potential leak in module_init

2007-10-18T21:37:27+00:00

if (controller && !request_region) then we leaked a tty driver struct, fix it
by adding function deinit tail with goto-ing into it (and from other fail
paths too)

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Char: rocket, remove pci_read_config_dword(CLASS_REVISION)

2007-10-18T21:37:27+00:00

We may use pdev->revision instead of reading pci config space directly, so
remove pci_read_config_dword invoking.

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Char: rocket, don't re-set statics to 0

2007-10-18T21:37:27+00:00

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Char: rocket, fix dynamic_dev tty

2007-10-18T21:37:27+00:00

- register_device unconditionally (non-pci dependent) to have also isa
  devices in /dev
- unregister devices on module removal
- don't set TTY_DRIVER_DYNAMIC_DEV twice (removed the one dependent on some
  macro)

Signed-off-by: Jiri Slaby 
Cc: Ferenc Wagner 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Char: rocket, switch sleep_on to completion

2007-10-18T21:37:27+00:00

rocket, switch sleep_on to completion

- sleep_on is deprecated and racy, use completion instead
- also check retval of interruptible function and return ERESTARTSYS
  eventually

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

some kmalloc/memset ->kzalloc (tree wide)

2007-07-19T17:04:50+00:00

Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

Here is a short excerpt of the semantic patch performing
this transformation:

@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@

 x =
- kmalloc
+ kzalloc
  (E1,E2)
  ...  when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);

@@
expression E1,E2,E3;
@@

- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)

[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Acked-by: Russell King 
Cc: Bryan Wu 
Acked-by: Jiri Slaby 
Cc: Dave Airlie 
Acked-by: Roland Dreier 
Cc: Jiri Kosina 
Acked-by: Dmitry Torokhov 
Cc: Benjamin Herrenschmidt 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Pierre Ossman 
Cc: Jeff Garzik 
Cc: "David S. Miller" 
Acked-by: Greg KH 
Cc: James Bottomley 
Cc: "Antonino A. Daplas" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rocket.c: fix unchecked mutex_lock_interruptible()

2007-07-16T16:05:43+00:00

Check the return of mutex_lock_interruptible() in drivers/char/rocket.c and
return ERESTARTSYS if we were interrupted.

Signed-off-by: Satyam Sharma 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Kill unused sesssion and group values in rocket driver

2007-05-11T15:29:36+00:00

The process_session() and process_group() values are not really used by the
driver.

Signed-off-by: Sukadev Bhattiprolu 
Cc: Cedric Le Goater 
Cc: Dave Hansen 
Cc: Serge Hallyn 
Cc: 
Cc: Eric W. Biederman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds