linux.git/drivers/char/mem.c, branch v2.6.34

frv: hide uncached_access() when pgprot_noncached is not #defined

2010-04-07T15:38:05+00:00

Hide uncached_access() when pgprot_noncached is not #defined.  This prevents
the following warning:

	  CC      drivers/char/mem.o
	drivers/char/mem.c:229: warning: 'uncached_access' defined but not used

Repairs d7d4d849b4e3acc405ec222884936800ffb26d48 ("drivers/char/mem.c:
cleanups").

Signed-off-by: David Howells 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

/dev/mem: allow rewinding

2010-04-07T15:38:04+00:00

commit dcefafb6 ("/dev/mem: dont allow seek to last page") inadvertently
disabled rewinding on /dev/mem.

This broke x86info for example.

Signed-off-by: Eric Dumazet 
Acked-by: Wu Fengguang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

devmem: handle class_create() failure

2010-04-07T15:38:03+00:00

I hit this when we had a bug in IDR for a few days.  Basically sysfs would
fail to create new inodes since it uses an IDR and therefore class_create
would fail.

While we are unlikely to see this fail we may as well handle it instead of
oopsing.

Signed-off-by: Anton Blanchard 
Reviewed-by: Wu Fengguang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/mem.c: cleanups

2010-03-12T23:52:35+00:00

- fix switch statement layout

- fix whitespace stuff

- fix comment layout

- remove unneeded inlining

- use __weak

- remove trailing whitespace

- move uncached_access() inside `#ifndef __HAVE_PHYS_MEM_ACCESS_PROT' - it
  is otherwise unused.

Cc: KAMEZAWA Hiroyuki 
Cc: OGAWA Hirofumi 
Cc: Wu Fengguang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

/dev/mem: dont allow seek to last page

2010-03-12T23:52:35+00:00

So as to return a uniform error -EOVERFLOW instead of a random one:

# kmem-seek 0xfffffffffffffff0
seek /dev/kmem: Device or resource busy
# kmem-seek 0xfffffffffffffff1
seek /dev/kmem: Block device required

Suggested by OGAWA Hirofumi.

Cc: OGAWA Hirofumi 
Reviewed-by: KAMEZAWA Hiroyuki 
Signed-off-by: Wu Fengguang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

devmem: fix kmem write bug on memory holes

2010-02-03T02:11:22+00:00

write_kmem() used to assume vwrite() always return the full buffer length.
However now vwrite() could return 0 to indicate memory hole.  This
creates a bug that "buf" is not advanced accordingly.

Fix it to simply ignore the return value, hence the memory hole.

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Benjamin Herrenschmidt 
Cc: Christoph Lameter 
Cc: Ingo Molnar 
Cc: Tejun Heo 
Cc: Nick Piggin 
Cc: KAMEZAWA Hiroyuki 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

devmem: check vmalloc address on kmem read/write

2010-02-03T02:11:22+00:00

Otherwise vmalloc_to_page() will BUG().

This also makes the kmem read/write implementation aligned with mem(4):
"References to nonexistent locations cause errors to be returned." Here we
return -ENXIO (inspired by Hugh) if no bytes have been transfered to/from
user space, otherwise return partial read/write results.

Signed-off-by: KAMEZAWA Hiroyuki 
Signed-off-by: Wu Fengguang 
Cc: Greg Kroah-Hartman 
Cc: Hugh Dickins 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

/dev/mem: remove redundant parameter from do_write_kmem()

2009-12-15T16:53:12+00:00

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Avi Kivity 
Cc: Greg Kroah-Hartman 
Cc: Johannes Berg 
Cc: Marcelo Tosatti 
Cc: Mark Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

/dev/mem: remove the "written" variable in write_kmem()

2009-12-15T16:53:11+00:00

Also rename "len" to "sz". No behavior change.

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Avi Kivity 
Cc: Greg Kroah-Hartman 
Cc: Johannes Berg 
Cc: Marcelo Tosatti 
Cc: Mark Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

/dev/mem: make size_inside_page() logic straight

2009-12-15T16:53:11+00:00

Also convert more size_inside_page() users.

Signed-off-by: Wu Fengguang 
Cc: Andi Kleen 
Cc: Avi Kivity 
Cc: Greg Kroah-Hartman 
Cc: Johannes Berg 
Cc: Marcelo Tosatti 
Cc: Mark Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds