linux.git/drivers/char/ipmi, branch v5.1-rc2

ipmi_si: Potential array underflow in hotmod_handler()

2019-02-22T20:59:25+00:00

The "ival" variable needs to signed so that we don't read before the
start of the str[] array.  This would only happen the user passed in a
module parameter that was just comprised of space characters.

Fixes: e80444ae4fc3 ("ipmi_si: Switch hotmod to use a platform device")
Signed-off-by: Dan Carpenter 
Message-Id: <20190222195530.GA306@kadam>
Signed-off-by: Corey Minyard

ipmi_si: Remove hacks for adding a dummy platform devices

2019-02-22T13:12:41+00:00

All the IPMI address sources now supply a real device.  This cheap
hack is no longer necessary.

Signed-off-by: Corey Minyard

ipmi_si: Consolidate scanning the platform bus

2019-02-22T13:12:41+00:00

The same basic code was in two places.

Signed-off-by: Corey Minyard

ipmi_si: Remove hotmod devices on removal and exit

2019-02-22T13:12:41+00:00

When a hotmod-added device is removed or when the module is removed,
remove the platform devices that was created for it.

Signed-off-by: Corey Minyard

ipmi_si: Remove hardcode IPMI devices by scanning the platform bus

2019-02-22T13:12:41+00:00

Instead of keeping track of each one, just scan the platform bus
for hardcode devices and remove them.

Signed-off-by: Corey Minyard

ipmi_si: Switch hotmod to use a platform device

2019-02-22T13:12:41+00:00

Don't force the main code to create one for it.

Signed-off-by: Corey Minyard

ipmi: Consolidate the adding of platform devices

2019-02-22T13:12:41+00:00

It was being done in two different places now that hard-coded devices
use platform devices, and it's about to be three with hotmod switching
to platform devices.  So put the code in one place.

This required some rework on some interfaces to make the type space
clean.

Signed-off-by: Corey Minyard

ipmi_si: Rename addr_type to addr_space to match what it does

2019-02-22T13:12:41+00:00

Make the naming consistent, and make the values an enum.

Signed-off-by: Corey Minyard

ipmi_si: Convert some types into unsigned

2019-02-22T13:12:41+00:00

Things dealing with registers and addresses are all unsigned, make
them so.

Signed-off-by: Corey Minyard

ipmi_si: Fix crash when using hard-coded device

2019-02-22T13:12:41+00:00

When excuting a command like:
  modprobe ipmi_si ports=0xffc0e3 type=bt
The system would get an oops.

The trouble here is that ipmi_si_hardcode_find_bmc() is called before
ipmi_si_platform_init(), but initialization of the hard-coded device
creates an IPMI platform device, which won't be initialized yet.

The real trouble is that hard-coded devices aren't created with
any device, and the fixup is done later.  So do it right, create the
hard-coded devices as normal platform devices.

This required adding some new resource types to the IPMI platform
code for passing information required by the hard-coded device
and adding some code to remove the hard-coded platform devices
on module removal.

To enforce the "hard-coded devices passed by the user take priority
over firmware devices" rule, some special code was added to check
and see if a hard-coded device already exists.

Reported-by: Yang Yingliang 
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Corey Minyard 
Tested-by: Yang Yingliang