linux.git/drivers/char/ipmi, branch v2.6.23

pci: fix unterminated pci_device_id lists

2007-09-19T18:24:17+00:00

Fix a couple drivers that do not correctly terminate their pci_device_id
lists.  This results in garbage being spewed into modules.pcimap when the
module happens to not have 28 NULL bytes following the table, and/or the
last PCI ID is actually truncated from the table when calculating the
modules.alias PCI aliases, cause those unfortunate device IDs to not
auto-load.

Signed-off-by: Kees Cook 
Acked-by: Corey Minyard 
Cc: David Woodhouse 
Acked-by: Jeff Garzik 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

IPMI: fix warning in ipmi_si_intf.c

2007-08-23T02:52:46+00:00

trivial change: fix warning

Signed-off-by: Mijo Safradin 
Acked-by: Christian Krafft 
Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipmi: Fix mem leak in try_init_dmi()

2007-07-31T22:39:41+00:00

This is only called at init time and only happens if the BIOS screws
something up, so the leak is slight and it is probably not worth sending to
2.6.22.x.  The driver would not initialize the interface in the case, and I
have no reports of this happening.  I have booted and run tests on a system
with this patch.  Note that the original patch was munged by the mailer,
here's a new one.

If we ever hit the "default:" case in the switch in try_init_dmi(),
then we'll leak the storage allocated with kzalloc() and assigned
to 'info'.

Signed-off-by: Jesper Juhl 
Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

some kmalloc/memset ->kzalloc (tree wide)

2007-07-19T17:04:50+00:00

Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

Here is a short excerpt of the semantic patch performing
this transformation:

@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@

 x =
- kmalloc
+ kzalloc
  (E1,E2)
  ...  when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);

@@
expression E1,E2,E3;
@@

- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)

[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Acked-by: Russell King 
Cc: Bryan Wu 
Acked-by: Jiri Slaby 
Cc: Dave Airlie 
Acked-by: Roland Dreier 
Cc: Jiri Kosina 
Acked-by: Dmitry Torokhov 
Cc: Benjamin Herrenschmidt 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Pierre Ossman 
Cc: Jeff Garzik 
Cc: "David S. Miller" 
Acked-by: Greg KH 
Cc: James Bottomley 
Cc: "Antonino A. Daplas" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/ipmi/ipmi_si_intf.c: lower printk severity

2007-07-16T16:05:52+00:00

Signed-off-by: Dan Aloni 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/ipmi/ipmi_poweroff.c: lower printk severity

2007-07-16T16:05:52+00:00

Signed-off-by: Dan Aloni 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Use menuconfig objects II - IPMI

2007-07-16T16:05:40+00:00

Change Kconfig objects from "menu, config" into "menuconfig" so
that the user can disable the whole feature without having to
enter the menu first.

Signed-off-by: Jan Engelhardt 
Acked-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sysfs: kill unnecessary attribute->owner

2007-07-11T23:09:06+00:00

sysfs is now completely out of driver/module lifetime game.  After
deletion, a sysfs node doesn't access anything outside sysfs proper,
so there's no reason to hold onto the attribute owners.  Note that
often the wrong modules were accounted for as owners leading to
accessing removed modules.

This patch kills now unnecessary attribute->owner.  Note that with
this change, userland holding a sysfs node does not prevent the
backing module from being unloaded.

For more info regarding lifetime rule cleanup, please read the
following message.

  http://article.gmane.org/gmane.linux.kernel/510293

(tweaked by Greg to not delete the field just yet, to make it easier to
merge things properly.)

Signed-off-by: Tejun Heo 
Cc: Cornelia Huck 
Cc: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Revert "ipmi: add new IPMI nmi watchdog handling"

2007-05-14T22:24:24+00:00

This reverts commit f64da958dfc83335de1d2bef9d3868f30feb4e53.

Andi Kleen is unhappy with the changes, and they really do not seem
worth it.  IPMI could use DIE_NMI_IPI instead of the new callback, even
though that ends up having its own set of problems too, mainly because
the IPMI code cannot really know the NMI was from IPMI or not.

Manually fix up conflicts in arch/x86_64/kernel/traps.c and
drivers/char/ipmi/ipmi_watchdog.c.

Cc: Andi Kleen 
Cc: Mathieu Desnoyers 
Cc: Corey Minyard 
Cc: Andrew Morton 
Signed-off-by: Linus Torvalds

IPMI: Add PPC openfirmware unregister

2007-05-12T17:55:40+00:00

When trying to load the ipmi_si module on a powerpc with no BMC (baseboard
management controller) the driver failes to load correctly, but doesn't
unregister itself from of_platform.  So, on a second modprobe the kernel
crashes.  This patch adds the missing unregister call.

Signed-off-by: Christian Krafft 
Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds