linux.git/drivers/cdrom/cdrom.c, branch v3.0

cdrom: always check_disk_change() on open

2011-04-29T08:17:25+00:00

cdrom_open() called check_disk_change() after the rest of open path
succeeded which leads to the following bizarre behavior.

* After media change, if the device opened without O_NONBLOCK,
  open_for_data() naturally fails with -ENOMEDIA and
  check_disk_change() is never called.  The media is known to be gone
  and the open failure makes it obvious to the userland but device
  invalidation never happens.

* But if the device is opened with O_NONBLOCK, all the checks are
  bypassed and cdrom_open() doesn't notice that the media is not there
  and check_disk_change() is called and invalidation happens.

There's nothing to be gained by avoiding calling check_disk_change()
on open failure.  Common cases end up calling check_disk_change()
anyway.  All we get is inconsistent behavior.

Fix it by moving check_disk_change() invocation to the top of
cdrom_open() so that it always gets called regardless of how the rest
of open proceeds.

Stable: 2.6.38

Signed-off-by: Tejun Heo 
Reported-by: Amit Shah 
Tested-by: Amit Shah 
Cc: stable@kernel.org
Signed-off-by: Jens Axboe

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

cdrom: support devices that have check_events but not media_changed

2011-02-09T13:22:37+00:00

Commit 93aae17af1172c40c6f74b7294e93a90c3cfaa5d ("sr: implement
sr_check_events()") replaced the media_changed op with the
check_events op in drivers/scsi/sr.c

All users that check for the CDC_MEDIA_CHANGED capbility try both
the check_events op and the media_changed op, but register_cdrom()
was requiring media_changed.

This patch fixes the capability checking.

The cdrom_select_disc ioctl is also using the two operations, so
they should be required for CDC_SELECT_DISC too.

Signed-off-by: Simon Arlott 
Cc: Tejun Heo 
Cc: Kay Sievers 
Tested-by: Chris Clayton 
Signed-off-by: Jens Axboe

cdrom: export cdrom_check_events()

2010-12-16T16:58:50+00:00

It's used by sr, so we need to export it.

Signed-off-by: Jens Axboe

cdrom: add ->check_events() support

2010-12-16T16:53:38+00:00

In principle, cdrom just needs to pass through ->check_events() but
CDROM_MEDIA_CHANGED ioctl makes things a bit more complex.  Just as
with ->media_changed() support, cdrom code needs to buffer the events
and serve them to ioctl and vfs as requested.

As the code has to deal with both ->check_events() and
->media_changed(), and vfs and ioctl event buffering, this patch adds
check_events caching on top of the existing cdi->mc_flags buffering.

It may be a good idea to deprecate CDROM_MEDIA_CHANGED ioctl and
remove all this mess.

Signed-off-by: Tejun Heo 
Signed-off-by: Jens Axboe

drivers/cdrom: use pr_

2010-08-07T16:23:44+00:00

- add pr_fmt.

- convert printks to pr_

- add if (0) and printf argument checking to cdinfo

- coalesce consecutive printks to single pr_

- fix a typo "back ground" to "background"

- convert printks without level to pr_info

- remove VIOCD_ prefixes and use pr_fmt/pr_

- add a missing newline to an OS/400 message

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 

Folded in tab indentation fix from Andrew.

Signed-off-by: Jens Axboe

sysctl: Drop & in front of every proc_handler.

2009-11-18T16:37:40+00:00

For consistency drop & in front of every proc_handler.  Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.

Cc: Alexey Dobriyan 
Cc: Ingo Molnar 
Cc: Joe Perches 
Signed-off-by: Eric W. Biederman

sysctl drivers: Remove dead binary sysctl support

2009-11-12T10:04:58+00:00

Now that sys_sysctl is a wrapper around /proc/sys all of
the binary sysctl support elsewhere in the tree is
dead code.

Cc: Jens Axboe 
Cc: Corey Minyard 
Cc: Greg Kroah-Hartman 
Cc: Matt Mackall 
Cc: Herbert Xu 
Cc: Neil Brown 
Cc: "James E.J. Bottomley" 
Acked-by: Clemens Ladisch  for drivers/char/hpet.c
Signed-off-by: Eric W. Biederman

sysctl: remove "struct file *" argument of ->proc_handler

2009-09-24T14:21:04+00:00

It's unused.

It isn't needed -- read or write flag is already passed and sysctl
shouldn't care about the rest.

It _was_ used in two places at arch/frv for some reason.

Signed-off-by: Alexey Dobriyan 
Cc: David Howells 
Cc: "Eric W. Biederman" 
Cc: Al Viro 
Cc: Ralf Baechle 
Cc: Martin Schwidefsky 
Cc: Ingo Molnar 
Cc: "David S. Miller" 
Cc: James Morris 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

block: Use accessor functions for queue limits

2009-05-22T21:22:54+00:00

Convert all external users of queue limits to using wrapper functions
instead of poking the request queue variables directly.

Signed-off-by: Martin K. Petersen 
Signed-off-by: Jens Axboe