linux.git/drivers/cdrom/cdrom.c, branch v2.6.23

cdrom_open() forgets to unlock on -EROFS failure exits

2007-09-26T06:20:44+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jens Axboe

[BLOCK] Get rid of request_queue_t typedef

2007-07-24T07:28:11+00:00

Some of the code has been gradually transitioned to using the proper
struct request_queue, but there's lots left. So do a full sweet of
the kernel and get rid of this typedef and replace its uses with
the proper type.

Signed-off-by: Jens Axboe

bsg: add a request_queue argument to scsi_cmd_ioctl()

2007-07-16T06:52:45+00:00

bsg uses scsi_cmd_ioctl() for some SCSI/sg ioctl
commands. scsi_cmd_ioctl() gets a request queue from a gendisk
arguement. This prevents bsg being bound to SCSI devices that don't
have a gendisk (like OSD). This adds a request_queue argument to
scsi_cmd_ioctl(). The SCSI/sg ioctl commands doesn't use a gendisk so
it's safe for any SCSI devices to use scsi_cmd_ioctl().

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

[PATCH] cdrom_sysctl_info fix

2007-07-10T06:03:33+00:00

Fix the cdrom_sysctl_info possible buffer overwrite bug. Also
fix the locking of accessing topCdromPtr pointer.

Signed-off-by: Dave Young 
Signed-off-by: Jens Axboe

mm: remove destroy_dirty_buffers from invalidate_bdev()

2007-05-07T19:12:55+00:00

Remove the destroy_dirty_buffers argument from invalidate_bdev(), it hasn't
been used in 6 years (so akpm says).

find * -name \*.[ch] | xargs grep -l invalidate_bdev |
while read file; do
	quilt add $file;
	sed -ie 's/invalidate_bdev(\([^,]*\),[^)]*)/invalidate_bdev(\1)/g' $file;
done

Signed-off-by: Peter Zijlstra 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysctl: remove insert_at_head from register_sysctl

2007-02-14T16:09:59+00:00

The semantic effect of insert_at_head is that it would allow new registered
sysctl entries to override existing sysctl entries of the same name.  Which is
pain for caching and the proc interface never implemented.

I have done an audit and discovered that none of the current users of
register_sysctl care as (excpet for directories) they do not register
duplicate sysctl entries.

So this patch simply removes the support for overriding existing entries in
the sys_sysctl interface since no one uses it or cares and it makes future
enhancments harder.

Signed-off-by: Eric W. Biederman 
Acked-by: Ralf Baechle 
Acked-by: Martin Schwidefsky 
Cc: Russell King 
Cc: David Howells 
Cc: "Luck, Tony" 
Cc: Ralf Baechle 
Cc: Paul Mackerras 
Cc: Martin Schwidefsky 
Cc: Andi Kleen 
Cc: Jens Axboe 
Cc: Corey Minyard 
Cc: Neil Brown 
Cc: "John W. Linville" 
Cc: James Bottomley 
Cc: Jan Kara 
Cc: Trond Myklebust 
Cc: Mark Fasheh 
Cc: David Chinner 
Cc: "David S. Miller" 
Cc: Patrick McHardy 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysctl: cdrom: don't set de->owner

2007-02-14T16:09:56+00:00

There is no need for open files in /proc/sys/XXX to hold a reference count on
the module that provides the file to prevent module unload races.  While there
is code active in the module p->used in the sysctl_table_header is
incremented, preventing the sysctl from being unregisted.  Once the sysctl is
unregistered it cannot be found.  Open files are also not a problem as they
revalidate the sysctl information and bump p->used before accessing module
code.

So setting de->owner is unnecessary, makes for a bad example and gets in my
way of removing ctl_table->de.

Signed-off-by: Eric W. Biederman 
Acked-by: Jens Axboe 
Acked-by: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysctl: cdrom: remove unnecessary insert_at_head flag

2007-02-14T16:09:56+00:00

With unique binary sysctl numbers setting insert_at_head to override other
sysctl entries is pointless.

Signed-off-by: Eric W. Biederman 
Acked-by: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cdrom: set default timeout to 7 seconds

2007-01-04T01:32:54+00:00

It's a known fact that Windows times out commands after 7 seconds, so
drives generally try and respond if they can before that happens.  We
default to 5 seconds, which sometimes is a bit too short.

Jeremy Higdon reported here:

	http://lkml.org/lkml/2007/1/1/145

that his drive takes longer than 5 seconds for a "read track
information" command, later confirming that it is about 6.7 seconds.

So just do the sane thing and change the default command timeout to 7
seconds to avoid other surprises.

Signed-off-by: Jens Axboe 
Signed-off-by: Linus Torvalds

[PATCH] Fixup blk_rq_unmap_user() API

2006-12-19T10:12:46+00:00

The blk_rq_unmap_user() API is not very nice. It expects the caller to
know that rq->bio has to be reset to the original bio, and it will
silently do nothing if that is not done. Instead make it explicit that
we need to pass in the first bio, by expecting a bio argument.

Signed-off-by: Jens Axboe