linux.git/drivers/block, branch v3.7-rc4

loop: Make explicit loop device destruction lazy

2012-10-30T07:37:31+00:00

xfstests has always had random failures of tests due to loop devices
failing to be torn down and hence leaving filesytems that cannot be
unmounted. This causes test runs to immediately stop.

Over the past 6 or 7 years we've added hacks like explicit unmount
-d commands for loop mounts, losetup -d after unmount -d fails, etc,
but still the problems persist.  Recently, the frequency of loop
related failures increased again to the point that xfstests 259 will
reliably fail with a stray loop device that was not torn down.

That is despite the fact the test is above as simple as it gets -
loop 5 or 6 times running mkfs.xfs with different paramters:

        lofile=$(losetup -f)
        losetup $lofile "$testfile"
        "$MKFS_XFS_PROG" -b size=512 $lofile >/dev/null || echo "mkfs failed!"
        sync
        losetup -d $lofile

And losteup -d $lofile is failing with EBUSY on 1-3 of these loops
every time the test is run.

Turns out that blkid is running simultaneously with losetup -d, and
so it sees an elevated reference count and returns EBUSY.  But why
is blkid running? It's obvious, isn't it? udev has decided to try
and find out what is on the block device as a result of a creation
notification. And it is racing with mkfs, so might still be scanning
the device when mkfs finishes and we try to tear it down.

So, make losetup -d force autoremove behaviour. That is, when the
last reference goes away, tear down the device. xfstests wants it
*gone*, not causing random teardown failures when we know that all
the operations the tests have specifically run on the device have
completed and are no longer referencing the loop device.

Signed-off-by: Dave Chinner 
Signed-off-by: Jens Axboe

mtip32xx:Added appropriate timeout value for secure erase

2012-10-30T07:37:27+00:00

Added appropriate timeout value for secure erase based on identify device data

Signed-off-by: Asai Thambi S P 
Signed-off-by: Selvan Mani 
Signed-off-by: Jens Axboe

xen/blkback: Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool

2012-10-30T07:37:20+00:00

Changing the type of bdev parameters to be unsigned int :1, rather than bool.
This is more consistent with the types of other features in the block drivers.

Signed-off-by: Oliver Chick 
Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Jens Axboe

cciss: select CONFIG_CHECK_SIGNATURE

2012-10-30T07:37:00+00:00

The patch cciss-use-check_signature.patch in -mm tree introduced
a build error:

drivers/built-in.o: In function `CISS_signature_present':
drivers/block/cciss.c:4270: undefined reference to `check_signature'

Add missing CONFIG_CHECK_SIGNATURE to fix this issue.

Reported-by: Fengguang Wu 
Signed-off-by: Akinobu Mita 
Cc: Fengguang Wu 
Cc: Mike Miller 
Cc: Jens Axboe 
Acked-by: "Stephen M. Cameron" 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

cciss: remove unneeded memset()

2012-10-30T07:36:58+00:00

The memory return by kzalloc() or kmem_cache_zalloc() has already be set
to zero, so remove useless memset(0).

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun 
Cc: Mike Miller 
Cc: Jens Axboe 
Cc: Stephen M. Cameron 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

xen/blkback: use kmem_cache_zalloc instead of kmem_cache_alloc/memset

2012-10-30T07:36:27+00:00

Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun 
Signed-off-by: Konrad Rzeszutek Wilk

floppy: remove dr, reuse drive on do_floppy_init

2012-10-30T07:36:07+00:00

This is a small cleanup, that also may turn error handling of
unitialized disks more readable. We don't need a separate variable to
track allocated disks, remove dr and reuse drive variable instead.

Signed-off-by: Herton Ronaldo Krzesinski 
Signed-off-by: Jiri Kosina 
Signed-off-by: Jens Axboe

floppy: use common function to check if floppies can be registered

2012-10-30T07:34:25+00:00

The same checks to see if a drive can be or is registered are
repeated through the code, factor out the checks in a common function
and replace the repeated checks with it.

Signed-off-by: Herton Ronaldo Krzesinski 
Signed-off-by: Jiri Kosina 
Signed-off-by: Jens Axboe

floppy: properly handle failure on add_disk loop

2012-10-30T07:34:25+00:00

On floppy initialization, if something failed inside the loop we call
add_disk, there was no cleanup of previous iterations in the error
handling.

Cc: stable@vger.kernel.org
Signed-off-by: Herton Ronaldo Krzesinski 
Signed-off-by: Jiri Kosina 
Signed-off-by: Jens Axboe

floppy: do put_disk on current dr if blk_init_queue fails

2012-10-30T07:34:25+00:00

If blk_init_queue fails, we do not call put_disk on the current dr
(dr is decremented first in the error handling loop).

Cc: stable@vger.kernel.org
Reviewed-by: Ben Hutchings 
Signed-off-by: Herton Ronaldo Krzesinski 
Signed-off-by: Jiri Kosina 
Signed-off-by: Jens Axboe