linux.git/drivers/block/ub.c, branch v2.6.25

ub: remove BUG() after __blk_end_request and fix the condition causing it

2008-04-09T01:25:52+00:00

When __blk_end_request returns nonzero, it means that the request was
not completely processed and some BIOs are still attached. Since we
have dequeued it by that time, it means leaking requests and hanging
processes, which is why BUG() was in there. In ub this happens if
a packet request ends normally, but with residue (e.g. when scsi_id
issues INQUIRY).

The fix is to make sure that arguments passed to __blk_end_request
are correct: the full request length and not just transferred length.
The transferred length is indicated to applications by adjusting
rq->data_len with old, unchanged code outside of this patch.

Signed-off-by: Pete Zaitcev 
Cc: Kiyoshi Ueda 
Cc: Greg KH 
Cc: Boaz Harrosh 
Cc: Martin Schwidefsky 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ub: fix up the conversion to sg_init_table()

2008-02-09T19:08:33+00:00

Signed-off-by: Pete Zaitcev 
Cc: "Oliver Pinter" 
Cc: FUJITA Tomonori 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

USB: Remove unnecessary zeroing from ub

2008-02-01T22:34:47+00:00

These zeroings were taken from usb-storage long time ago. I examined
the submission paths and usb_fill_bulk_urb and found them unnecessary.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

blk_end_request: changing ub (take 4)

2008-01-28T09:37:17+00:00

This patch converts ub to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.

Cc: Pete Zaitcev 
Signed-off-by: Kiyoshi Ueda 
Signed-off-by: Jun'ichi Nomura 
Signed-off-by: Jens Axboe

ub: add sg_init_table for sense and read capacity commands

2007-10-25T07:17:03+00:00

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

SG: Change sg_set_page() to take length and offset argument

2007-10-24T09:20:47+00:00

Most drivers need to set length and offset as well, so may as well fold
those three lines into one.

Add sg_assign_page() for those two locations that only needed to set
the page, where the offset/length is set outside of the function context.

Signed-off-by: Jens Axboe

[SG] Update drivers to use sg helpers

2007-10-22T19:19:53+00:00

Signed-off-by: Jens Axboe

[BLOCK] Get rid of request_queue_t typedef

2007-07-24T07:28:11+00:00

Some of the code has been gradually transitioned to using the proper
struct request_queue, but there's lots left. So do a full sweet of
the kernel and get rid of this typedef and replace its uses with
the proper type.

Signed-off-by: Jens Axboe

bsg: add a request_queue argument to scsi_cmd_ioctl()

2007-07-16T06:52:45+00:00

bsg uses scsi_cmd_ioctl() for some SCSI/sg ioctl
commands. scsi_cmd_ioctl() gets a request queue from a gendisk
arguement. This prevents bsg being bound to SCSI devices that don't
have a gendisk (like OSD). This adds a request_queue argument to
scsi_cmd_ioctl(). The SCSI/sg ioctl commands doesn't use a gendisk so
it's safe for any SCSI devices to use scsi_cmd_ioctl().

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

USB: drivers/block/ub.c: use list_for_each_entry()

2007-07-12T23:34:40+00:00

Low performance USB storage driver: Use list_for_each_entry() instead
of list_for_each()

Signed-off-by: Matthias Kaehlcke 
Cc: Pete Zaitcev 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman