linux.git/drivers/base/property.c, branch v4.5-rc2

device property: avoid allocations of 0 length

2016-01-01T01:09:51+00:00

Arrays can not have zero elements by definition of the unified device
properties. If such property comes from outside we should not allow it to pass.
Otherwise memory allocation on 0 length will return non-NULL value, which we
currently don't check.

Prevent memory allocations of 0 length.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: the secondary fwnode needs to depend on the primary

2016-01-01T01:09:51+00:00

This fixes NULL pointer dereference when the primary fwnode handle
does not exist, for example with PCI devices that do not have ACPI
companion.

Signed-off-by: Heikki Krogerus 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: Take a copy of the property set

2015-12-07T01:29:23+00:00

It is convenient if the property set associated with the device secondary
firmware node is a copy of the original. This allows passing property set
from a stack for example for devices created dynamically. This also ties
the property set lifetime to the associated device.

Because of that we provide new function device_remove_property_set() that
is used to disassociate and release memory allocated for the property set.

Signed-off-by: Mika Westerberg 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: Fallback to secondary fwnode if primary misses the property

2015-12-07T01:29:23+00:00

The struct fwnode has notion of secondary fwnode. This is supposed to used
as fallback if the primary firmware interface (DT, ACPI) does not have the
property in question.

However, the current implementation never checks the secondary node which
prevents one to add default "built-in" properties to devices.

This patch adds fallback to the secondary fwnode if the primary fwnode
returns that the property does not exists.

Signed-off-by: Mika Westerberg 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: improve readability of macros

2015-12-07T01:29:23+00:00

There is no functional change.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: keep single value inplace

2015-12-07T01:29:22+00:00

We may save a lot of lines of code and space by keeping single values inside
the struct property_entry. Refactor the implementation to do so.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: refactor built-in properties support

2015-12-07T01:29:22+00:00

Instead of using the type and nval fields we will use length (in bytes) of the
value. The sanity check is done in the accessors.

The built-in property accessors are split in the same way such as device tree.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: rename helper functions

2015-12-07T01:29:22+00:00

To be in align with the rest of fwnode types we rename the built-in property
set ones, i.e.
	is_pset() -> is_pset_node()
	to_pset() -> to_pset_node()

There is no functional change.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: always check for fwnode type

2015-12-07T01:29:22+00:00

Currently the property accessors unconditionally fall back to built-in property
set as a last resort. Make this strict and return an error in case the type of
fwnode is unknown.

This is actually a follow up to the commit 4fa7508e9f1c (device property:
Return -ENXIO if there is no suitable FW interface).

Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

device property: ACPI: Remove unused DMA APIs

2015-11-07T00:29:22+00:00

These DMA APIs are replaced with the newer versions, which return
the enum dev_dma_attr. So, we can safely remove them.

Signed-off-by: Suravee Suthikulpanit 
Acked-by: Bjorn Helgaas 
Reviewed-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki