linux.git/drivers/base/power/opp.c, branch v3.19

PM / OPP: take RCU lock in dev_pm_opp_get_opp_count

2014-12-18T00:42:49+00:00

A lot of callers are missing the fact that dev_pm_opp_get_opp_count
needs to be called under RCU lock. Given that RCU locks can safely be
nested, instead of providing *_locked() API, let's take RCU lock inside
dev_pm_opp_get_opp_count() and leave callers as is.

Signed-off-by: Dmitry Torokhov 
Acked-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: fix warning in of_free_opp_table()

2014-12-18T00:42:49+00:00

Not having OPP defined for a device is not a crime, we should not splat
warning in this case. Also, it seems that we are ready to accept invalid
dev (find_device_opp will return ERR_PTR(-EINVAL) then) so let's not
crash in dev_name() in such case.

Signed-off-by: Dmitry Torokhov 
Acked-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: add some lockdep annotations

2014-12-18T00:42:49+00:00

Certain OPP APIs need to be called under RCU lock; let's add a few
rcu_lockdep_assert() calls to warn about potential misuse.

Signed-off-by: Dmitry Torokhov 
Acked-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: do error handling at the bottom of dev_pm_opp_add_dynamic()

2014-12-10T21:18:34+00:00

This makes it less error prone and moves common resource deallocation at a
single place.

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: handle allocation of device_opp in a separate routine

2014-12-10T21:18:34+00:00

Get the 'device_opp' allocation code into a separate routine to keep only the
necessary part in dev_pm_opp_add_dynamic().

Also do s/sizeof(struct device_opp)/sizeof(*dev_opp) and remove the print
message on kzalloc() failure as checkpatch warns for that.

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: reuse find_device_opp() instead of duplicating code

2014-12-10T21:18:34+00:00

Reuse find_device_opp() in opp_set_availability() instead of duplicating code.

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: Staticize __dev_pm_opp_remove()

2014-12-10T21:18:34+00:00

Its a local routine and need not be accessible outside of opp.c.

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: replace kfree with kfree_rcu while freeing 'struct device_opp'

2014-12-10T21:18:33+00:00

Somehow one of the instance of freeing resources failed to use kfree_rcu() and
used kfree() instead. This might cause problems as the node might be referenced
by readers under rcu locks and we must wait for the rcu grace period as well.

While we are at it, also update comment over 'struct device_opp' to mention why
we are waiting for both rcu and srcu grace periods.

Fixes: 129eec55df6a (PM / OPP Introduce APIs to remove OPPs)
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: remove double calls to find_device_opp()

2014-12-10T01:39:12+00:00

By mistake we called find_device_opp() twice in of_free_opp_table(), fix it.

Generated diff doesn't show the problem well and so here is the code snippet:

void of_free_opp_table(struct device *dev)
{
	struct device_opp *dev_opp = find_device_opp(dev);
	struct dev_pm_opp *opp, *tmp;

	/* Check for existing list for 'dev' */
	dev_opp = find_device_opp(dev);

	...
}

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

PM / OPP: set new_opp->dev_opp to a valid dev_opp

2014-12-10T01:32:51+00:00

We find/allocate dev_opp after using its value to fill new_opp->dev_opp right
now. Move this to a later point where dev_opp is valid.

Fixes: a7470db6fec4 (PM / OPP don't match for existing OPPs when list is empty)
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki