linux.git/drivers/base/driver.c, branch v2.6.29

Revert "driver core: move knode_driver into private structure"

2009-01-09T22:44:18+00:00

This reverts commit 93e746db183b3bdbbda67900f79b5835f9cb388f.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: move knode_driver into private structure

2009-01-06T18:44:32+00:00

Nothing outside of the driver core should ever touch knode_driver, so
move it out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

drivers/base/driver.c: remove unused to_dev() macro

2008-08-21T17:15:35+00:00

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

driver core: warn about duplicate driver names on the same bus

2008-04-30T23:52:47+00:00

Currently an attempt to register multiple
drivers with the same name causes the
stack trace with some cryptic error message.
The attached patch adds the necessary check
and the clear error message.

Signed-off-by: Stas Sergeev 
Signed-off-by: Greg Kroah-Hartman

driver core: fix small mem leak in driver_add_kobj()

2008-03-28T21:45:23+00:00

The Coverity checker spotted that we leak the storage allocated to 'name' in
int driver_add_kobj().  The leak looks legit to me - this is the code :

int driver_add_kobj(struct device_driver *drv, struct kobject *kobj,
                    const char *fmt, ...)
{
        va_list args;
        char *name;
        int ret;

        va_start(args, fmt);
        name = kvasprintf(GFP_KERNEL, fmt, args);
        ^^^^^^^^ This dynamically allocates space...

        va_end(args);

        if (!name)
                return -ENOMEM;

        return kobject_add(kobj, &drv->p->kobj, "%s", name);
	^^^^^^^^ This neglects to free the space allocated
}

Inside kobject_add() a copy of 'name' will be made and used.  As far as I can
see, Coverity is correct in flagging this as a leak, but I'd like some
configmation before the patch is applied.

This should fix it.

Signed-off-by: Jesper Juhl 
Cc: Greg KH 
Cc: Kay Sievers 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

driver-core: fix kernel-doc function parameters

2008-02-21T23:27:07+00:00

Fix drivers/base/ missing kernel-doc parameters:
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'drv'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'kobj'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'fmt'
Warning(linux-2.6.24-git12//drivers/base/power/main.c:530): No description found for parameter 'state'

Signed-off-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman

Driver core: Remove unneeded get_{device,driver}() calls.

2008-02-02T23:14:49+00:00

Driver core: Remove unneeded get_{device,driver}() calls.

Code trying to add/remove attributes must hold a reference to
the device resp. driver anyway, so let's remove those reference
count games.

Signed-off-by: Cornelia Huck 
Cc: Dave Young 
Signed-off-by: Greg Kroah-Hartman

Driver core: coding style fixes

2008-01-25T06:50:12+00:00

Fix up a number of coding style issues in the drivers/base/ directory
that have annoyed me over the years.  checkpatch.pl is now very happy.

Signed-off-by: Greg Kroah-Hartman

Kobject: rename kobject_add_ng() to kobject_add()

2008-01-25T04:40:38+00:00

Now that the old kobject_add() function is gone, rename kobject_add_ng()
to kobject_add() to clean up the namespace.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Driver core: move the static kobject out of struct driver

2008-01-25T04:40:35+00:00

This patch removes the kobject, and a few other driver-core-only fields
out of struct driver and into the driver core only.  Now drivers can be
safely create on the stack or statically (like they currently are.)

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman