linux.git/drivers/base/dd.c, branch v5.7-rc2

driver core: Replace open-coded list_last_entry()

2020-03-24T12:33:26+00:00

There is a place in the code where open-coded version of list entry accessors
list_last_entry() is used.

Replace that with the standard macro.

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20200324122023.9649-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

driver core: Read atomic counter once in driver_probe_done()

2020-03-24T12:33:25+00:00

Between printing the debug message and actual check atomic counter can be
altered. For better debugging experience read atomic counter value only once.

Signed-off-by: Andy Shevchenko 
Tested-by: Ferry Toth 
Link: https://lore.kernel.org/r/20200324122023.9649-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

driver core: Rename deferred_probe_timeout and make it global

2020-03-04T17:11:44+00:00

Since other subsystems (like regulator) have similar arbitrary
timeouts for how long they try to resolve driver dependencies,
rename deferred_probe_timeout to driver_deferred_probe_timeout
and set it as global, so it can be shared.

Cc: linux-pm@vger.kernel.org
Cc: Greg Kroah-Hartman 
Cc: Linus Walleij 
Cc: Thierry Reding 
Cc: Mark Brown 
Cc: Liam Girdwood 
Cc: Bjorn Andersson 
Cc: Saravana Kannan 
Cc: Todd Kjos 
Cc: Len Brown 
Cc: Pavel Machek 
Cc: Ulf Hansson 
Cc: Kevin Hilman 
Cc: "Rafael J. Wysocki" 
Cc: Rob Herring 
Reviewed-by: Bjorn Andersson 
Reviewed-by: Rafael J. Wysocki 
Signed-off-by: John Stultz 
Link: https://lore.kernel.org/r/20200225050828.56458-6-john.stultz@linaro.org
Signed-off-by: Greg Kroah-Hartman

driver core: Remove driver_deferred_probe_check_state_continue()

2020-03-04T17:11:44+00:00

Now that driver_deferred_probe_check_state() works better, and
we've converted the only user of
driver_deferred_probe_check_state_continue() we can simply
remove it and simplify some of the logic.

Cc: linux-pm@vger.kernel.org
Cc: Greg Kroah-Hartman 
Cc: Linus Walleij 
Cc: Thierry Reding 
Cc: Mark Brown 
Cc: Liam Girdwood 
Cc: Bjorn Andersson 
Cc: Saravana Kannan 
Cc: Todd Kjos 
Cc: Len Brown 
Cc: Pavel Machek 
Cc: Ulf Hansson 
Cc: Kevin Hilman 
Cc: "Rafael J. Wysocki" 
Cc: Rob Herring 
Reviewed-by: Bjorn Andersson 
Reviewed-by: Rafael J. Wysocki 
Signed-off-by: John Stultz 
Link: https://lore.kernel.org/r/20200225050828.56458-5-john.stultz@linaro.org
Signed-off-by: Greg Kroah-Hartman

driver core: Set deferred_probe_timeout to a longer default if CONFIG_MODULES is set

2020-03-04T17:11:44+00:00

When using modules, its common for the modules not to be loaded
until quite late by userland. With the current code,
driver_deferred_probe_check_state() will stop returning
EPROBE_DEFER after late_initcall, which can cause module
dependency resolution to fail after that.

So allow a longer window of 30 seconds (picked somewhat
arbitrarily, but influenced by the similar regulator core
timeout value) in the case where modules are enabled.

Cc: linux-pm@vger.kernel.org
Cc: Greg Kroah-Hartman 
Cc: Linus Walleij 
Cc: Thierry Reding 
Cc: Mark Brown 
Cc: Liam Girdwood 
Cc: Bjorn Andersson 
Cc: Saravana Kannan 
Cc: Todd Kjos 
Cc: Len Brown 
Cc: Pavel Machek 
Cc: Ulf Hansson 
Cc: Kevin Hilman 
Cc: "Rafael J. Wysocki" 
Cc: Rob Herring 
Reviewed-by: Bjorn Andersson 
Reviewed-by: Rafael J. Wysocki 
Signed-off-by: John Stultz 
Link: https://lore.kernel.org/r/20200225050828.56458-3-john.stultz@linaro.org
Signed-off-by: Greg Kroah-Hartman

driver core: Fix driver_deferred_probe_check_state() logic

2020-03-04T17:11:44+00:00

driver_deferred_probe_check_state() has some uninituitive behavior.

* From boot to late_initcall, it returns -EPROBE_DEFER

* From late_initcall to the deferred_probe_timeout (if set)
  it returns -ENODEV

* If the deferred_probe_timeout it set, after it fires, it
  returns -ETIMEDOUT

This is a bit confusing, as its useful to have the function
return -EPROBE_DEFER while the timeout is still running. This
behavior has resulted in the somwhat duplicative
driver_deferred_probe_check_state_continue() function being
added.

Thus this patch tries to improve the logic, so that it behaves
as such:

* If late_initcall has passed, and modules are not enabled
  it returns -ENODEV

* If modules are enabled and deferred_probe_timeout is set,
  it returns -EPROBE_DEFER until the timeout, afterwhich it
  returns -ETIMEDOUT.

* In all other cases, it returns -EPROBE_DEFER

This will make the deferred_probe_timeout value much more
functional, and will allow us to consolidate the
driver_deferred_probe_check_state() and
driver_deferred_probe_check_state_continue() logic in a later
patch.

Cc: linux-pm@vger.kernel.org
Cc: Greg Kroah-Hartman 
Cc: Linus Walleij 
Cc: Thierry Reding 
Cc: Mark Brown 
Cc: Liam Girdwood 
Cc: Bjorn Andersson 
Cc: Saravana Kannan 
Cc: Todd Kjos 
Cc: Len Brown 
Cc: Pavel Machek 
Cc: Ulf Hansson 
Cc: Kevin Hilman 
Cc: "Rafael J. Wysocki" 
Cc: Rob Herring 
Signed-off-by: John Stultz 
Link: https://lore.kernel.org/r/20200225050828.56458-2-john.stultz@linaro.org
Signed-off-by: Greg Kroah-Hartman

driver core: Print device when resources present in really_probe()

2020-01-14T15:14:48+00:00

If a device already has devres items attached before probing, a warning
backtrace is printed.  However, this backtrace does not reveal the
offending device, leaving the user uninformed.  Furthermore, using
WARN_ON() causes systems with panic-on-warn to reboot.

Fix this by replacing the WARN_ON() by a dev_crit() message.
Abort probing the device, to prevent doing more damage to the device's
resources.

Signed-off-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/r/20191206132219.28908-1-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: Add edit_links() callback for drivers"

2019-08-27T19:41:06+00:00

This reverts commit 134b23eec9e3a3c795a6ceb0efe2fa63e87983b2.

Based on a lot of email and in-person discussions, this patch series is
being reworked to address a number of issues that were pointed out that
needed to be taken care of before it should be merged.  It will be
resubmitted with those changes hopefully soon.

Cc: Frank Rowand 
Cc: Saravana Kannan 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'dev_groups_all_drivers' into driver-core-next

2019-08-02T10:47:05+00:00

dev_groups added to struct driver

Persistent tag for others to pull this branch from

This is the first patch in a longer series that adds the ability for the
driver core to create and remove a list of attribute groups
automatically when the device is bound/unbound from a specific driver.

See:
	https://lore.kernel.org/r/20190731124349.4474-2-gregkh@linuxfoundation.org
for details on this patch, and examples of how to use it in other
drivers.

Signed-off-by: Greg Kroah-Hartman

driver core: add dev_groups to all drivers

2019-08-02T10:37:53+00:00

Add the ability for the driver core to create and remove a list of
attribute groups automatically when the device is bound/unbound from a
specific driver.

Signed-off-by: Dmitry Torokhov 
Tested-by: Richard Gong 
Link: https://lore.kernel.org/r/20190731124349.4474-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman