linux.git/drivers/base/core.c, branch v2.6.14

[PATCH] fix klist semantics for lists which have elements removed on traversal

2005-09-08T01:26:54+00:00

The problem is that klists claim to provide semantics for safe traversal of
lists which are being modified.  The failure case is when traversal of a
list causes element removal (a fairly common case).  The issue is that
although the list node is refcounted, if it is embedded in an object (which
is universally the case), then the object will be freed regardless of the
klist refcount leading to slab corruption because the klist iterator refers
to the prior element to get the next.

The solution is to make the klist take and release references to the
embedding object meaning that the embedding object won't be released until
the list relinquishes the reference to it.

(akpm: fast-track this because it's needed for the 2.6.13 scsi merge)

Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] klist: fix klist to have the same klist_add semantics as list_head

2005-09-05T23:03:13+00:00

at the moment, the list_head semantics are

list_add(node, head)

whereas current klist semantics are

klist_add(head, node)

This is bound to cause confusion, and since klist is the newcomer, it
should follow the list_head semantics.

I also added missing include guards to klist.h

Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Driver core: Use klist_del() instead of klist_remove().

2005-06-30T05:48:05+00:00

Use klist_del() instead of klist_remove() when unregistering devices.
This will prevent a deadlock when executing a recursive unregister using
device_for_each_child().

Signed-off-by Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Driver core: change device_attribute callbacks

2005-06-20T22:15:31+00:00

This patch adds the device_attribute paramerter to the
device_attribute store and show sysfs callback functions, and passes a
reference to the attribute when the callbacks are called.

Signed-off-by: Yani Ioannou 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Use a klist for device child lists.

2005-06-20T22:15:23+00:00

- Use klist iterator in device_for_each_child(), making it safe to use for
  removing devices.
- Remove unused list_to_dev() function.
- Kills all usage of devices_subsys.rwsem.

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Remove struct device::driver_list.

2005-06-20T22:15:18+00:00

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Remove struct device::bus_list.

2005-06-20T22:15:18+00:00

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Remove the unused device_find().

2005-06-20T22:15:16+00:00

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Add a klist to struct device_driver for the devices bound to it.

2005-06-20T22:15:16+00:00

- Use it in driver_for_each_device() instead of the regular list_head and stop using
  the bus's rwsem for protection.
- Use driver_for_each_device() in driver_detach() so we don't deadlock on the
  bus's rwsem.
- Remove ->devices.
- Move klist access and sysfs link access out from under device's semaphore, since
  they're synchronized through other means.

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman

[PATCH] Add a semaphore to struct device to synchronize calls to its driver.

2005-06-20T22:15:12+00:00

This adds a per-device semaphore that is taken before every call from the core to a
driver method. This prevents e.g. simultaneous calls to the ->suspend() or ->resume()
and ->probe() or ->release(), potentially saving a whole lot of headaches.

It also moves us a step closer to removing the bus rwsem, since it protects the fields
in struct device that are modified by the core.

Signed-off-by: Patrick Mochel 
Signed-off-by: Greg Kroah-Hartman