linux.git/drivers/auxdisplay, branch v5.2-rc4

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 3029 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman

auxdisplay: charlcd: make backlight initial state configurable

2019-03-17T07:48:45+00:00

The charlcd driver currently flashes the backlight once on init.
This may not be desirable.  Thus, add options for turning the
backlight off or on as well.

Signed-off-by: Mans Rullgard 
Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: simplify init message display

2019-03-17T07:48:39+00:00

If CONFIG_PANEL_CHANGE_MESSAGE is set, CONFIG_PANEL_BOOT_MESSAGE will
also be defined, so the double ifdef is pointless.  Simplify the code
further by using an intermediate macro rather duplicating most of the
line.

Signed-off-by: Mans Rullgard 
Signed-off-by: Miguel Ojeda

auxdisplay: deconfuse configuration

2019-03-17T07:48:33+00:00

The auxdisplay Kconfig is confusing.  It creates two separate menus
even though the settings are closely related.  Moreover, the options
for setting the boot message depend on CONFIG_PARPORT even though they
are used by drivers that do not.

Clear up the confusion by moving the "Parallel port LCD/Keypad" menu
under auxdisplay where it logically belongs.  Change the boot message
options to depend only on CONFIG_CHARLCD, making them accessible also
when only the HD44780 is selected.

Since the "Parallel port LCD/Keypad" driver now has a new dependency
on CONFIG_AUXDISPLAY, rename its Kconfig symbol and keep the old one
such that make oldconfig will not disable the driver.

Signed-off-by: Mans Rullgard 
Signed-off-by: Miguel Ojeda

auxdisplay: hd44780: Convert to use charlcd_free()

2019-03-17T07:48:28+00:00

Convert to use charlcd_free() instead of kfree() for sake of type check.

Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: panel: Convert to use charlcd_free()

2019-03-17T07:48:22+00:00

Convert to use charlcd_free() instead of kfree() for sake of type check.

Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Introduce charlcd_free() helper

2019-03-17T07:48:16+00:00

The charlcd_free() is a counterpart to charlcd_alloc()
and should be called symmetrically on tear down.

Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Move to_priv() to charlcd namespace

2019-03-17T07:48:10+00:00

In order to be more particular in names, rename to_priv() macro
to charlcd_to_priv().

No functional change intended.

Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: hd44780: Fix memory leak on ->remove()

2019-03-17T07:48:04+00:00

We have to free on ->remove() the allocated resources on ->probe().

Fixes: d47d88361fee ("auxdisplay: Add HD44780 Character LCD support")
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: ht16k33: fix potential user-after-free on module unload

2019-02-15T18:48:39+00:00

On module unload/remove, we need to ensure that work does not run
after we have freed resources. Concretely, cancel_delayed_work()
may return while the callback function is still running.

From kernel/workqueue.c:

    The work callback function may still be running on return,
    unless it returns true and the work doesn't re-arm itself.
    Explicitly flush or use cancel_delayed_work_sync() to wait on it.

Link: https://lore.kernel.org/lkml/20190204220952.30761-1-TheSven73@googlemail.com/
Reported-by: Sven Van Asbroeck 
Reviewed-by: Dmitry Torokhov 
Reviewed-by: Sven Van Asbroeck 
Acked-by: Robin van der Gracht 
Signed-off-by: Miguel Ojeda