linux.git/drivers/atm, branch v3.8-rc2 Linux kernel source tree solos-pci: double lock in geos_gpio_store() 2012-12-21T21:14:00+00:00 Dan Carpenter dan.carpenter@oracle.com 2012-12-19T21:48:45+00:00 29042073e7af55334ac3c4f2a8340263200c5749 There is a typo here so we do a double lock instead of an unlock. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
There is a typo here so we do a double lock instead of an unlock.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: ensure all TX packets are aligned to 4 bytes 2012-12-19T22:53:53+00:00 David Woodhouse David.Woodhouse@intel.com 2012-12-19T11:01:21+00:00 152a2a8b5e1d4cbe91a7c66f1028db15164a3766 The FPGA can't handled unaligned DMA (yet). So copy into an aligned buffer, if skb->data isn't suitably aligned. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The FPGA can't handled unaligned DMA (yet). So copy into an aligned buffer,
if skb->data isn't suitably aligned.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: add firmware upgrade support for new models 2012-12-19T22:53:53+00:00 Nathan Williams nathan@traverse.com.au 2012-12-19T11:01:20+00:00 13af816469db3449c072afbae6c4c1bd9ccecccb Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Nathan Williams <nathan@traverse.com.au>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: remove superfluous debug output 2012-12-19T22:53:53+00:00 Nathan Williams nathan@traverse.com.au 2012-12-19T11:01:19+00:00 7fbdadb5e951e4f0c0fc991ff5f50295568786e6 Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Nathan Williams <nathan@traverse.com.au>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: add GPIO support for newer versions on Geos board 2012-12-19T22:53:53+00:00 Nathan Williams nathan@traverse.com.au 2012-12-19T11:01:18+00:00 f9baad02e7411d9f38d5ebe1a1cdcde4ceec100d dwmw2: Tidy up a little, simpler matching on which GPIO is being accessed, only register on newer boards, register under PCI device instead of duplicating them under each ATM device. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
dwmw2: Tidy up a little, simpler matching on which GPIO is being accessed,
       only register on newer boards, register under PCI device instead of
       duplicating them under each ATM device.

Signed-off-by: Nathan Williams <nathan@traverse.com.au>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: fix double-free of TX skb in DMA mode 2012-12-12T05:16:47+00:00 David Woodhouse dwmw2@infradead.org 2012-12-11T14:57:14+00:00 cae49ede00ec3d0cda290b03fee55b72b49efc11 We weren't clearing card->tx_skb[port] when processing the TX done interrupt. If there wasn't another skb ready to transmit immediately, this led to a double-free because we'd free it *again* next time we did have a packet to send. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> Cc: stable@kernel.org Signed-off-by: David S. Miller <davem@davemloft.net> 
We weren't clearing card->tx_skb[port] when processing the TX done interrupt.
If there wasn't another skb ready to transmit immediately, this led to a
double-free because we'd free it *again* next time we did have a packet to
send.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge git://git.infradead.org/users/dwmw2/atm 2012-12-02T01:45:24+00:00 David S. Miller davem@davemloft.net 2012-12-02T01:45:24+00:00 ddb303301bed80f700db6f36870642a08016f266 David Woodhouse says: ==================== This is the result of pulling on the thread started by Krzysztof Mazur's original patch 'pppoatm: don't send frames to destroyed vcc'. Various problems in the pppoatm and br2684 code are solved, some of which were easily triggered and would panic the kernel. ==================== Signed-off-by: David S. Miller <davem@davemloft.net> 
David Woodhouse says:

====================
This is the result of pulling on the thread started by Krzysztof Mazur's
original patch 'pppoatm: don't send frames to destroyed vcc'.

Various problems in the pppoatm and br2684 code are solved, some of which
were easily triggered and would panic the kernel.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
solos-pci: remove list_vccs() debugging function 2012-12-02T00:06:18+00:00 David Woodhouse David.Woodhouse@intel.com 2012-11-29T23:28:30+00:00 c48d49aab0b5b48b40e00fe43927efed5fc09d88 No idea why we've gone so long dumping a list of VCCs with vci==0 on every ->open() call... Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
No idea why we've gone so long dumping a list of VCCs with vci==0 on
every ->open() call...

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
solos-pci: use GFP_KERNEL where possible, not GFP_ATOMIC 2012-12-02T00:06:17+00:00 David Woodhouse David.Woodhouse@intel.com 2012-11-29T23:27:20+00:00 a1db5c5b75d6781e8e4dcd6621d5c10463bee0ef Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
solos-pci: clean up pclose() function 2012-12-02T00:06:03+00:00 David Woodhouse David.Woodhouse@intel.com 2012-11-29T23:15:30+00:00 213e85d389124f49c82d52cfb4473b8bb672f7c1 - Flush pending TX skbs from the queue rather than waiting for them all to complete (suggested by Krzysztof Mazur <krzysiek@podlesie.net>). - Clear ATM_VF_ADDR only when the PKT_PCLOSE packet has been submitted. - Don't clear ATM_VF_READY at all — vcc_destroy_socket() does that for us. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com> 
 - Flush pending TX skbs from the queue rather than waiting for them all to
   complete (suggested by Krzysztof Mazur <krzysiek@podlesie.net>).
 - Clear ATM_VF_ADDR only when the PKT_PCLOSE packet has been submitted.
 - Don't clear ATM_VF_READY at all — vcc_destroy_socket() does that for us.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>