linux.git/drivers/atm/he.c, branch v4.9 Linux kernel source tree ATM-ForeRunnerHE: Use kmalloc_array() in he_init_group() 2016-09-10T02:27:32+00:00 Markus Elfring elfring@users.sourceforge.net 2016-09-08T13:43:37+00:00 2c4f414f0290e019d463f1f7f447807fd6a6470c * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net> 
* Multiplications for the size determination of memory allocations
  indicated that array data structures should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of data types by pointer dereferences
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: he: drop null test before destroy functions 2015-09-15T23:49:43+00:00 Julia Lawall julia.lawall@lip6.fr 2015-09-13T12:15:03+00:00 58d29e3ce903dcafacee9e355225d64922325cf0 Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net> 
Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm:he - Do not initialise statics to 0. 2015-06-04T22:43:10+00:00 Shailendra Verma shailendra.capricorn@gmail.com 2015-06-04T14:41:00+00:00 ffaa31d7945f14edb04d7b2792a1dbd3a854a2bc According to <stdbool.h> false is always '0' and Static variables are initialised to 0 by GCC. Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
According to <stdbool.h> false is always '0' and
Static variables are initialised to 0 by GCC.

Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm:he - Change 1 to true for bool type variable. 2015-05-25T20:34:35+00:00 Shailendra Verma shailendra.capricorn@gmail.com 2015-05-25T19:47:23+00:00 376cd36dc7b68ec7f7de1428fa055ce706a33bbf The variable irq_coalesce is bool type. So assign the value true instead of 1. Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The variable irq_coalesce is bool type.
So assign the value true instead of 1.

Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: remove deprecated use of pci api 2015-01-18T05:28:41+00:00 chas williams - CONTRACTOR chas@cmf.nrl.navy.mil 2015-01-16T13:57:21+00:00 ede58ef28e105de94475b2b69fa069c9a2ce6933 Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: use pci_zalloc_consistent 2014-08-08T22:57:28+00:00 Joe Perches joe@perches.com 2014-08-08T21:24:10+00:00 6f2a011afc324260d8e5e2aa480a58c34283c581 Remove the now unnecessary memset too. Signed-off-by: Joe Perches <joe@perches.com> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Remove the now unnecessary memset too.

Signed-off-by: Joe Perches <joe@perches.com>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
atm: he: remove unnecessary pci_set_drvdata() 2013-12-11T03:31:32+00:00 Jingoo Han jg1.han@samsung.com 2013-12-10T03:51:46+00:00 57c5bca9f4f8d0be378a115c5ed939bd43932f8e The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/he.c: convert to module_pci_driver 2013-09-14T00:02:50+00:00 Libo Chen clbchenlibo.chen@huawei.com 2013-09-13T21:52:03+00:00 a2a69f0b35762410c4194f9827354310f68470be Signed-off-by: Libo Chen <libo.chen@huawei.com> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Libo Chen <libo.chen@huawei.com>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: he: print MAC via %pM 2013-09-04T18:41:55+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2013-09-03T12:17:56+00:00 f8de31040d50b7e4c26a5ca4c02b2929dde34a58 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
atm: he: use mdelay instead of large udelay constants 2013-04-29T17:26:48+00:00 Arnd Bergmann arnd@arndb.de 2013-03-14T14:21:36+00:00 f0911aaea991342ca8346dbcfec3b7575ab22cba ARM cannot handle udelay for more than 2 miliseconds, and it is rather bad style to block the cpu for 16ms anyway, so let's use msleep instead. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller <davem@davemloft.net> 
ARM cannot handle udelay for more than 2 miliseconds, and
it is rather bad style to block the cpu for 16ms anyway,
so let's use msleep instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Cc: linux-atm-general@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>