linux.git/drivers/atm/firestream.c, branch v2.6.29

[ATM] firestream: Fix uninitialized var warning.

2008-03-28T23:19:26+00:00

All code paths set tmc0 in some way, but GCC can't
see that for some reason.  Explicitly initialize
to zero.

Signed-off-by: David S. Miller

atm: replace remaining FUNCTION occurrences

2008-03-06T02:38:07+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: David S. Miller

[ATM]: Spelling fixes

2007-12-20T22:05:37+00:00

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

Fix misspellings of "system", "controller", "interrupt" and "necessary".

2007-10-19T21:10:43+00:00

Fix the various misspellings of "system", controller", "interrupt" and
"[un]necessary".

Signed-off-by: Robert P. J. Day 
Signed-off-by: Adrian Bunk

more trivial signedness fixes in drivers

2007-10-14T19:41:52+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[ATM]: [drivers] ioremap balanced with iounmap

2007-07-18T08:46:55+00:00

Signed-off-by: Amol Lad 
Signed-off-by: chas williams 
Signed-off-by: David S. Miller

potential compiler error, irqfunc caller sites update

2007-07-06T17:23:43+00:00

In 7d12e780e003f93433d49ce78cfedf4b4c52adc5 David Howells performed
this evolution:
 "IRQ: Maintain regs pointer globally rather than passing to IRQ handlers"

He correctly updated many of the function definitions that were using this
extra regs pointer parameter but forgot to update some caller sites of
those functions.  The reason the modifications was not properly done on all
drivers is that some drivers were rarely compiled because they are for
AMIGA, or that some code sites were inside #ifdefs where the option is not
set or inside #if 0.

Here is the semantic patch that found the occurences
and fixed the problem.

@ rule1 @
identifier fn;
identifier irq, dev_id;
typedef irqreturn_t;
@@

static irqreturn_t fn(int irq, void *dev_id)
{
   ...
}

@@
identifier rule1.fn;
expression E1, E2, E3;
@@

 fn(E1, E2
-   ,E3
   )

Signed-off-by: Yoann Padioleau 
Cc: "David S. Miller" 
Cc: Jeff Garzik 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[ATM]: Fix warning.

2007-06-04T01:08:44+00:00

The compiler warning

drivers/atm/firestream.c: In function ‘top_off_fp’:
drivers/atm/firestream.c:1505: warning: cast to pointer from integer of different size

does indicate a bug, albeit a minor one.  Fixed, by using a 32-bit
temporary prior to the call to bus_to_virt().

The larger bug is still present:  the entire driver assumes that machine
pointers are 32-bit, as it stores pointers in 32-bit hardware registers.
This is obvious to anyone who knows the driver well, but for the casual
readers it is helpfully noted with FIXME.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[ATM] ambassador,firestream: "-1 >>" is implementation defined

2006-12-03T05:22:25+00:00

6.5.7(5): The result of E1 >> E2 is E1 right-shifted E2 bit positions.
		...
	If E1 has a signed type and a negative value, the resulting value
	is implementation defined.

So, cast -1 to unsigned type to make result well-defined.

[ Modified to use ~0U based upon recommendation from Al Viro. -DaveM ]

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

[ATM] firestream: handle thrown error

2006-10-22T02:55:24+00:00

gcc emits the following warning:

drivers/atm/firestream.c: In function ‘fs_open’:
drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function

This indicates a real bug.  We should check make_rate() return value for
potential errors.

Signed-off-by: Jeff Garzik 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller