linux.git/drivers/ata, branch v2.6.27

sata_nv: reinstate nv_hardreset() for non generic controllers

2008-09-29T04:14:34+00:00

Commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 which tried to remove
hardreset for generic accidentally removed it for all flavors as all
others were inheriting from nv_generic_ops.  This patch reinstates
nv_hardreset() and puts it into nv_common_ops which all flavors
inherit from.  nv_generic_ops now inherits from nv_common_ops and
overrides .hardreset to ATA_OP_NULL.

While at it, explain why nv_hardreset and ATA_OP_NULL override are
necessary.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

sata_inic162x: enable LED blinking

2008-09-13T20:43:20+00:00

Enable LED blinking.

Signed-off-by: Bob Stewart 
Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

ata: duplicate variable sparse warning

2008-09-13T20:43:18+00:00

drivers/ata/ata_piix.c:1502:7: warning: symbol 'rc' shadows an earlier one

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

ahci: RAID mode SATA patch for Intel Ibex Peak DeviceIDs

2008-09-08T16:15:54+00:00

Add the Intel Ibex Peak (PCH) SATA RAID Controller DeviceIDs.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik

pata_sil680: remove duplicate pcim_enable_device

2008-09-08T16:15:41+00:00

Remove duplicate call to pcim_enable_device in sil680_init_one.

Signed-off-by: David Milburn 
Signed-off-by: Jeff Garzik

libata-sff: kill spurious WARN_ON() in ata_hsm_move()

2008-09-08T16:15:38+00:00

On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
AC_ERR_HSM is not set.  PHY events may trigger HSM_ST_ERR with other
error codes and, with or without it, there just isn't much reason to
do WARN_ON() on it.  Even if error code is not set there, core EH
logic won't have any problem dealing with the error condition.

OSDL bz#11065 reports this problem.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

sata_nv: disable hardreset for generic

2008-09-08T16:15:35+00:00

of them being unifying probing, hotplug and EH reset paths uniform.
Previously, broken hardreset could go unnoticed as it wasn't used
during probing but when something goes wrong or after hotplug the
problem will surface and bite hard.

OSDL bug 11195 reports that sata_nv generic flavor falls into this
category.  Hardreset itself succeeds but PHY stays offline after
hardreset.  I tried longer debounce timing but the result was the
same.

  http://bugzilla.kernel.org/show_bug.cgi?id=11195

So, it seems we'll have to drop hardreset from the generic flavor.

Signed-off-by: Tejun Heo 
Cc: Peer Chen 
Signed-off-by: Jeff Garzik

ahci: disable PMP for marvell ahcis

2008-09-08T16:15:30+00:00

Marvell ahcis don't play nicely with PMPs.  Disable it.

Reported by KueiHuan Chen in the following thread.

  http://thread.gmane.org/gmane.linux.ide/33296

Signed-off-by: Tejun Heo 
Cc: KueiHuan Chen 
Cc: Mark Lord 
Signed-off-by: Jeff Garzik

sata_mv: add RocketRaid 1720 PCI ID to driver

2008-09-08T16:15:26+00:00

Signed-off-by: Petr Jelen 
Signed-off-by: Mark Lord 
Signed-off-by: Jeff Garzik

ahci, pata_marvell: play nicely together

2008-09-08T16:11:36+00:00

I've been chasing Jeff about this for months.  Jeff added the Marvell
device identifiers to the ahci driver without making the AHCI driver
handle the PATA port. This means a lot of users can't use current
kernels and in most distro cases can't even install.

This has been going on since March 2008 for the 6121 Marvell, and late 2007
for the 6145!!!

This was all pointed out at the time and repeatedly ignored. Bugs assigned
to Jeff about this are ignored also.

To quote Jeff in email

> "Just switch the order of 'ahci' and 'pata_marvell' in
> /etc/modprobe.conf, then use Fedora's tools regenerate the initrd.

> See?  It's not rocket science, and the current configuration can be
> easily made to work for Fedora users."

(Which isn't trivial, isn't end user, shouldn't be needed, and as it usually
breaks at install time is in fact impossible)

To quote Jeff in August 2007

> "   mv-ahci-pata
> Marvell 6121/6141 PATA support.  Needs fixing in the 'PATA controller
> command' area before it is usable, and can go upstream."

Only he add the ids anyway later and caused regressions, adding a further
id in March causing more regresions.

The actual fix for the moment is very simple. If the user has included
the pata_marvell driver let it drive the ports. If they've only selected
for SATA support give them the AHCI driver which will run the port a fraction
faster. Allow the user to control this decision via ahci.marvell_enable as
a module parameter so that distributions can ship 'it works' defaults and
smarter users (or config tools) can then flip it over it desired.

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik