linux.git/drivers/ata/libata-core.c, branch v5.19

libata: fix reading concurrent positioning ranges log

2022-06-08T03:19:08+00:00

The concurrent positioning ranges log is not a fixed size and may depend
on how many ranges are supported by the device. This patch uses the size
reported in the GPL directory to determine the number of pages supported
by the device before attempting to read this log page.

This resolves this error from the dmesg output:
    ata6.00: Read log 0x47 page 0x00 failed, Emask 0x1

Cc: stable@vger.kernel.org
Fixes: fe22e1c2f705 ("libata: support concurrent positioning ranges log")
Signed-off-by: Tyler Erickson 
Reviewed-by: Muhammad Ahmad 
Tested-by: Michael English 
Signed-off-by: Damien Le Moal

ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo()

2022-06-06T00:52:17+00:00

In an unlikely (and probably wrong?) case that the 'ppi' parameter of
ata_host_alloc_pinfo() points to an array starting with a NULL pointer,
there's going to be a kernel oops as the 'pi' local variable won't get
reassigned from the initial value of NULL. Initialize 'pi' instead to
'&ata_dummy_port_info' to fix the possible kernel oops for good...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

ata: libata-core: Allow forcing most horkage flags

2022-05-09T11:42:36+00:00

To facilitate debugging of drive issues in the field without kernel
changes (e.g. temporary test patches), add an entry for most horkage
flags in the force_tbl array to allow controlling these horkage
settings with the libata.force kernel boot parameter.

Signed-off-by: Damien Le Moal 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Hannes Reinecke

ata: libata-core: Improve link flags forced settings

2022-05-09T11:42:36+00:00

Similarly to the horkage flags, introduce the force_lflag_onoff() macro
to define struct ata_force_param entries of the force_tbl array that
allow turning on or off a link flag using the libata.force boot
parameter. To be consistent with naming, the macro force_lflag() is
renamed to force_lflag_on().

Using force_lflag_onoff(), define a new force_tbl entry for the
ATA_LFLAG_NO_DEBOUNCE_DELAY link flag, thus allowing testing if an
adapter requires a link debounce delay or not.

Signed-off-by: Damien Le Moal 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Hannes Reinecke

ata: libata-core: Refactor force_tbl definition

2022-05-09T11:42:36+00:00

Introduce the macro definitions force_cbl(), force_spd_limit(),
force_xfer(), force_lflag(), force_horkage_on() and
force_horkage_onoff() to define with a more compact syntax the struct
ata_force_param entries in the force_tbl array defined in the function
ata_parse_force_one().

To reduce the indentation of the array declaration, force_tbl definition
is also moved out of the ata_parse_force_one() function. The entries are
also reordered to group them by type of the quirck that is applied.

Finally, fix a comment in ata_parse_force_param() incorrectly
referencing force_tbl instead of ata_force_tbl.

Signed-off-by: Damien Le Moal 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Hannes Reinecke

ata: libata-core: cleanup ata_device_blacklist

2022-05-09T11:42:35+00:00

Remove the unneeded comma after the last field of the array entries.

Signed-off-by: Damien Le Moal 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Hannes Reinecke

ata: libata-core: replace "its" with "it is"

2022-04-21T23:38:18+00:00

and "isn't" with "is not". The former fixes the typo while the latter
just uses the same formal language.

Signed-off-by: Diego Viola 
Signed-off-by: Damien Le Moal

ata: libata-core: fix parameter type in ata_xfer_mode2shift()

2022-04-12T00:35:04+00:00

The data transfer mode that corresponds to the 'xfer_mode' parameter for
ata_xfer_mode2shift() is a 8-bit *unsigned* value.  Using *unsigned long*
to declare the parameter leads to a problematic implicit *int* to *unsigned
long* cast and was most probably a result of a copy/paste mistake -- use
the 'u8' type instead, as in ata_xfer_mode2mask()...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

libata: Improve ATA queued command allocation

2022-04-11T00:27:44+00:00

Improve ATA queued command allocation as follows:

- For attaining a qc tag for a SAS host we need to allocate a bit in
  ata_port.sas_tag_allocated bitmap.

  However we already have a unique tag per device in range
  [0, ATA_MAX_QUEUE -1] in the scsi cmnd budget token, so just use that
  instead.

- It is a bit pointless to have ata_qc_new_init() in libata-core.c since it
  pokes scsi internals, so inline it in ata_scsi_qc_new() (in
  libata-scsi.c). Also update Doc accordingly.

- Use standard SCSI helpers set_host_byte() and set_status_byte() in
  ata_scsi_qc_new().

Christoph Hellwig originally contributed the change to inline
ata_qc_new_init().

Signed-off-by: John Garry 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Damien Le Moal

ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs

2022-04-04T00:56:37+00:00

Samsung' 840 EVO with the latest firmware (EXT0DB6Q) locks up with
the a message: "READ LOG DMA EXT failed, trying PIO" during boot.

Initially this was discovered because it caused a crash
with the sata_dwc_460ex controller on a WD MyBook Live DUO.

The reporter "Tice Rex" which has the unique opportunity that he
has two Samsung 840 EVO SSD! One with the older firmware "EXT0BB0Q"
which booted fine and didn't expose "READ LOG DMA EXT". But the
newer/latest firmware "EXT0DB6Q" caused the headaches.

BugLink: https://github.com/openwrt/openwrt/issues/9505
Signed-off-by: Christian Lamparter 
Signed-off-by: Damien Le Moal