linux.git/drivers/ata/libata-core.c, branch v5.17

ata: libata-core: Disable TRIM on M88V29

2022-02-08T08:06:14+00:00

This device is a CF card, or possibly an SSD in CF form factor.
It supports NCQ and high speed DMA.

While it also advertises TRIM support, I/O errors are reported
when the discard mount option fstrim is used. TRIM also fails
when disabling NCQ and not just as an NCQ command.

TRIM must be disabled for this device.

Signed-off-by: Zoltán Böszörményi 
Signed-off-by: Damien Le Moal

ata: libata-core: Fix ata_dev_config_cpr()

2022-02-07T13:38:02+00:00

The concurrent positioning ranges log page 47h is a general purpose log
page and not a subpage of the indentify device log. Using
ata_identify_page_supported() to test for concurrent positioning ranges
support is thus wrong. ata_log_supported() must be used.

Furthermore, unlike other advanced ATA features (e.g. NCQ priority),
accesses to the concurrent positioning ranges log page are not gated by
a feature bit from the device IDENTIFY data. Since many older drives
react badly to the READ LOG EXT and/or READ LOG DMA EXT commands isued
to read device log pages, avoid problems with older drives by limiting
the concurrent positioning ranges support detection to drives
implementing at least the ACS-4 ATA standard (major version 11). This
additional condition effectively turns ata_dev_config_cpr() into a nop
for older drives, avoiding problems in the field.

Fixes: fe22e1c2f705 ("libata: support concurrent positioning ranges log")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215519
Cc: stable@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Tested-by: Abderraouf Adjal 
Signed-off-by: Damien Le Moal

ata: libata-core: Introduce ATA_HORKAGE_NO_LOG_DIR horkage

2022-02-04T07:44:23+00:00

06f6c4c6c3e8 ("ata: libata: add missing ata_identify_page_supported() calls")
introduced additional calls to ata_identify_page_supported(), thus also
adding indirectly accesses to the device log directory log page through
ata_log_supported(). Reading this log page causes SATADOM-ML 3ME devices
to lock up.

Introduce the horkage flag ATA_HORKAGE_NO_LOG_DIR to prevent accesses to
the log directory in ata_log_supported() and add a blacklist entry
with this flag for "SATADOM-ML 3ME" devices.

Fixes: 636f6e2af4fb ("libata: add horkage for missing Identify Device log")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Anton Lundin 
Signed-off-by: Damien Le Moal

ata: fix read_id() ata port operation interface

2022-01-14T06:17:16+00:00

Drivers that need to tweak a device IDENTIFY data implement the
read_id() port operation. The IDENTIFY data buffer is passed as an
argument to the read_id() operation for drivers to use. However, when
this operation is called, the IDENTIFY data is not yet converted to CPU
endian and contains le16 words.

Change the interface of the read_id operation to pass a __le16 * pointer
to the IDENTIFY data buffer to clarify the buffer endianness. Fix the
pata_netcell, pata_it821x, ahci_xgene, ahci_ceva and ahci_brcm drivers
implementation of this operation and modify the code to corretly deal
with identify data words manipulation to avoid sparse warnings such as:

drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
drivers/ata/ahci_xgene.c:262:33:    left side has type unsigned short
drivers/ata/ahci_xgene.c:262:33:    right side has type restricted __le16

Signed-off-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke

ata: libata: drop ata_msg_drv()

2022-01-05T10:33:02+00:00

Callers are already protected by ata_dev_print_info(), so no need
to have an additional configuration parameter here.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_info()

2022-01-05T10:33:02+00:00

Convert the sole caller to ata_dev_dbg() and remove the definition.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_probe()

2022-01-05T10:33:02+00:00

All callsites have been converted to dynamic debugging.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_warn()

2022-01-05T10:33:02+00:00

The WARN level was always enabled, so drop ata_msg_warn().

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_malloc()

2022-01-05T10:33:02+00:00

Unused.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_ctl()

2022-01-05T10:33:02+00:00

The one caller have been converted to dynamic debugging.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal