linux.git/drivers/acpi/utils.c, branch v5.2-rc2

ACPI / utils: Remove deprecated function since no user left

2019-04-01T09:00:16+00:00

There is no more user of acpi_dev_get_first_match_name(),
which is deprecated and has no user left, so, remove it for good.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper

2019-04-01T08:55:56+00:00

The acpi_dev_get_first_match_name() is missing put_device() call
and thus keeping reference counting unbalanced.

In order to fix the issue introduce a new helper to convert existing users
one-by-one to a better API.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Hans de Goede 
Reviewed-by: Mika Westerberg 
Acked-by: Mark Brown 
Signed-off-by: Rafael J. Wysocki

ACPI / utils: Drop reference in test for device presence

2019-03-19T21:34:21+00:00

When commit 8661423eea1a ("ACPI / utils: Add new acpi_dev_present
helper") introduced acpi_dev_present(), it missed the fact that
bus_find_device() took a reference on the device found by it and
the callers of acpi_dev_present() don't drop that reference.

Drop the reference on the device in acpi_dev_present().

Fixes: 8661423eea1a ("ACPI / utils: Add new acpi_dev_present helper")
Signed-off-by: Andy Shevchenko 
Reviewed-by: Hans de Goede 
Signed-off-by: Rafael J. Wysocki

ACPI: utils: Introduce acpi_dev_get_first_match_name()

2018-01-09T23:41:43+00:00

Sometimes the user wants to have device name of the match rather than
just checking if device present or not. To make life easier for such
users introduce acpi_dev_get_first_match_name() helper based on code
for acpi_dev_present().

For example, GPIO driver for Intel Merrifield needs to know the device
name of pin control to be able to apply GPIO mapping table to the proper
device.

To be more consistent with the purpose rename

  struct acpi_dev_present_info  -> struct acpi_dev_match_info
  acpi_dev_present_cb()         -> acpi_dev_match_cb()

in the utils.c file.

Tested-by: Pierre-Louis Bossart 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Rafael J. Wysocki

ACPI / utils: Fix memory leak in acpi_evaluate_reference() error path

2017-11-14T11:54:55+00:00

When package.count is larger than ACPI_MAX_HANDLES, buffer.pointer is
not freed before the function returns AE_NO_MEMORY. Fix this possible
memory leak by kfree'ing it.

Signed-off-by: Xiongfeng Wang 
Signed-off-by: Rafael J. Wysocki

ACPI / blacklist: add acpi_match_platform_list()

2017-08-28T23:42:48+00:00

ACPI OEM ID / OEM Table ID / Revision can be used to identify
a platform based on ACPI firmware info.  acpi_blacklisted(),
intel_pstate_platform_pwr_mgmt_exists(), and some other funcs,
have been using similar check to detect a list of platforms
that require special handlings.

Move the platform check in acpi_blacklisted() to a new common
utility function, acpi_match_platform_list(), so that other
drivers do not have to implement their own version.

There is no change in functionality.

Signed-off-by: Toshi Kani 
Reviewed-by: Borislav Petkov 
Signed-off-by: Rafael J. Wysocki

ACPI: Switch to use generic guid_t in acpi_evaluate_dsm()

2017-06-07T10:20:49+00:00

acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16
bytes. Instead we convert them to use guid_t type. At the same time we
convert current users.

acpi_str_to_uuid() becomes useless after the conversion and it's safe to
get rid of it.

Acked-by: Rafael J. Wysocki 
Cc: Borislav Petkov 
Acked-by: Dan Williams 
Cc: Amir Goldstein 
Reviewed-by: Jarkko Sakkinen 
Reviewed-by: Jani Nikula 
Acked-by: Jani Nikula 
Cc: Ben Skeggs 
Acked-by: Benjamin Tissoires 
Acked-by: Joerg Roedel 
Acked-by: Adrian Hunter 
Cc: Yisen Zhuang 
Acked-by: Bjorn Helgaas 
Acked-by: Felipe Balbi 
Acked-by: Mathias Nyman 
Reviewed-by: Heikki Krogerus 
Acked-by: Mark Brown 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Christoph Hellwig

ACPI / utils: Add new acpi_dev_present helper

2017-04-19T20:53:34+00:00

acpi_dev_found just iterates over all ACPI-ids and sees if one matches.
This means that it will return true for devices which are in the DSDT
but disabled (their _STA method returns 0).

For some drivers it is useful to be able to check if a certain HID
is not only present in the namespace, but also actually present as in
acpi_device_is_present() will return true for the device. For example
because if a certain device is present then the driver will want to use
an extcon or IIO ADC channel provided by that device.

This commit adds a new acpi_dev_present helper which drivers can use
to this end.

Like acpi_dev_found, acpi_dev_present take a HID as argument, but
it also has 2 extra optional arguments to only check for an ACPI
device with a specific UID and/or HRV value. This makes it more
generic and allows it to replace custom code doing similar checks
in several places.

Arguably acpi_dev_present is what acpi_dev_found should have been, but
there are too many users to just change acpi_dev_found without the risk
of breaking something.

Signed-off-by: Hans de Goede 
Reviewed-by: Lukas Wunner 
Reviewed-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

nfit: make DIMM DSMs optional

2016-07-19T19:32:39+00:00

Commit 4995734e973a "acpi, nfit: fix acpi_check_dsm() vs zero functions
implemented" attempted to fix a QEMU regression by supporting its usage
of a zero-mask as a valid response to a DSM-family probe request.
However, this behavior breaks HP platforms that return a zero-mask by
default causing the probe to misidentify the DSM-family.

Instead, the QEMU regression can be fixed by simply not requiring the DSM
family to be identified.

This effectively reverts commit 4995734e973a, and removes the DSM
requirement from the init path.

Cc: "Rafael J. Wysocki" 
Cc: Xiao Guangrong 
Cc: Linda Knippers 
Fixes: 4995734e973a ("acpi, nfit: fix acpi_check_dsm() vs zero functions implemented")
Reported-by: Jerry Hoemann 
Tested-by: Jerry Hoemann 
Signed-off-by: Dan Williams

acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-06-24T16:07:39+00:00

QEMU 2.6 implements nascent support for nvdimm DSMs. Depending on
configuration it may only implement the function0 dsm to indicate that
no other DSMs are available. Commit 31eca76ba2fc "nfit, libnvdimm:
limited/whitelisted dimm command marshaling mechanism" breaks QEMU, but
QEMU is spec compliant.  Per the spec the way to indicate that no
functions are supported is:

    If Function Index is zero, the return is a buffer containing one bit
    for each function index, starting with zero. Bit 0 indicates whether
    there is support for any functions other than function 0 for the
    specified UUID and Revision ID. If set to zero, no functions are
    supported (other than function zero) for the specified UUID and
    Revision ID.

Update the nfit driver to determine the family (interface UUID) without
requiring the implementation to define any other functions, i.e.
short-circuit acpi_check_dsm() to succeed per the spec.  The nfit driver
appears to be the only user passing funcs==0 to acpi_check_dsm(), so
this behavior change of the common routine should be limited to the
probing done by the nfit driver.

Cc: Len Brown 
Cc: Jerry Hoemann 
Acked-by: "Rafael J. Wysocki" 
Fixes: 31eca76ba2fc ("nfit, libnvdimm: limited/whitelisted dimm command marshaling mechanism")
Reported-by: Xiao Guangrong 
Tested-by: Xiao Guangrong 
Signed-off-by: Dan Williams