linux.git/drivers/acpi/resource.c, branch v4.1

x86/PCI/ACPI: Make all resources except [io 0xcf8-0xcff] available on PCI bus

2015-04-30T20:17:34+00:00

An IO port or MMIO resource assigned to a PCI host bridge may be
consumed by the host bridge itself or available to its child
bus/devices. The ACPI specification defines a bit (Producer/Consumer)
to tell whether the resource is consumed by the host bridge itself,
but firmware hasn't used that bit consistently, so we can't rely on it.

Before commit 593669c2ac0f ("x86/PCI/ACPI: Use common ACPI resource
interfaces to simplify implementation"), arch/x86/pci/acpi.c ignored
all IO port resources defined by acpi_resource_io and
acpi_resource_fixed_io to filter out IO ports consumed by the host
bridge itself.

Commit 593669c2ac0f ("x86/PCI/ACPI: Use common ACPI resource interfaces
to simplify implementation") started accepting all IO port and MMIO
resources, which caused a regression that IO port resources consumed
by the host bridge itself became available to its child devices.

Then commit 63f1789ec716 ("x86/PCI/ACPI: Ignore resources consumed by
host bridge itself") ignored resources consumed by the host bridge
itself by checking the IORESOURCE_WINDOW flag, which accidently removed
MMIO resources defined by acpi_resource_memory24, acpi_resource_memory32
and acpi_resource_fixed_memory32.

On x86 and IA64 platforms, all IO port and MMIO resources are assumed
to be available to child bus/devices except one special case:
    IO port [0xCF8-0xCFF] is consumed by the host bridge itself
    to access PCI configuration space.

So explicitly filter out PCI CFG IO ports[0xCF8-0xCFF]. This solution
will also ease the way to consolidate ACPI PCI host bridge common code
from x86, ia64 and ARM64.

Related ACPI table are archived at:
https://bugzilla.kernel.org/show_bug.cgi?id=94221

Related discussions at:
http://patchwork.ozlabs.org/patch/461633/
https://lkml.org/lkml/2015/3/29/304

Fixes: 63f1789ec716 (Ignore resources consumed by host bridge itself)
Reported-by: Bernhard Thaler 
Signed-off-by: Jiang Liu 
Cc: 4.0+  # 4.0+
Reviewed-by: Bjorn Helgaas 
Signed-off-by: Rafael J. Wysocki

x86/PCI/ACPI: Relax ACPI resource descriptor checks to work around BIOS bugs

2015-03-04T13:09:50+00:00

Some BIOSes report incorrect length for ACPI address space descriptors,
so relax the checks to avoid regressions. This issue has appeared several
times as:
 3162b6f0c5e1 ("PNPACPI: truncate _CRS windows with _LEN > _MAX - _MIN + 1")
 d558b483d5a7 ("x86/PCI: truncate _CRS windows with _LEN > _MAX - _MIN + 1")
 f238b414a74a ("PNPACPI: compute Address Space length rather than using _LEN")
 48728e077480 ("x86/PCI: compute Address Space length rather than using _LEN")

Please refer to https://bugzilla.kernel.org/show_bug.cgi?id=94221
for more details and example malformed ACPI resource descriptors.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=94221
Fixes: 593669c2ac0f (x86/PCI/ACPI: Use common ACPI resource interfaces ...)
Signed-off-by: Jiang Liu 
Tested-by: Dave Airlie 
Tested-by: Prakash Punnoor 
Signed-off-by: Rafael J. Wysocki

ACPI / resources: Change pr_info() to pr_debug() for debug information

2015-02-18T07:05:43+00:00

Annoying and noisy ACPI debug messages are printed with pr_info()
after the recent ACPI resources handling rework.  Replace the
pr_info() with pr_debug() to reduce to noise level.

Reported-by: Borislav Petkov 
Signed-off-by: Rafael J. Wysocki

resources: Move struct resource_list_entry from ACPI into resource core

2015-02-05T14:09:25+00:00

Currently ACPI, PCI and pnp all implement the same resource list
management with different data structure. We need to transfer from
one data structure into another when passing resources from one
subsystem into another subsystem. So move struct resource_list_entry
from ACPI into resource core and rename it as resource_entry,
then it could be reused by different subystems and avoid the data
structure conversion.

Introduce dedicated header file resource_ext.h instead of embedding
it into ioport.h to avoid header file inclusion order issues.

Signed-off-by: Jiang Liu 
Acked-by: Vinod Koul 
Signed-off-by: Rafael J. Wysocki

ACPI: Introduce helper function acpi_dev_filter_resource_type()

2015-02-03T21:27:23+00:00

Introduce helper function acpi_dev_filter_resource_type(), which may
be used by acpi_dev_get_resources() to filer out resource based on
resource type.

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki

ACPI: Add field offset to struct resource_list_entry

2015-02-03T21:27:23+00:00

Add field offset to struct resource_list_entry to host address space
translation offset so it could be used to represent bridge resources.

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki

ACPI: Translate resource into master side address for bridge window resources

2015-02-03T21:27:21+00:00

Add translation_offset into the result address for bridge window
resources to form the master side address.

Currently acpi_dev_resource_{ext_}address_space() are only used for
devices instead of bridges, so it won't break current users. Later
it will be used to support PCI host bridge drivers.

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki

ACPI: Return translation offset when parsing ACPI address space resources

2015-02-03T21:27:21+00:00

Change function acpi_dev_resource_address_space() and
acpi_dev_resource_ext_address_space() to return address space
translation offset.

It's based on a patch from Yinghai Lu .

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki

ACPI: Enforce stricter checks for address space descriptors

2015-02-03T21:27:21+00:00

Enforce stricter checks for address space descriptors according to
ACPI spec.

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki

ACPI: Set flag IORESOURCE_UNSET for unassigned resources

2015-02-03T21:27:20+00:00

Also set flag IORESOURCE_UNSET for unassigned resource in addition to
IORESOURCE_DISABLED to mark resource as unassigned.

Signed-off-by: Jiang Liu 
Signed-off-by: Rafael J. Wysocki