linux.git/drivers/accel, branch v7.0-rc2

accel/amdxdna: Use a different name for latest firmware

2026-02-25T21:51:31+00:00

Using legacy driver with latest firmware causes a power off issue.

Fix this by assigning a different filename (npu_7.sbin) to the latest
firmware. The driver attempts to load the latest firmware first and falls
back to the previous firmware version if loading fails.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/5009
Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260225204752.2711734-1-lizhi.hou@amd.com

accel/amdxdna: Validate command buffer payload count

2026-02-23T17:24:21+00:00

The count field in the command header is used to determine the valid
payload size. Verify that the valid payload does not exceed the remaining
buffer space.

Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260219211946.1920485-1-lizhi.hou@amd.com

accel/amdxdna: Prevent ubuf size overflow

2026-02-23T17:24:21+00:00

The ubuf size calculation may overflow, resulting in an undersized
allocation and possible memory corruption.

Use check_add_overflow() helpers to validate the size calculation before
allocation.

Fixes: bd72d4acda10 ("accel/amdxdna: Support user space allocated buffer")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260217192815.1784689-1-lizhi.hou@amd.com

accel/amdxdna: Fix out-of-bounds memset in command slot handling

2026-02-23T17:24:20+00:00

The remaining space in a command slot may be smaller than the size of
the command header. Clearing the command header with memset() before
verifying the available slot space can result in an out-of-bounds write
and memory corruption.

Fix this by moving the memset() call after the size validation.

Fixes: 3d32eb7a5ecf ("accel/amdxdna: Fix cu_idx being cleared by memset() during command setup")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260217185415.1781908-1-lizhi.hou@amd.com

accel/amdxdna: Fix command hang on suspended hardware context

2026-02-23T17:24:19+00:00

When a hardware context is suspended, the job scheduler is stopped. If a
command is submitted while the context is suspended, the job is queued in
the scheduler but aie2_sched_job_run() is never invoked to restart the
hardware context. As a result, the command hangs.

Fix this by modifying the hardware context suspend routine to keep the job
scheduler running so that queued jobs can trigger context restart properly.

Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260211205341.722982-1-lizhi.hou@amd.com

accel/amdxdna: Fix suspend failure after enabling turbo mode

2026-02-23T17:24:19+00:00

Enabling turbo mode disables hardware clock gating. Suspend requires
hardware clock gating to be re-enabled, otherwise suspend will fail.
Fix this by calling aie2_runtime_cfg() from aie2_hw_stop() to
re-enable clock gating during suspend. Also ensure that firmware is
initialized in aie2_hw_start() before modifying clock-gating
settings during resume.

Fixes: f4d7b8a6bc8c ("accel/amdxdna: Enhance power management settings")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260211204716.722788-1-lizhi.hou@amd.com

accel/amdxdna: Fix dead lock for suspend and resume

2026-02-23T17:24:17+00:00

When an application issues a query IOCTL while auto suspend is running,
a deadlock can occur. The query path holds dev_lock and then calls
pm_runtime_resume_and_get(), which waits for the ongoing suspend to
complete. Meanwhile, the suspend callback attempts to acquire dev_lock
and blocks, resulting in a deadlock.

Fix this by releasing dev_lock before calling pm_runtime_resume_and_get()
and reacquiring it after the call completes. Also acquire dev_lock in the
resume callback to keep the locking consistent.

Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260211204644.722758-1-lizhi.hou@amd.com

accel/amdxdna: Reduce log noise during process termination

2026-02-23T17:24:16+00:00

During process termination, several error messages are logged that are
not actual errors but expected conditions when a process is killed or
interrupted. This creates unnecessary noise in the kernel log.

The specific scenarios are:

1. HMM invalidation returns -ERESTARTSYS when the wait is interrupted by
   a signal during process cleanup. This is expected when a process is
   being terminated and should not be logged as an error.

2. Context destruction returns -ENODEV when the firmware or device has
   already stopped, which commonly occurs during cleanup if the device
   was already torn down. This is also an expected condition during
   orderly shutdown.

Downgrade these expected error conditions from error level to debug level
to reduce log noise while still keeping genuine errors visible.

Fixes: 97f27573837e ("accel/amdxdna: Fix potential NULL pointer dereference in context cleanup")
Reviewed-by: Lizhi Hou 
Signed-off-by: Mario Limonciello 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260210164521.1094274-3-mario.limonciello@amd.com

accel/amdxdna: Fix crash when destroying a suspended hardware context

2026-02-23T17:24:15+00:00

If userspace issues an ioctl to destroy a hardware context that has
already been automatically suspended, the driver may crash because the
mailbox channel pointer is NULL for the suspended context.

Fix this by checking the mailbox channel pointer in aie2_destroy_context()
before accessing it.

Fixes: 97f27573837e ("accel/amdxdna: Fix potential NULL pointer dereference in context cleanup")
Reviewed-by: Karol Wachowski 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260206060306.4050531-1-lizhi.hou@amd.com

accel/amdxdna: Switch to always use chained command

2026-02-23T17:24:15+00:00

Preempt commands are only supported when submitted as chained commands.
To ensure preempt support works consistently, always submit commands in
chained command format.

Set force_cmdlist to true so that single commands are filled using the
chained command layout, enabling correct handling of preempt commands.

Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
Reviewed-by: Karol Wachowski 
Reviewed-by: Mario Limonciello (AMD) 
Signed-off-by: Lizhi Hou 
Link: https://patch.msgid.link/20260206060251.4050512-1-lizhi.hou@amd.com