linux.git/crypto/xcbc.c, branch v2.6.27

[CRYPTO] xcbc: Fix crash when ipsec uses xcbc-mac with big data chunk

2008-04-02T06:36:09+00:00

The kernel crashes when ipsec passes a udp packet of about 14XX bytes
of data to aes-xcbc-mac.

It seems the first xxxx bytes of the data are in first sg entry,
and remaining xx bytes are in next sg entry. But we don't 
check next sg entry to see if we need to go look the page up.

I noticed in hmac.c, we do a scatterwalk_sg_next(), to do this check
and possible lookup, thus xcbc.c needs to use this routine too.

A 15-hour run of an ipsec stress test sending streams of tcp and
udp packets of various sizes,  using this patch and 
aes-xcbc-mac completed successfully, so hopefully this fixes the
problem.
 
Signed-off-by: Joy Latten 
Signed-off-by: Herbert Xu

[CRYPTO] xcbc: Fix crash with IPsec

2008-03-06T11:28:44+00:00

When using aes-xcbc-mac for authentication in IPsec, 
the kernel crashes. It seems this algorithm doesn't 
account for the space IPsec may make in scatterlist for authtag.
Thus when crypto_xcbc_digest_update2() gets called,
nbytes may be less than sg[i].length. 
Since nbytes is an unsigned number, it wraps
at the end of the loop allowing us to go back 
into loop and causing crash in memcpy.

I used update function in digest.c to model this fix.
Please let me know if it looks ok.

Signed-off-by: Joy Latten 
Signed-off-by: Herbert Xu

Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)

2008-02-07T16:42:26+00:00

Convert instances of ERR_PTR(PTR_ERR(p)) to ERR_CAST(p) using:

perl -spi -e 's/ERR_PTR[(]PTR_ERR[(](.*)[)][)]/ERR_CAST(\1)/' `grep -rl 'ERR_PTR[(]*PTR_ERR' fs crypto net security`

Signed-off-by: David Howells 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[CRYPTO] xcbc: Remove bogus hash/cipher test

2008-01-10T21:17:00+00:00

When setting the digest size xcbc tests to see if the underlying algorithm
is a hash.  This is silly because we don't allow it to be a hash and we've
specifically requested for a cipher.

This patch removes the bogus test.

Signed-off-by: Herbert Xu

[CRYPTO] xcbc: Fix algorithm leak when block size check fails

2008-01-10T21:17:00+00:00

When the underlying algorithm has a block size other than 16 we abort
without freeing it.  In fact, we try to return the algorithm itself
as an error!

This patch plugs the leak and makes it return -EINVAL instead.

Signed-off-by: Herbert Xu

[CRYPTO] scatterwalk: Move scatterwalk.h to linux/crypto

2008-01-10T21:16:32+00:00

The scatterwalk infrastructure is used by algorithms so it needs to
move out of crypto for future users that may live in drivers/crypto
or asm/*/crypto.

Signed-off-by: Herbert Xu

[SG] Update crypto/ to sg helpers

2007-10-22T17:40:16+00:00

Signed-off-by: Jens Axboe

[CRYPTO] templates: Pass type/mask when creating instances

2007-05-02T04:38:31+00:00

This patch passes the type/mask along when constructing instances of
templates.  This is in preparation for templates that may support
multiple types of instances depending on what is requested.  For example,
the planned software async crypto driver will use this construct.

For the moment this allows us to check whether the instance constructed
is of the correct type and avoid returning success if the type does not
match.

Signed-off-by: Herbert Xu

[CRYPTO] xcbc: Use new cipher interface

2007-02-06T22:21:01+00:00

This patch changes xcbc to use the new cipher encryt_one interface.

Signed-off-by: Herbert Xu

[CRYPTO] api: Add type-safe spawns

2007-02-06T22:21:01+00:00

This patch allows spawns of specific types (e.g., cipher) to be allocated.

Signed-off-by: Herbert Xu