linux.git/crypto/drbg.c, branch v4.12

crypto: drbg - wait for crypto op not signal safe

2017-05-23T04:45:11+00:00

drbg_kcapi_sym_ctr() was using wait_for_completion_interruptible() to
wait for completion of async crypto op but if a signal occurs it
may return before DMA ops of HW crypto provider finish, thus
corrupting the output buffer.

Resolve this by using wait_for_completion() instead.

Reported-by: Eric Biggers 
Signed-off-by: Gilad Ben-Yossef 
CC: stable@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: DRBG - initialize SGL only once

2017-03-24T14:03:01+00:00

An SGL to be initialized only once even when its buffers are written
to several times.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

2016-11-30T11:53:12+00:00

Merge the crypto tree to pull in chelsio chcr fix.

crypto: drbg - prevent invalid SG mappings

2016-11-30T11:46:44+00:00

When using SGs, only heap memory (memory that is valid as per
virt_addr_valid) is allowed to be referenced. The CTR DRBG used to
reference the caller-provided memory directly in an SG. In case the
caller provided stack memory pointers, the SG mapping is not considered
to be valid. In some cases, this would even cause a paging fault.

The change adds a new scratch buffer that is used unconditionally to
catch the cases where the caller-provided buffer is not suitable for
use in an SG. The crypto operation of the CTR DRBG produces its output
with that scratch buffer and finally copies the content of the
scratch buffer to the caller's buffer.

The scratch buffer is allocated during allocation time of the CTR DRBG
as its access is protected with the DRBG mutex.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - advance output buffer pointer

2016-11-21T14:50:24+00:00

The CTR DRBG segments the number of random bytes to be generated into
128 byte blocks. The current code misses the advancement of the output
buffer pointer when the requestor asks for more than 128 bytes of data.
In this case, the next 128 byte block of random numbers is copied to
the beginning of the output buffer again. This implies that only the
first 128 bytes of the output buffer would ever be filled.

The patch adds the advancement of the buffer pointer to fill the entire
buffer.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - fix error return code

2016-08-24T13:04:49+00:00

Fix to return a negative error code from the error handling
case instead of 0.

Signed-off-by: Wei Yongjun 
Acked-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - do not call drbg_instantiate in healt test

2016-08-16T09:20:19+00:00

When calling the DRBG health test in FIPS mode, the Jitter RNG is not
yet present in the kernel crypto API which will cause the instantiation
to fail and thus the health test to fail.

As the health tests cover the enforcement of various thresholds, invoke
the functions that are supposed to enforce the thresholds directly.

This patch also saves precious seed.

Reported-by: Tapas Sarangi 
Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - fix an error code in drbg_init_sym_kernel()

2016-06-20T11:25:03+00:00

We accidentally return PTR_ERR(NULL) which is success but we should
return -ENOMEM.

Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES')
Signed-off-by: Dan Carpenter 
Acked-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - fix semicolon.cocci warnings

2016-06-20T11:24:36+00:00

crypto/drbg.c:1637:39-40: Unneeded semicolon

 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Stephan Mueller 
Signed-off-by: Fengguang Wu 
Acked-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - avoid duplicate maintenance of key

2016-06-15T09:07:54+00:00

The TFM object maintains the key for the CTR DRBG.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu