linux.git/crypto/cryptd.c, branch v4.15

crypto: change transient busy return code to -ENOSPC

2017-11-03T14:11:16+00:00

The crypto API was using the -EBUSY return value to indicate
both a hard failure to submit a crypto operation into a
transformation provider when the latter was busy and the backlog
mechanism was not enabled as well as a notification that the
operation was queued into the backlog when the backlog mechanism
was enabled.

Having the same return code indicate two very different conditions
depending on a flag is both error prone and requires extra runtime
check like the following to discern between the cases:

	if (err == -EINPROGRESS ||
	    (err == -EBUSY && (ahash_request_flags(req) &
			       CRYPTO_TFM_REQ_MAY_BACKLOG)))

This patch changes the return code used to indicate a crypto op
failed due to the transformation provider being transiently busy
to -ENOSPC.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: cryptd - Add support for skcipher

2016-11-28T13:23:18+00:00

This patch adds skcipher support to cryptd alongside ablkcipher.

Signed-off-by: Herbert Xu

crypto: cryptd - Remove unused but set variable 'tfm'

2016-11-01T00:37:17+00:00

Remove the unused but set variable tfm in cryptd_enqueue_request to fix
the following warning when building with 'W=1':

crypto/cryptd.c:125:21: warning: variable 'tfm' set but not used [-Wunused-but-set-variable]

Signed-off-by: Tobias Klauser 
Signed-off-by: Herbert Xu

crypto: cryptd - initialize child shash_desc on import

2016-09-07T13:04:36+00:00

When calling .import() on a cryptd ahash_request, the structure members
that describe the child transform in the shash_desc need to be initialized
like they are when calling .init()

Cc: stable@vger.kernel.org
Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: cryptd - Use correct tfm object for AEAD tracking

2016-08-31T14:50:40+00:00

The AEAD code path incorrectly uses the child tfm to track the
cryptd refcnt, and then potentially frees the child tfm.

Fixes: 81760ea6a95a ("crypto: cryptd - Add helpers to check...")
Reported-by: Sowmini Varadhan 
Signed-off-by: Herbert Xu

crypto: cryptd - Add helpers to check whether a tfm is queued

2016-06-23T10:29:52+00:00

This patch adds helpers to check whether a given tfm is currently
queued.  This is meant to be used by ablk_helper and similar
entities to ensure that no reordering is introduced because of
requests queued in cryptd with respect to requests being processed
in softirq context.

The per-cpu queue length limit is also increased to 1000 in line
with network limits.

Signed-off-by: Herbert Xu

crypto: cryptd - Assign statesize properly

2015-12-04T14:29:53+00:00

cryptd_create_hash() fails by returning -EINVAL.  It is because after
8996eafdc ("crypto: ahash - ensure statesize is non-zero") all ahash
drivers must have a non-zero statesize.

This patch fixes the problem by properly assigning the statesize.

Signed-off-by: Rui Wang 
Signed-off-by: Herbert Xu

crypto: cryptod - use crypto_skcipher_type() for getting skcipher type

2015-11-27T13:22:18+00:00

The  provides inline function - crypto_skcipher_type().
Let's use it in the cryptd_alloc_ablkcipher() instead of direct calculation.

Signed-off-by: Alexander Kuleshov 
Signed-off-by: Herbert Xu

crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag

2015-08-17T08:53:53+00:00

This patch removes the CRYPTO_ALG_AEAD_NEW flag now that everyone
has been converted.

Signed-off-by: Herbert Xu

crypto: cryptd - Remove reference to crypto_aead_crt

2015-08-17T08:53:46+00:00

Pretty soon the crypto_aead encrypt/decrypt hooks will disappear
as they are now always identical to those in struct aead_alg.

This patch replaces the references to these hooks with the ones
from aead_alg instead.

Signed-off-by: Herbert Xu