linux.git/crypto/blake2b_generic.c, branch v5.5

crypto: blake2b - rename tfm context and _setkey callback

2019-11-22T10:48:35+00:00

The TFM context can be renamed to a more appropriate name and the local
varaibles as well, using 'tctx' which seems to be more common than
'mctx'.

The _setkey callback was the last one without the blake2b_ prefix,
rename that too.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - merge _update to api callback

2019-11-22T10:48:35+00:00

Now that there's only one call to blake2b_update, we can merge it to the
callback and simplify. The empty input check is split and the rest of
code un-indented.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - open code set last block helper

2019-11-22T10:48:35+00:00

The helper is trival and called once, inlining makes things simpler.
There's a comment to tie it back to the idea behind the code.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - delete unused structs or members

2019-11-22T10:48:35+00:00

All the code for param block has been inlined, last_node and outlen from
the state are not used or have become redundant due to other code.
Remove it.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - simplify key init

2019-11-22T10:48:35+00:00

The keyed init writes the key bytes to the input buffer and does an
update. We can do that in two ways: fill the buffer and update
immediatelly. This is what current blake2b_init_key does. Any other
following _update or _final will continue from the updated state.

The other way is to write the key and set the number of bytes to process
at the next _update or _final, lazy evaluation. Which leads to the the
simplified code in this patch.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - merge blake2 init to api callback

2019-11-22T10:48:34+00:00

The call chain from blake2b_init can be simplified because the param
block is effectively zeros, besides the key.

- blake2b_init0 zeroes state and sets IV
- blake2b_init sets up param block with defaults (key and some 1s)
- init with key, write it to the input buffer and recalculate state

So the compact way is to zero out the state and initialize index 0 of
the state directly with the non-zero values and the key.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - merge _final implementation to callback

2019-11-22T10:48:34+00:00

blake2b_final is called only once, merge it to the crypto API callback
and simplify. This avoids the temporary buffer and swaps the bytes of
internal buffer.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu

crypto: blake2b - add blake2b generic implementation

2019-11-01T05:38:31+00:00

The patch brings support of several BLAKE2 variants (2b with various
digest lengths).  The keyed digest is supported, using tfm->setkey call.
The in-tree user will be btrfs (for checksumming), we're going to use
the BLAKE2b-256 variant.

The code is reference implementation taken from the official sources and
modified in terms of kernel coding style (whitespace, comments, uintXX_t
-> uXX types, removed unused prototypes and #ifdefs, removed testing
code, changed secure_zero_memory -> memzero_explicit, used own helpers
for unaligned reads/writes and rotations).

Further changes removed sanity checks of key length or output size,
these values are verified in the crypto API callbacks or hardcoded in
shash_alg and not exposed to users.

Signed-off-by: David Sterba 
Signed-off-by: Herbert Xu